Keep an alias to RemoveDirectory, will be removed in a later change.
TEST=new unit test to test this function
BUG=none
Review URL: http://codereview.chromium.org/6628032
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77463 0039d316-1c4b-4281-b951-d872f2087c98
Improve test to make sure svn status comes out clean.
TEST=improved unit tests and scm.SVN.Revert() should now do the right thing
BUG=none
Review URL: http://codereview.chromium.org/6650011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77391 0039d316-1c4b-4281-b951-d872f2087c98
The tests now base the directory in mkdtemp() which is much safer than using the
source's file directory as before.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6625018
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77278 0039d316-1c4b-4281-b951-d872f2087c98
Using reset --soft doesn't require touching the working copy, so it should be faster and not require rebuilds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6575031
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77267 0039d316-1c4b-4281-b951-d872f2087c98
neither SyntaxError or ANYONE is used at, but they will be shortly.
Review URL: http://codereview.chromium.org/6609012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76978 0039d316-1c4b-4281-b951-d872f2087c98
Ease support for different port if necessary.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6632007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76968 0039d316-1c4b-4281-b951-d872f2087c98
Add code to wait for the bound port to open and close correctly, removing race
conditions.
BUG=test reliability
TEST=better
Review URL: http://codereview.chromium.org/6627013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76966 0039d316-1c4b-4281-b951-d872f2087c98
Add a unit test to catch potential regressions. Remove an old test new code broke.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/6613025
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76805 0039d316-1c4b-4281-b951-d872f2087c98
URL value is dependent on the local directory. The current directory would
affect Base URL on Rietveld otherwise.
Do not use Repository Root instead of URL since git svn clone foo -T bar
wouldn't be correctly based.
Update RunCommand() to be able to pass cwd argument.
TEST=git cl upload is broken if I break this code.
BUG=none
Review URL: http://codereview.chromium.org/6591093
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76791 0039d316-1c4b-4281-b951-d872f2087c98
The svn branch heuristic does roughly the same thing git-svn does: We first iterate backwards over the history to find the svn URL (like svn://svn.chromium.org/chrome/trunk/src). Then we go through all defined svn-remote section looking for one where the URL is the root of the svn URL (svn://svn.chromium.org/chrome in that case), and the fetch spec looks like "trunk/src:remotes/origin/trunk". If the base URL + left part (trunk/src) is the full URL, the right part (remotes/origin/trunk) is the git ref that is updated when we do a `git svn fetch`! This works for git-svn branches that fetch from trunk as well as milestone branches.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6597004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76364 0039d316-1c4b-4281-b951-d872f2087c98
This changes adds the first pass of code needed for OWNERS files.
In total there should probably be maybe four user-visible changes:
* new gcl/git-cl "suggest-reviewers" command
* a presubmit hook on upload to automatically add the reviewers
* an addition to gcl/git-cl status command that tells you
which files still need review/approval.
* a presubmit hook on commit to ensure all of the needed reviewers
have approved the file.
This change implements a core "owners Database" object with the
dumbest possible algorithm for determining a covering set of reviewers,
and the skeleton of the presubmit hooks. This code will not be
used by anything yet, and is also missing unit tests.
Review URL: http://codereview.chromium.org/6581030
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76342 0039d316-1c4b-4281-b951-d872f2087c98
First step to remove cygwin dependencies. This will remove dependencies with zcsh and allow python scripts to be executed as hooks.
BUG=70550, 70549
TEST=checkout chrome with git, use git cl to upload a cl, revise a cl, commit a cl.
Review URL: http://codereview.chromium.org/6369012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76232 0039d316-1c4b-4281-b951-d872f2087c98
It is useful sometimes to cc someone without marking this person as a reviewer.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6575036
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76093 0039d316-1c4b-4281-b951-d872f2087c98
from the same repository.
TEST=added regression test.
BUG=none
Review URL: http://codereview.chromium.org/6578029
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@75937 0039d316-1c4b-4281-b951-d872f2087c98
To reproduce, svn delete a file, then svn merge -c -N the file to revive it.
Also fix a unit test that was broken for a while.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6576005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@75835 0039d316-1c4b-4281-b951-d872f2087c98
BUG=none
TEST=second git-cl upload of a CL doesn't set CC again
Review URL: http://codereview.chromium.org/6546042
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@75531 0039d316-1c4b-4281-b951-d872f2087c98
When I renamed setup_mock to local_rietveld, I had forgot one place in
PRESUBMIT.py.
TBR=evan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6501001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74627 0039d316-1c4b-4281-b951-d872f2087c98
This makes the code more comprehensible and reusable.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6460015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74623 0039d316-1c4b-4281-b951-d872f2087c98
The recent changes to the chromite wrapper hid all import errors
in chromite, simply giving an error that chromite couldn't be found.
This fixes the problem.
For associated review in chromiumos git:
http://codereview.chromium.org/6461009
Review URL: http://codereview.chromium.org/6487003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74452 0039d316-1c4b-4281-b951-d872f2087c98
So pass a single item array. The presubmit checks would fail otherwise.
This code path was definitely not exercised by the unit tests. Unit tests are
left as an exercise to the reader.
TBR=vbendeb
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6479006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74396 0039d316-1c4b-4281-b951-d872f2087c98
Unittest is being also updated.
TEST=manual
. run ./presubmit_unittest.py, observe success
.create a CL with code style violations (long lines, traling spaces) and observe the violations reported by 'git cl presubmit'
Patch contributed by Vadim
Review URL: http://codereview.chromium.org/6461011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74378 0039d316-1c4b-4281-b951-d872f2087c98
It would fail otherwise when called directly from a git checkout subdirectory.
Updated unit test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6459010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74281 0039d316-1c4b-4281-b951-d872f2087c98
Disable warning W0404 in pylint.
BUG=none
TEST=should now work on googlers workstations
Review URL: http://codereview.chromium.org/6456010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74242 0039d316-1c4b-4281-b951-d872f2087c98
There is 2 changes while moving the code:
- Making externals handling an option.
- Not trapping EnvironmentError.
This code will be reused by the commit queue.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/6250177
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74181 0039d316-1c4b-4281-b951-d872f2087c98
Make json files known as a text mimetype so that they can be seen in reviews.
Original review at http://codereview.appspot.com/4133046/
Also make sure that the copy in third_party and in git_cl are the same. I'll
remove the copy in git_cl in a later change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74116 0039d316-1c4b-4281-b951-d872f2087c98
For example, TODO(foo) is ok, but TODO: do something is not.
BUG=none
TEST=included
Review URL: http://codereview.chromium.org/6413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74032 0039d316-1c4b-4281-b951-d872f2087c98
This enables seamless unit tests that check-in files without side-effects on the
remaining unit tests.
BUG=none
TEST=none
TBR=dpranke
Review URL: http://codereview.chromium.org/6250073
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73456 0039d316-1c4b-4281-b951-d872f2087c98
Improves output of git cl tree to use Chromium OS status, not Chromium Status.
BUG=chromium-os:11449
TEST=Output of 'git cl tree' for Chromium OS includes output from Chromium OS instead of from Chromium.
Review URL: http://codereview.chromium.org/6312047
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73292 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise if there is a file named breakpad.py for instance in the current
directory, it will be loaded instead of the one in depot_tools.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6312034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73165 0039d316-1c4b-4281-b951-d872f2087c98
This file is a copy of the chromite wrapper that lives here:
http://git.chromium.org/gitweb/?p=chromite.git;a=blob;f=bin/chromite
Anush requested that this wrapper be placed into depot_tools so
that users will get the wrapper in their path. The wrapper will go
and find the real version of chromite based on the CWD.
Patch contributed by dianders@chromium.org.
Review URL: http://codereview.chromium.org/6299018
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73011 0039d316-1c4b-4281-b951-d872f2087c98
Also remove the harcoding of the names by putting them in a variable.
This will help testing of the commit queue.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6350013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@72454 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
dpranke@chromium.org
thomasvl@chromium.org
bauerb@chromium.org
mhm@chromium.org
bradnelson@google.com
chase@chromium.org
mirandac@chromium.org
dianders@chromium.org
estade@chromium.org
msb@chromium.org
jam@chromium.org