This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
43f6400705
43f6400 (gbeaty@chromium.org)
Update the recipe guides to remove non-inclusive terms.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I740724b3a4a4516f39d98169b2a43fac75efabd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2867123
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
61c083c605
61c083c (mmoss@google.com)
Allow setting the type of file when extracting archives.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I66143910ed1cd63ff590059498c6db53f3d67d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2867122
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Gonna add a small warning in chromium's recipe when this footer is
used. Add it here so we can refer to the footer as a constant in
tryserver recipe_mod.
Bug: None
Change-Id: Ie4f9d1d208c0dad8d0df8f07b74e761da1051a1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2864005
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
bbe9a55707
bbe9a55 (mohrr@google.com)
[path] Add isdir() and isfile()
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib801c9f06a973ba531c4efd66785009f9a4a3d7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2864505
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
If the DEPOT_TOOLS_REPORT_BUILD envvar is set, Depot Tools will
report information about the builder running the command
(e.g. buildbucket project, bucket, builder and build id).
It will also authenticate to the metrics server, and ignore any
requests not made by ChOps service accounts.
Change-Id: I078a4c2170b4226086c42f289fa449bdebc87179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861213
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
This is to deploy the changes of crbug.com/1149662, which enables
BatchCreateArtifacts in ResultSink.
Bug: 1149662
Change-Id: Ib3669ad9c2f02deb62455a9e3ef05ef858ef1290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2862880
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
This change includes the following commits from the infra/infra
repository:
$ git log --format='%h %s (%ae)' \
97ee9cecaac4d99be09278169f987e61b8116672..HEAD \
-- go/src/infra/chromeperf/pinpoint/cli
dabbed3140 pinpoint: Add support for experiment presets (dberris@google.com)
2c16cdc58a pinpoint: Initial support for user configurations (dberris@google.com)
R=dpranke@google.com
Change-Id: I0bb7a5a167e57b64d8328f497386d5b68f3e4a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2862344
Auto-Submit: Dean Berris <dberris@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
782fd4903e
782fd49 (yiwzhang@google.com)
cq: accept modes instead of mode_regexp for cq.allow_reuse_for api
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d24cd20449dd7c1f8915e8fc3a039a2be6aad90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2860878
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
With this, it's possible to run some things without
export VPYTHON_BYPASS="manually managed python not supported by chrome operations"
on an arm mac, such as `git cl upload` -- this CL was uploaded
from my M1 MBP :)
(Presubmits need py2 which we don't have yet, but with
`--bypass-hooks` it works.)
Bug: 1103326,1184767,1103236
Change-Id: I46f5b880dfd72b8d811d39b43311fdee17ccad3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2858534
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
The change I landed in 61bf638 couldn't include the proper tests
because of crbug.com/1201918 (I think), and so I split the
test file out into this separate follow-up CL.
Bug: 1157663
Change-Id: I06697a5b76f81f0dc96ad457406a8d4d942d882c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2846635
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
a80d44a95d
a80d44a (iannucci@chromium.org)
[deps] Move dependant recipe discovery to be an option.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id5bb0bb56f8c956213ee4a3917197a0b9e6d36c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2856095
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This change is needed to enable CQ for the tricium plugin.
Bug: 1201483
Change-Id: I685d04055a5cabd94c7f02a79a0b9cbc4694db0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2847232
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
75cf2faf5d
75cf2fa (iannucci@chromium.org)
[deps] Add deps subcommand.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icef236b13c71d13b94d33bc0754ecfc4059a1b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2854976
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This reverts commit 90aee2acaf.
Reason for revert: the new rdb caused blink web tests to fail
Original change's description:
> [resultdb] move cipd pin of rdb to enable BatchArtifactsUpload
>
> This is to deploy the changes of crbug.com/1149662, which enables
> batch-uploading for artifacts in ResultSink.
>
> Bug: 1149662
> Change-Id: Id4845fd421065cfc45442e16f5d41d0001818968
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2850389
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Chan Li <chanli@chromium.org>
> Commit-Queue: Scott Lee <ddoman@chromium.org>
Bug: 1149662
Change-Id: I7b3e5b5fae3e6262134582c0f002ff46065a9eb4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2852455
Auto-Submit: Scott Lee <ddoman@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
This is to deploy the changes of crbug.com/1149662, which enables
batch-uploading for artifacts in ResultSink.
Bug: 1149662
Change-Id: Id4845fd421065cfc45442e16f5d41d0001818968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2850389
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
This CL adds support for running PRESUBMIT.py under either Python2
or Python3 as specified in each PRESUBMIT.py file.
To run the checks under Python3, the PRESUBMIT.py file must contain
a line exactly matching "^USE_PYTHON3 = True$". If the file
does not contain this string, the checks will run under Python2.
Different PRESUBMIT.py files in a single CL may thus contain
a mix of 2- and 3-compatible checks, but each individual file will
only be run in one or the other (it doesn't likely make sense to run
them in both by default).
Bug: 1157663
Change-Id: Ic74977941a6519388089328b6e1dfba2e885924b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2832654
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
This is a prerequisite to enabling the native Mac ARM64 cpython3,
since we don't have that package built at the old 3.8.0 version.
Bug: 1184767
Change-Id: I68a7de836f9fae25ecbb2fc84aff389a24c32e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842053
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
d8993f4684
d8993f4 (weiweilin@google.com)
[recipe] Update test presentation config to match lucicfg imple...
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4975618c9153b37a8139a6ab49822bd2b1988afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842550
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is a reland of 4c67f856f0
Issues should have been fixed by crrev.com/c/2838026
Original change's description:
> git-cache: Add option to fetch commits.
>
> Add option to git cache to fetch commits.
> And use it in bot_update and gclient sync to make sure
> the needed commits are present on the checkout.
>
> Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Change-Id: Ie5a29737f5a75d28bc7c5c2f6cb99ec7f87cd9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2841046
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
This is to have the latest version of underlying library.
Bug: 1200494
Change-Id: I43f1628280e75b94b21c2c6a399f55a12970252c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2838848
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
This reverts commit 4c67f856f0.
Reason for revert: crbug.com/1200657
Original change's description:
> git-cache: Add option to fetch commits.
>
> Add option to git cache to fetch commits.
> And use it in bot_update and gclient sync to make sure
> the needed commits are present on the checkout.
>
> Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Change-Id: I31a1defb26119bcb46894ab4084d626b65c45fed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837413
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Add option to git cache to fetch commits.
And use it in bot_update and gclient sync to make sure
the needed commits are present on the checkout.
Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
This is a reland of 75271a0744
Should be safe to re-land now, as the roller will catch the
build error. Then we can re-land in conjunction with the
change to rename the angle gclient config.
Original change's description:
> Reland "Remove ANGLE recipe config."
>
> This is a reland of b8686d2622
> Must land after https://crrev.com/c/2831999
>
> Original change's description:
> > Remove ANGLE recipe config.
> >
> > This config is now located in the ANGLE recipe_module.
> >
> > Bug: angleproject:5114
> > Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
> > Auto-Submit: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
>
> Bug: angleproject:5114
> Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Bug: angleproject:5114
Change-Id: I85c3d6218b790ef62b19c62eb42ec9a8622d613f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2836327
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
This is a reland of b8686d2622
Must land after https://crrev.com/c/2831999
Original change's description:
> Remove ANGLE recipe config.
>
> This config is now located in the ANGLE recipe_module.
>
> Bug: angleproject:5114
> Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
> Auto-Submit: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Bug: angleproject:5114
Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
We're looking at dropping Python 3.5 support from repo. Lets roll
this back out in Chromium a little early to get a better idea of
who is still relying on it.
Change-Id: Idcdd5b0a957f5a2f8b146149c407c26347be0aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2830590
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
I recently encountered an error where I forgot to add a changeid locally to
some-but-not-all commits in a stack of commits. When attempting to upload
these commits via `git cl upload --no-squash`, I received a confusing message
instructing me to install the Gerrit commit-msg hook even after the hook was
installed. In order to debug this problem locally, I added the ability to
prevent `git cl upload ...` from attempting to change the contents of
messages. If the --no-add-changeid flag is passed, then the command will
simply fail quasi-informatively.
BUG=None
TEST=attempted to upload this CL via `git cl upload --no-squash --no-add-changeid`, confirm that it fails.
Change-Id: Id5f721c18143448db801095946f490880bb61786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2828775
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Gregory Nisbet <gregorynisbet@google.com>