Commit Graph

53 Commits (6db8ac71b3e7f3f90b59027e66c37644c4e01b6a)

Author SHA1 Message Date
Andrii Shyshkalov 71b8e66f89 Register v8/v8 in gclient for trying Gerrit v8 patches on chromium trybots.
R=machenbach@chromium.org
BUG=685318

Change-Id: I61192392eec98ad6b9a32ef933f2d22cf2aedd0e
Reviewed-on: https://chromium-review.googlesource.com/435318
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
8 years ago
John Budorick 4f140d7e01 recipes: add ndk_next gclient config.
This adds an ndk_next gclient configuration to allow bots to use the
upcoming version of the Android NDK.

BUG=668202

Change-Id: I403e398094f4215cdb3783b68f465323264ca1ee
Reviewed-on: https://chromium-review.googlesource.com/414184
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Mike Stipicevic <stip@chromium.org>
9 years ago
Henrik Kjellander b6849ac483 WebRTC: Make got_revision be a WebRTC revision for bots in chromium.webrtc.fyi
This is needed in order to be able to use the set_component_rev feature in
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?rcl=0&l=169
which is needed for having the testers to sync the same WebRTC revision
as the builders.

This is a follow-up for https://chromium-review.googlesource.com/c/414110

BUG=chromium:669818
TBR=tandrii@chromium.org

Change-Id: I6ca77e739513009e503a3b2a6fedacde8730e9a4
Reviewed-on: https://chromium-review.googlesource.com/415788
Reviewed-by: Henrik Kjellander <kjellander-cc@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander-cc@chromium.org>
9 years ago
Henrik Kjellander 5f5b83bbc2 Make Tester bots in chromium.webrtc.fyi sync the right revisions.
BUG=chromium:669818
TBR=tandrii@chromium.org

Change-Id: Icbefd12bd891c8fdb7b8278083f8b1accb53500c
Reviewed-on: https://chromium-review.googlesource.com/414110
Commit-Queue: Henrik Kjellander <kjellander-cc@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
9 years ago
Nodir Turakulov 7da798be10 infra_paths: do nothing if path_config is not specified
Currently if path_config is not specified, infra_paths
defaults to buildbot paths. We want to make this behavior explicit,
so we don't have to introduce a new "luci" path configuration which
tells infra_paths module to do nothing.

Buildbot now specifies path_config=buildbot since
https://chromium-review.googlesource.com/c/412029/ ,
so now we can remove this default.

This also affects all expectation files because this CL switches 
the default path configuration from Buildbot to LUCI.
In particular, it changes default git cache dir from [GIT_CACHE]
to [CACHE]/git.
Also code paths that work only in Buildbot environment has to 
have a test with path_config=buildbot.

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: Ifeabe13e69810dd24a6deb4830699f8c9fafafae
Reviewed-on: https://chromium-review.googlesource.com/411989
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
9 years ago
Nodir Turakulov e672f93953 deprecate git_cache path
We cannot easily move git cache location on all buildbot bots, but we
need to define a new value for LUCI.
Introduce infra_paths.default_git_cache_dir which must be used instead
of using path['git_cache'] directly.

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: I5244d7a761da94858df798abbd423c85f55936af
Reviewed-on: https://chromium-review.googlesource.com/411993
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
9 years ago
Nodir Turakulov 415cf53d61 gclient module: remove revert function
Nothing uses it

R=iannucci@chromium.org
BUG=

Change-Id: I33932335e019d61f8e174e12c2b647ebfe3d6903
Reviewed-on: https://chromium-review.googlesource.com/412265
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
9 years ago
Nodir Turakulov cb1beaa79f deprecate depot_tools path
Use depot_tools module's methods or package_repo_resource function to
determine paths of tools that live in depot_tools

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: Ic3172308c140f7f19e982ec6ec5a4b1b83261e1b
Reviewed-on: https://chromium-review.googlesource.com/411936
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
9 years ago
Nodir Turakulov fbf01c5431 remove slave_build path
slave_build path, defined by infra_paths module, is unnecessarily tied
to our buildbot setup which we are trying to deprecate in favor of LUCI.
In practice it is always == start_dir and that's what we want in LUCI too.

Update all code that uses slave_build path to use start_dir instead.

R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586

Change-Id: Id52aa535d6a4f52670d581bf56aab65f670b1861
Reviewed-on: https://chromium-review.googlesource.com/412075
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
9 years ago
agable a98a6cd47d Remove safesync support from gclient[_scm].py
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2395013002
9 years ago
kjellander 9abf453c3a WebRTC: Remove references to src/third_party/libjingle/source/talk
A while back, we removed the last pieces of code in
src/third_party/libjingle/source/talk and it is no longer synced
in Chromium's DEPS file. Clean this up to avoid confusion in the
buildbot recipes.

BUG=webrtc:4256

Review-Url: https://codereview.chromium.org/2325043002
9 years ago
agable fbfa601efd Remove svn from gclient recipe module example
R=martiniss@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2318843002
9 years ago
agable c8f3a3498e Remove non-trivial SVN config from gclient recipe module
R=martiniss@google.com
BUG=640251
Recipe-Tryjob-Bypass-Reason: can't mock expectation changes downstream

Review-Url: https://codereview.chromium.org/2285213004
9 years ago
agable 9741c590a4 Remove defunct SVN-based gclient configs
The URL helper functions were only used by this file,
the svn custom_deps urls aren't referenced in any DEPS
files I can find anymore, and the oilpan and buildspec
configs aren't used by any recipes.

R=hinoka@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2291583003
9 years ago
agable 7090f652d1 Remove all references to GIT_MODE from depot_tools
BUG=640251,472386

Review-Url: https://codereview.chromium.org/2286793003
9 years ago
agable 4b21db06e4 Default gclient's GIT_MODE to True
Also contains some other changes (to the example, and to safesync url)
in order for test coverage to remain complete. Will be followed shortly
by a wholesale removal of svn support from the gclient module.

R=iannucci@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2270083004
9 years ago
agable 75e7fc2af1 Just use git refs for lkcr and lkgr
R=iannucci@chromium.org, martiniss@chromium.org
BUG=640251
Recipe-Tryjob-Bypass-Reason: None of the affected recipes need safesync anyway, will manually roll

Review-Url: https://codereview.chromium.org/2268893004
9 years ago
machenbach 1278dbd127 Enable testing ICU CLs on chromium trybots
BUG=631575

Review-Url: https://codereview.chromium.org/2183393002
9 years ago
mikecase 1f2c9b78ae Add config to gclient to pull in Chromedriver test deps.
BUG=

Review-Url: https://codereview.chromium.org/2166443002
9 years ago
smut ae7ea3167e Revert "Remove all safesync_url functionality from gclient"
This reverts commit 99a7f80578.
This reverts commit 2697cd19a7.
This reverts commit 8c51b6f148.
This reverts commit d4aedc811b.

Reason for revert:
Breaks iOS release branch builds.

BUG=623762
TBR=agable,maruel

Review URL: https://codereview.chromium.org/2162583004 .
9 years ago
phajdan.jr 7dba71bfbc remove blink_or_chromium gclient config
It's not needed after blink merge.

TBR=emso, sergiyb, tandrii

BUG=none

Review-Url: https://codereview.chromium.org/2117063002
9 years ago
agable 99a7f80578 Remove all safesync_url functionality from gclient
R=maruel@chromium.org
BUG=109184

Review-Url: https://codereview.chromium.org/2087313002
9 years ago
phajdan.jr cd0b7abe26 gclient: fix patch_project handling for the recipe engine
This is needed after d88f0c8311

BUG=none

Review-Url: https://codereview.chromium.org/2091313003
9 years ago
dpranke@chromium.org c2a88544c3 Add 'catapult' to gclient config to enable trybots.
With this change, we can run chromium tryjobs for changes to catapult.

R=tandrii@chromium.org, nednguyen@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2030623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300688 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org 08b0e06ebc depot_tools: add gclient config for bare recipes-py repo
BUG=chromium:459840

Review-Url: https://codereview.chromium.org/2017843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300665 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
kjellander@chromium.org 2d845d4531 Set patch project path correct for WebRTC.
'git apply' works on Git indexes, so it's not possible
to apply a patch to src/third_party/webrtc with cwd=src/third_party.
Instead, set the cwd to the correct dir and add an extra patch
level using the new flag in https://codereview.chromium.org/1988583002/

This essentially reverts https://codereview.chromium.org/1977373002/
+ sets the project path correctly to src/third_party/webrtc.

BUG=438952

Review-Url: https://codereview.chromium.org/1984993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300616 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
kjellander@chromium.org d49733507b Fix revision for WebRTC patches sent to Chromium trybots
This will have the revision set properly to 'HEAD' before attempting
to apply the patch.
It should also solve the problem that analyze is ending up with
no changes when running 'git diff'.

Expectation update in: https://codereview.chromium.org/1984673002

BUG=438952

Review-Url: https://codereview.chromium.org/1977373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300603 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
dtu@chromium.org 84ab575601 Add/rename chromium_perf gclient configs.
After the deletion of page_cycler.morejs benchmark, these are the only two
gclient configs we need across chromium.perf, chromium.perf.fyi, and
tryserver.chromium.perf. Rename from "perf" to "chromium_perf" to match chromium
config. This CL will be followed up with one to delete "perf".


BUG=611484

Review-Url: https://codereview.chromium.org/1976843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300600 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
kjellander@chromium.org cece75cf46 Add support for WebRTC patches to Chromium trybots
Test case being added in https://codereview.chromium.org/1984623002/

NOTICE:
* Only patches from the webrtc/ subdirectory in a standalone
WebRTC checkout will work, since the root is set to src/third_party.
This can be changed once http://crbug.com/611808 is fixed. 
* The Chromium checkout will be synced to the DEPS-pinned revision
of WebRTC. Changing this to HEAD will be addressed in a future CL.
BUG=438952

Review-Url: https://codereview.chromium.org/1976243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300588 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
hans@chromium.org 23ce0dba10 Enable running tryjobs with third_party/flac changes
BUG=none

Review-Url: https://codereview.chromium.org/1964593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300518 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan@google.com 7f48c068c1 gclient: explicitly set checkout cwd for runhooks
BUG=chromium:596887
R=dsansome@chromium.org

Review URL: https://codereview.chromium.org/1956383002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300503 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org b1a1714800 Add buildtools patches to be runnable on chromium trybot.
TBR=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/1936143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300402 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org b6552b6e45 Improve doc for gclient.pach_projects mapping.
R=phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/1933233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300347 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org 6cfbbcf467 depot_tools: add dependencies on infra_paths
This is a preparation for removal of infra-specific
paths from the recipe engine.

BUG=chromium:605919

Review-Url: https://codereview.chromium.org/1930373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300335 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
rmistry@google.com da3bfae5bb Add Skia to list of can-be-patched projects in chromium checkout.
BUG=

Review-Url: https://codereview.chromium.org/1929993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300287 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
recipe-roller@chromium.org b770809308 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d9039313202dfb6adaf890674abdd8ee6aec940d recipe engine: remove explicit cwd default in step recipe module (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1926633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300229 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
martiniss@chromium.org 25837199f3 Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
Hopefully everything will be back to normal now...

Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
>
> Depends on https://codereview.chromium.org/1906323003
>
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184

TBR=iannucci@chromium.org,hinoka@chromium.org,phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1915033006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300210 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
martiniss@chromium.org 3407a99675 Roll recipe_engine to 2f86f02a302172514bf282684e0a4aa18b683e41
TBR=phajdan.jr

BUG=606708

Review URL: https://codereview.chromium.org/1921893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300206 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org d34c90601f Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
Reason for revert:
re-landing because wrong order of reverts :(

Original issue's description:
> Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
> 
> Reason for revert:
> breaks skia bots :(
> 
> Original issue's description:
> > depot_tools: add infra_paths recipe module for infra-specific paths
> > 
> > Depends on https://codereview.chromium.org/1906323003
> > 
> > BUG=chromium:605919
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
> 
> TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:605919
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300199

TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1921373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300200 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org 54e0d26399 Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
Reason for revert:
breaks skia bots :(

Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
> 
> Depends on https://codereview.chromium.org/1906323003
> 
> BUG=chromium:605919
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184

TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1917263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300199 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org aa71406c1c Add Pdfium to list of can-be-patched projects in chromium checkout.
R=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1914123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300185 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org f30e872853 depot_tools: add infra_paths recipe module for infra-specific paths
Depends on https://codereview.chromium.org/1906323003

BUG=chromium:605919

Review URL: https://codereview.chromium.org/1915463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300184 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org cb3fd431fd Generalize patch_project to patch root conversion.
IMPORTANT: See bug http://crbug.com/605563#c3 for deployment and emergency roll-back plan.

This patch is first of a series. It provides a cleaner and generic way to apply patches to non-root of first solution.

R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563

Review URL: https://codereview.chromium.org/1917433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300141 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
martiniss@chromium.org 375aa58877 Make the config -> pythonish conversion a gclient module function.
Also makes bot_update use this.

This allows for clank to manually set the gclient config.

BUG=590788

Review URL: https://codereview.chromium.org/1815863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299398 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org 88e173be1a depot_tools: adjust for resource API changes in recipe engine
This is rolling in https://codereview.chromium.org/1777003003

BUG=593420

Review URL: https://codereview.chromium.org/1785443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299187 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
martiniss@chromium.org 3ce9b4446d Make CACHE_DIR set by default in most gclient configs.
This is needed because bot_update changed from getting the cache directory from
the global path module to the gclient config.

BUG=589140

Review URL: https://codereview.chromium.org/1768893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299143 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
szager@chromium.org 88be9a1c5a Use gclient's git_cache setting in bot_update/api.py
BUG=589140
R=agable@chromium.org

Review URL: https://codereview.chromium.org/1762513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299120 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
ukai@chromium.org cd9a3389e1 depot_tools: add master_deps in gclient/config.py
BUG=574615

Review URL: https://codereview.chromium.org/1705473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298843 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org edf62ce445 gclient: add depot_tools to PATH
BUG=437264

Review URL: https://codereview.chromium.org/1676473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298614 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org 9e45c71356 depot_tools: use package_resource to locate gclient.py
BUG=437264

Review URL: https://codereview.chromium.org/1673603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298612 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago