aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
5,689 Commits
6 Branches
0 Tags
186 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '67d70d26b0'
${ noResults }
Commit Graph

5689 Commits (67d70d26b08e3775c0a00b83d71c27271b0e4bb0)
 

Author SHA1 Message Date
David 'Digit' Turner 31a486419e Improve no-long-lines check for Python files. 
The previous implementation of CheckLongLines did not
handle global pylint disable/enable directives properly,
i.e. the difference between:

   # pylint: disable=line-too-long
   .... checks disabled for all lines here.
   # pylint: enable=line-too-long

versus:

   # Check only disabled for the line below
   some python statements   # pylint: disable=line-too-long

This CL changes the implementation to support Python files
properly. Note that in order to not disturb the mock-based
unit-tests, a new function is introduced to be able to
filter the list of affected files based on their file
extension.

BUG=890734
R=mattcary@chromium.org,ehmaldonado@chromium.org,dpranke@chromium.org

Change-Id: Id52deff53913b8d47a4157f42b1fffbd3b103201
Reviewed-on: https://chromium-review.googlesource.com/c/1396094
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
 6 years ago
Takuto Ikuta 36248fcd63 [ninjalog] don't upload ninja log of no-op build 
Check timestamp of .ninja_log before upload and don't upload if mtime is very old.

Bug: 900161
Change-Id: I0cf00ae29e23a9f609564e4c12b4b518320ca23a
Reviewed-on: https://chromium-review.googlesource.com/c/1404611
Commit-Queue: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 6 years ago
recipe-roller 4e23d9bac7 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/27cd207dfb18d832d94218e61720acbb0127a26b Whitespace change to watch Build Recipes Tester. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3cccdf1a524e2f0e0830d882db831f3bf9e01655
Reviewed-on: https://chromium-review.googlesource.com/c/1405558
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 80a1cf66b8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6fc662aae01eb4f6cfb1efe49dbdbaa0a7a4d912 [isolated] Fix bug (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I38c258a02c04acb20b2794b7e63c183f8390872e
Reviewed-on: https://chromium-review.googlesource.com/c/1405548
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller b1be3782a4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/844a3eb30c85cc64f5b620dd96a787df9e40769a Remove engine_flags from everywhere. (iannucci@chromium.org)
  https://crrev.com/d0f4f80818647cc84a836e2caa3dfbac4e28ea64 Revert "Remove engine_flags from everywhere." (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e927cdee578aff16e530d2eba6b666598a84f51
Reviewed-on: https://chromium-review.googlesource.com/c/1404280
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
Andrii Shyshkalov 8ec820957b Revert "Roll recipe dependencies (trivial)." 
This reverts commit 09aecb2159.

Reason for revert: lead to breakage of everything.
https://crbug.com/920497

Original change's description:
> Roll recipe dependencies (trivial).
> 
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
> 
> 
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
> recipe_engine:
>   https://crrev.com/844a3eb30c85cc64f5b620dd96a787df9e40769a Remove engine_flags from everywhere. (iannucci@chromium.org)
> 
> 
> TBR=iannucci@chromium.org
> 
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: I6d207b66261d150b4c9f327beccd10b14c41448e
> Reviewed-on: https://chromium-review.googlesource.com/c/1404278
> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

TBR=iannucci@chromium.org,recipe-roller@chromium.org

Change-Id: I8104a656d0da076a8d0c4f8473a0724982b1f65d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1404564
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
recipe-roller 09aecb2159 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/844a3eb30c85cc64f5b620dd96a787df9e40769a Remove engine_flags from everywhere. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6d207b66261d150b4c9f327beccd10b14c41448e
Reviewed-on: https://chromium-review.googlesource.com/c/1404278
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
Takuto Ikuta 8794a84552 [ninjalog] re-enable log upload 
I got launch approval. http://shortn/_dyJK6ME7C0

Detailed document of this log upload is in
https://chromium.googlesource.com/chromium/tools/depot_tools/+/HEAD/ninjalog.README.md

Bug: 900161
Change-Id: Iad2f954040d40caa5b7cc1f1eb39c1088f7f316e
Reviewed-on: https://chromium-review.googlesource.com/c/1401919
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 6 years ago
Jared Saul 2d4a955e90 Fix broken metrics collection dialog spacing 
The change around line 29-30 in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1368409/2/metrics_utils.py
inadvertently removed an extra space.  As a result, the metrics
collection dialog looks like this:
https://screenshot.googleplex.com/3aGtquydCXM.png

Change-Id: I7c9c08949b0df248e6de4f59ec9cfd573ff40901
Reviewed-on: https://chromium-review.googlesource.com/c/1403577
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
 6 years ago
Avi Drissman 4157ba1c3c Update cpplint. 
da90c53e3d was incorrect; the size()
functions take almost anything, not just word characters, and
std::extent() uses brackets.

BUG=837308

Change-Id: I6ee75a5da7a021758bbfb0996aeaef81f2003cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1401581
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
 6 years ago
recipe-roller 9d5b468279 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3535e529c7b925fb486cfaccc1f89e739402d54b [buildbucket] Populate ref from branch property (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I02ff1f10339bf828d57fe372e19fa794f766102d
Reviewed-on: https://chromium-review.googlesource.com/c/1402104
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
Takuto Ikuta c8069af594 [ninjalog] fully anonymize build stats before sending 
We cannot send PII data.

This CL tried to remove following data,
* build config that can contain build directory path
* build directory path
* hostname
* cwd

I use per build uuid instead of per user uuid.


Bug: 900161
Change-Id: Id533762749806ad8616b7dc07f21b27dfe632c9a
Reviewed-on: https://chromium-review.googlesource.com/c/1369473
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 6 years ago
recipe-roller b61b09f11d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7d75cc6e379d1603027cb39420541ceaa8fd6a2c [swarming] enforce to set server if server is referred (tikuta@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I72e8a523c2dd431b75c52a49b7bdb556683f7097
Reviewed-on: https://chromium-review.googlesource.com/c/1402101
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller b3f56664c4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7e610e4cc8e12bf654b0ecfc1872cc50e1ceed8d Restore old user guide for now. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic8df1bbf114667e9f1012611f4569b4f7ab93681
Reviewed-on: https://chromium-review.googlesource.com/c/1401599
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 75612b0790 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/08b7a23ec10abc078fd0f7594dd1331c76ae30e4 Revert "Remove use_result_proto flag" (martiniss@chromium.org)


TBR=iannucci@chromium.org
NOPRESUBMIT=true
NOTRY=true

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe04b68b36fd509c22656e3a6cbd6403edf14818
Reviewed-on: https://chromium-review.googlesource.com/c/1401589
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 327dcb4c39 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5e16623c2af04706ed78dec9aa25fcf367a2f0bc Remove use_result_proto flag (martiniss@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6655221dfa31991e53bcb2142abd1a92bcbee308
Reviewed-on: https://chromium-review.googlesource.com/c/1401585
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 118bb44e14 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d44c26c543da894ac048a1a5f129790c2bb9923f [isolated] enforce to set server if server is referred (tikuta@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4dcc257d7303380f148abaae14febc33da632b61
Reviewed-on: https://chromium-review.googlesource.com/c/1401583
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
Avi Drissman da90c53e3d Update cpplint. 
Using base/std::size and std::extent does not result in the creation
of a VLA; cpplint should not warn on their use.

BUG=837308

Change-Id: Ie133b2144b6c1c9f4f5e406144f28b333a212197
Reviewed-on: https://chromium-review.googlesource.com/c/1399961
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
 6 years ago
recipe-roller d16b51b9bf Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1f61472de5efab2217261a2912af7682f0e5c62e [isolated] Allow ability to isolate a given root directory. (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie2bef3cefb24a9df75ba14608337897addd3d71d
Reviewed-on: https://chromium-review.googlesource.com/c/1398623
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller c0641b8e93 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c1b615b6808b8aa8001b5e4e1d5d234233ad8266 [buildbucket] Add set_output_gitiles_commit (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia34028e3fe28469bf8202948ccaafdf38e15b9eb
Reviewed-on: https://chromium-review.googlesource.com/c/1396583
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
Nodir Turakulov 390028fd6b Do not validate deleted configs 
This bug caused https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8925230260185002096/+/steps/presubmit/0/stdout

Tested locally

R=vadimsh@chromium.org

Change-Id: I9c42b7d7e9a1366e00fe40ca8a9f18ff0629663a
Reviewed-on: https://chromium-review.googlesource.com/c/1396527
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 6 years ago
recipe-roller f3d4ab3430 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/be3df181ebe1e4a67251ef904e4396553b959506 [buildbucket] Parse created_ts from string (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idfeb2ea0aca20da3dfba0398057404c6c20adf26
Reviewed-on: https://chromium-review.googlesource.com/c/1396099
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 936a994608 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/77f5f049d615d9086198660ebe9539ce7abbf7ff [buildbucket] Parse created_ts (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1f7a27a53b534b50f7c21b2c99b50530de07f3c6
Reviewed-on: https://chromium-review.googlesource.com/c/1394816
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 4ad409510d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1e2a5440207a57b828e58d3998501b2a45679ada [isolated] Roll the isolated CLI tool version (nmulcahey@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3f89db3268f1ae2790628695d2a91b8f0925cba2
Reviewed-on: https://chromium-review.googlesource.com/c/1394805
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
Edward Lemur db0055dc78 presubmit: Fix CheckOwnersFormat 
Fix CheckOwnersFormat so that it checks the new OWNERS files instead of the
original ones.

Change-Id: I4abb1cfc847bd28f45b9948fe7775c10dcc8a420
Reviewed-on: https://chromium-review.googlesource.com/c/1382946
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Mike Frysinger 58649e3417 repo: update launcher to v1.13.1 
This rolls a few changes from upstream noticed by early testing.

Bug: 900461
Change-Id: Iea568be41e3149a667fba655576bdd591b353079
Reviewed-on: https://chromium-review.googlesource.com/c/1387706
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 6 years ago
recipe-roller f5b3ad2f70 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/354bb02e9c0b74eea43faa883ac1aa134c435e3c [swarming] Add support for environment variables. (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iacd8293734181d6d5cdfb8af38c1824ab9cfe586
Reviewed-on: https://chromium-review.googlesource.com/c/1387704
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 8cb79b0f82 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/19c28875c9f1519cac7156e07dbb8e59ff40f7c1 [isolated] Add download method (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I62be38022b84c35c5c17d4b18fd411af2ce176ad
Reviewed-on: https://chromium-review.googlesource.com/c/1387567
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 7a56dcd718 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1236ebd26cbcfae759c3857b26bd9bd1cf3547d2 [file] Introduce SymlinkTree (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5ff1123b7289e134a765e20a6c4e9dc2f8e6c142
Reviewed-on: https://chromium-review.googlesource.com/c/1387566
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 7b72af28fb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0fad0863959ecf172fb460a7008eeabf8c8f078d [swarming] Minor clean-up and typo fixes. (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id98f511e9d4344f8625ff5d3732d792e669e4850
Reviewed-on: https://chromium-review.googlesource.com/c/1387565
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
Clemens Hammacher 2cc6e25536 [cpplint] Fix regexp for class decorators 
This also allows digits in class decorators, to also match macros like
V8_EXPORT_PRIVATE.

Note: I uploaded a pull request for the (previous) upstream at
https://github.com/google/styleguide/pull/422, but then was told that
that repository is not maintained any more.

R=jochen@chromium.org

Bug: chromium:916550

Change-Id: I24cd1829b794b296be8e0c2829271c746751ee1c
Reviewed-on: https://chromium-review.googlesource.com/c/1383472
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
 6 years ago
recipe-roller a3eb0bb167 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c3fbb33835795d43242ef673522148ade63a3cf0 [swarming,isolated] Add `on_path` methods. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I150752f2f6e26edb7c86969e93ae95a925fe2c8b
Reviewed-on: https://chromium-review.googlesource.com/c/1385506
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
Takuto Ikuta 540ba9dde0 [ninjalog] add ninjalog.README.md 
I added document explaining ninjalog collection.
This document explains what type of data is collected and how the data will be used.

Bug: 900161, b/120645342
Change-Id: If47517aaa7a5510e4a634b5ccc0e4127d014dcb9
Reviewed-on: https://chromium-review.googlesource.com/c/1381912
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
 6 years ago
Bruce Dawson eba46fc12e Improve error message when a toolchain can't be found 
When non-Googlers try to build Chromium for the first time they get an
error saying:

  Please follow the instructions at https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md

However those instructions are quite long and it's not obvious to some
users which part of the instructions they have forgotten. The most
likely is that they didn't set DEPOT_TOOLS_WIN_TOOLCHAIN=0, so this
changes the error message to suggest that directly.

Auto-detecting the correct state for DEPOT_TOOLS_WIN_TOOLCHAIN was
tried in crrev.com/c/1374833 but deemed impractical.

Bug: 907300, angleproject:2712
Change-Id: I45a9f59babe90bbe2137d49c555884d7bbbcf170
Reviewed-on: https://chromium-review.googlesource.com/c/1382942
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 6 years ago
recipe-roller 0a8ce8ee8b Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8 Make aggregated InfraFailures surface as exceptions. (joshuaseaton@google.com)


R=iannucci@chromium.org, martiniss@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1ce8de0ea0660d734f553d18a051ba0552d263e5
Reviewed-on: https://chromium-review.googlesource.com/c/1382977
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
 6 years ago
Mike Frysinger f9b112641c OWNERS: drop support/chromite_wrapper for now 
This syntax seems to be invalid, so remove it to unblock others.

Bug: 900461
No-Presubmit: True
Change-Id: I16569b8f8236a14b6dc879c973e4925a99649ac2
Reviewed-on: https://chromium-review.googlesource.com/c/1382975
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Mike Frysinger da32affb47 OWNERS: start a CrOS specific list for CrOS files in here 
Bug: 900461
Change-Id: I74bf2a048f766d95a8d11d74f5a97e67898299fe
Reviewed-on: https://chromium-review.googlesource.com/c/1380591
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 6 years ago
Vadim Shtayura f18aaf4f57 [cipd] Update CIPD client to v2.2.15. 
This picks up the following changes:
d052999e15..20acb61858/cipd

R=tandrii@chromium.org, iannucci@chromium.org
BUG=915278

Change-Id: Ibaa9d20456dcb513d9bbdaf0bca970390254ee67
Reviewed-on: https://chromium-review.googlesource.com/c/1381773
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 6 years ago
Don Garrett 24f2cc0de1 repo: Update the repo tool to 1.24. 
R=-owners

Bug: None
Change-Id: I9ff818b65b1c9a2a3a19f65932ffac4957dab0cc
Reviewed-on: https://chromium-review.googlesource.com/c/1382934
Auto-Submit: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>
 6 years ago
Takuto Ikuta cf56a4bfb0 [ninjalog_uploader] Add BuildTargetFromCommandLine function 
This function extracts build target from command line.

Bug: 900161
Change-Id: I38d37689a42437de76933ea3c9afb9def5a1253c
Reviewed-on: https://chromium-review.googlesource.com/c/1381911
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
 6 years ago
recipe-roller ff86ded41c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/dc70d2e73b72e43934db0f7dd816a061aa6f428d Add post_process functions for checking the status of a step. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I86b8b38db5dbbdec46efeeb929c937e193e489ea
Reviewed-on: https://chromium-review.googlesource.com/c/1381274
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
Takuto Ikuta 61cb9d6ba7 [ninjalog_uploader] add tests 
Use unittest module instead of doctest.

Bug: 900161
Change-Id: I2e8265afb66345814c4c4b8e94618171b7aaaaf3
Reviewed-on: https://chromium-review.googlesource.com/c/1379441
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
 6 years ago
Edward Lemur fb8c1a203d gclient eval: Replace monorail with crbug.com in error message. 
Tbr: tandrii@chromium.org
Bug: 914712
Change-Id: Iff8aecff346692ef36fd653f226b48270fefa304
Reviewed-on: https://chromium-review.googlesource.com/c/1380972
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lemur a1e4d48a10 setdep: Add support for variables when setting CIPD vars. 
Bug: 914712
Change-Id: I13db57af519bb254389bc6bd1f1f81ad1d497e42
Reviewed-on: https://chromium-review.googlesource.com/c/1377295
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
recipe-roller 27c6e44188 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0d040fde89eac5b4762eab44a97e9556de6cffb8 [path] Add additional info to the assert in mkdtemp/mkstemp. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iedb912a8205792211f10f221518b94a53bc9fb34
Reviewed-on: https://chromium-review.googlesource.com/c/1378962
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller c5ba34c644 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d3f6d71aea0086eb34ae3cbbe7fbfd729d16b29f Fix README generation from a66cf68621e2c514b7684e5404cd700a700f1aba (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I542f25dbea97c7a25b714ed41d005a26b6234f9e
Reviewed-on: https://chromium-review.googlesource.com/c/1378958
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 2eb7194395 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a66cf68621e2c514b7684e5404cd700a700f1aba [swarming] Create minimal swarming module. (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieeda3bddd24b2e839ce93a88bcfae45f6251e66e
Reviewed-on: https://chromium-review.googlesource.com/c/1378956
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller a7159ff1fe Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3 [depend_on] Remove "depend_on" functionality. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7b45506ea2a466d1773323a1d9e04471a10f3058
Reviewed-on: https://chromium-review.googlesource.com/c/1378955
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller 32af7de5aa Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100 [stream_logdog] Remove old unused annotations.proto support. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id20b679d186819a4452271e4aa338892753fee00
Reviewed-on: https://chromium-review.googlesource.com/c/1378953
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago
recipe-roller eb710576aa Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0cbbe4a2a8b0a309f08b5a5459292885e8e1ce07 [manual_roll] Add new manual_roll command. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7997ef3d51a412830ebbb97962445c90d7040c25
Reviewed-on: https://chromium-review.googlesource.com/c/1378926
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 6 years ago