Commit Graph

618 Commits (5f8f2a840282740c3363fd95f03839a52548bdf4)
 

Author SHA1 Message Date
maruel@chromium.org 5434b4e20a Reverting last change, broke update.
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48272 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 096469fa69 Enable automatic command and one-liner doc. Reformat pydoc accordingly.
Add parser as an argument and parse_args hook in preparation to move parse_args at the right place, inside the CMDxx functions.

R.I.P. gclient_test.py

Review URL: http://codereview.chromium.org/2253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48271 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 3eac705726 Add real gclient_smoke tests now
gclient sync, revert and status are tested.

GClientSmokeGIT.testRevertAndStatus is known to fail since git-backed revert doesn't work.

Review URL: http://codereview.chromium.org/2189001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48239 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org ff6cf0e5b8 gcl commit must accept additional arguments.
TBR=jam

Review URL: http://codereview.chromium.org/2252001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48235 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 35fe9ada4e Use function decorator to simplify main()
Review URL: http://codereview.chromium.org/2198001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48225 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
scherkus@chromium.org 95f0f4eb86 Strip the subversion revision when passing it as an argument to --revision.
Turns out svn treats extra whitespace as part of the revision number and throws an exception.

BUG=44790
TEST=insert some spaces in your revision arguments, gclient should still work
Review URL: http://codereview.chromium.org/2077017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47979 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 4d9da40423 When branch is not correctly set, it would throw an exception.
Review URL: http://codereview.chromium.org/2087015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47678 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
evan@chromium.org 400f3e7090 Prevent git from using any external diff program that may have been
configured for it when figuring out the patch to upload to the try
server.  This prevents git installations where the diff is configured
to use an interactive tool to work without doing nasty workarounds.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1958002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47661 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 83bea09ad2 Add basic gclient smoke tests.
The unit tests are unbearable and the next change forces me to trash them.
Thus adding smoke tests before. The current tests aren't involved enough yet but
are a good base for further testing.

I plan to only test the most important functionalities, the ones used in the continuous build and try server.

TEST=new smoke test
BUG=23328

Review URL: http://codereview.chromium.org/2092012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47580 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 1f440c497e Simplify a bit the gclient unit test
Review URL: http://codereview.chromium.org/2078011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47456 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org ddff62df37 Goes further down the rabbit hole.
Enable automatic command and one-liner doc. Reformat pydoc accordingly.
Add parser as an argument and parse_args hook in preparation to move parse_args at the right place, inside the CMDxx functions.
Update unit tests

Review URL: http://codereview.chromium.org/2129005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47449 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org a761b60c33 Fix unit test
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47437 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 491c04b1ea Run pychecker and caught some issues
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47436 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 7f5215d991 Update tests
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47435 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 1f7d1180cb Mode constants at their right places.
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47434 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 258d17f296 Fix SCM.ReadRootFile when self.gclient_root is not yet defined
Review URL: http://codereview.chromium.org/2102004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47426 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 7c1a02b577 In the previous change, I forgot to update the unit test.
Review URL: http://codereview.chromium.org/2098009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47391 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org e9e2223e6e Remove unneeded args of args that are the default value anyway.
Less text = better readability.

Review URL: http://codereview.chromium.org/2125005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47389 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 6386ccb236 Fix a logic error.
TBR

Review URL: http://codereview.chromium.org/2077003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47373 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 4c22d721d4 Refactor gcl.py to use a similar pattern for every commands.
The next step will be to generate help automatically and remove the command
check loop.

TEST=not much
BUG=me

Review URL: http://codereview.chromium.org/2096003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47291 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 79692d64d8 Remove redundance in the documentation.
Make the documentation more manageable and use automatic function discovery.

Review URL: http://codereview.chromium.org/2129003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47290 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 7aeac3ee34 Fix KeyboardInterrupt exception filtering.
Add exception information and not just the stack trace.
Make the url easier to change at runtime.

Review URL: http://codereview.chromium.org/2109001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47179 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 9addb1e18f Don't ask to upload a stack trace anymore.
The code proved to be robust enough to not do false positive, i.e.
no non-googler stack trace has been uploaded up to date.
So stop wasting users time and just do it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2014012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46992 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 2f6a0d87b1 gcl's caching was effectively disabled for > 1 year. Reenable it.
TEST=chmod a-w .svn/gcl_info/cache/codereview.settings and see if an exception is thrown when the file is recent

Review URL: http://codereview.chromium.org/2057006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46990 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 982984e163 Fix missing variable name in exception handler.
TEST=should stop throwing an exception when retrying for git checkouts
BUG=none

Review URL: http://codereview.chromium.org/2002015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46960 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org c97bfc68d5 Update upload.py to r529
Review URL: http://codereview.chromium.org/2027008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46948 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jochen@chromium.org a3683bbbee Enable CheckRietveldTryJobExecution for git-cl.
Review URL: http://codereview.chromium.org/1993008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46923 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 28a5a52732 Makes trychange.py search harder for codereview.settings in a gclient checkout.
This fixes issues with Chromium OS checkout.

BUG=crosbug:3132.
TEST=none

Review URL: http://codereview.chromium.org/2016006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46761 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
thestig@chromium.org 08c150e06d Fix a typo in gcl.py.
BUG=none
TEST=gcl change foo does not return Unknown command: 'change' after editing the CL.
Review URL: http://codereview.chromium.org/1997003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46602 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org a67a731cb9 Add "gcl description <change>" subcommand.
Prints the multi-line change description.
(Used in forthcoming Emacs gcl integration.)

Review URL: http://codereview.chromium.org/1935002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46599 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 3c55d98111 Fix issue with svn copy/move directories.
svn diff would only generate a diff for modified files but the current code
would not respect full_move=True. full_move=True is necessary to make it work on
the try server.

TEST=svn move chrome chrome2; echo foo>>PRESUBMIT.py
The try job should fail but the diff should be right.
BUG=none

Review URL: http://codereview.chromium.org/1965001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46566 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
vandebo@chromium.org c305768692 Support --gtest_filter for try jobs.
BUG=17948
TEST=submit various try jobs with and without -t option

Review URL: http://codereview.chromium.org/1733026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46173 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org b2b4631780 Make gclient.git.revert reset to DEPS revision
BUG=http://crosbug.com/2897

Review URL: http://codereview.chromium.org/1742017

Change-Id: I1398a349f1af728b593f0d4ea877831f25aed1f4

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46113 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 668ef5a2d6 Add "gcl rename <old-name> <new-name>" subcommand.
Review URL: http://codereview.chromium.org/1697022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46110 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org fd87617b28 Standardize automatic retry and add a 15 seconds sleep to increase the chances of success
Review URL: http://codereview.chromium.org/1812001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46067 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jabdelmalek@google.com fcff927b8c Make commit logs not have an extra http://
Review URL: http://codereview.chromium.org/1810009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46015 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org a630bd7e2c Add a fallback to origin/trunk too when the branch is not tracked.
Raise an exception in case an upstream branch can't be found.
Fix an exception that was occuring just before when no upstream is found.

Review URL: http://codereview.chromium.org/1755018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46011 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 81e012ce41 Modify scm.GIT.GetUpstreamBranch to behave like git-cl.
It now defaults to origin/master when no branch is tracked.

TEST=git-try on untracked branch now doesn't result in an empty diff
BUG=none

Review URL: http://codereview.chromium.org/1739021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45935 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 1dd0eea6fc Hack to work around bad cygwin, TMP and svn interaction.
Review URL: http://codereview.chromium.org/1702012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45852 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jabdelmalek@google.com 99ccbc58a8 Remove the host_override option to upload.py. This sets the Host header, which for some reason, trips the new internal proxy.
Review URL: http://codereview.chromium.org/1798008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45833 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 34d73cbd2a Add support for svn 1.4 to trychange.py
svn 1.4 doesn't have --depth parameter support so it cannot easily do a sparse checkout.

To workaround that, use svn import instead. It's also faster.
The main caveat is that the file must have a unique name, it uses a timestamp in file name for uniqueness.

Using a subdirectory (like the user name) doesn't work in the directory already exist.

It could be worked around but that would nullify the performance improvement.

Review URL: http://codereview.chromium.org/1783009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45811 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jabdelmalek@google.com eca300bb25 remove semicolon
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45762 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jabdelmalek@google.com 55ec1d8965 Bring in upload.py changes to allow uploading over https
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45745 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
tony@chromium.org d2e925611f Revert r45652 and r45653. It broke the single file export
feature.

TBR=piman,jamesr
Review URL: http://codereview.chromium.org/1730014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45660 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
piman@chromium.org 09fd102397 try/finally
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45653 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
piman@chromium.org 6f36372433 patch from issue 1640001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45652 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org f0379d1642 Fix broken unit test by r44612.
TEST=unit test
BUG=none

Review URL: http://codereview.chromium.org/1744007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45593 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
sky@chromium.org 42d8da5831 Changes GetSVNBranch to prefer origin/HEAD over all others.
Review URL: http://codereview.chromium.org/1745009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@45468 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
piman@chromium.org 54c3a7e9ad TBR: jamesr
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@44871 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
piman@chromium.org 8b5086d8d5 Add -j option to gclient to run parallel updates
On a chromeos checkout, -j 10 brings down null sync time from 2 minutes to 16 seconds
Currently -j may break some assumptions about ordering of commands (which may be fine for some clients, but not all), so it's not on by default.

Review URL: http://codereview.chromium.org/1640001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@44869 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago