aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,497 Commits
6 Branches
0 Tags
186 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '5e65fc3f7a'
${ noResults }
Commit Graph

10497 Commits (5e65fc3f7a22a3a9cb03f3ec58bc5e5374ccdadc)
 

Author SHA1 Message Date
recipe-roller eea30870b8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751094386930310481

recipe_engine:
09ec488090
  09ec488 (mohrr@google.com)
      [properties] Add deprecation warning for legacy()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I647da00ea9ba3c50a8a924a181083ca2df785499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5441632
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Brian Ryner 61a919010a New cpython3 and vpython3 packages to depot_tools. 
cpython3 notably has a fix for bug 40148998

vpython3 changes:
85f17b39dc4cd404444e3567371fc2c2ee80b733 cipkg: url action should return error for 4xx, 5xx http response
074c3f38e2059adab777b0fcf38b6861114b0306 vpython: Recognize linux_riscv64 in PlatformForPEP425Tag.

Bug: 40148998
Change-Id: Ie2e136e814cb62d8c5e8e2a380dfc0701a8f761f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5435876
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
 1 year ago
recipe-roller 520bd250ca Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751095642343815217

recipe_engine:
0846b9c4f9~..fac1f26c7b49457faf1a935f2106cf9838a27b86
  0846b9c (mohrr@google.com)
      [json] Add deprecation warning
  fac1f26 (mohrr@google.com)
      [buildbucket] Add warning for set_buildbucket_host()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6766116a442b900d3e30f072bd97986924b9bfcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5441485
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 3b8d270b5d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751118923525323473

recipe_engine:
d272488ffb
  d272488 (mohrr@google.com)
      [buildbucket] Add warnings for deprecated accessors

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id554573bbf278a6da03d55197b1a1c2589c33b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5440059
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller f85dd800c7 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751179323250255969

recipe_engine:
96ecadc583
  96ecadc (iannucci@chromium.org)
      [warnings] Fix unnecessary conditional.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I438eaec1bc9bb72f65c1c13fd62d85367d86d350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5437314
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller d521650bba Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751202600937127201

recipe_engine:
bf78629064
  bf78629 (chanli@chromium.org)
      [recipe_modules/buildbucket] use `bb batch` instead of `bb ls`...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iafb6674ac57e16c2324c5d9df256ced72e1d15ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5434839
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 10ca927423 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751207004454497857

recipe_engine:
0a8796815c
  0a87968 (mohrr@google.com)
      [step] Add warning for nest().presentation

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I99707ba0749d2a9d0ecefd6ab9ad437e7e7977b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5436155
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Bruce Dawson f8a14d93d5 Remove obsolete autoninja.bat comment 
A long time ago autoninja.bat had to avoid using Python 3 because of
problems with git bash. Those days are long past. We don't use Python 2
anymore. So I am removing the comment.

The comment was added in crrev.com/c/2634201 in 2021.

Change-Id: Ia3d3db495937478979c45cdc2c3443fd31620805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5014576
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 1 year ago
Gavin Mak 17551f6e84 Reword presubmit summary markdown 
The summary markdown assumes there's errors when there might not be.

Recipe-Nontrivial-Roll: build
Bug: 330512874
Change-Id: I4941bd0551f5bb64adec7a85bbaeb64c20e230b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5427700
Auto-Submit: Gavin Mak <gavinmak@google.com>
Reviewed-by: Louis Romero <lpromero@google.com>
Commit-Queue: Louis Romero <lpromero@google.com>
 1 year ago
Robert Iannucci 1a776cf430 [osx_sdk] Add TestApi to allow mocking macOS version. 
Some downstream repos rely on the 'current platform' detection and
would like to mock it in their tests. Give a real API for doing this
instead of having downstream recipes key on the internal step name
here.

R=athom, jeffyoon@google.com, whesse

Change-Id: If9d049c568c70cac9ddee1c06f2bd04ac4f572a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5428682
Reviewed-by: Alexander Thomas <athom@google.com>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 1 year ago
Will Harris 246580c7b8 Explicitly call vpython3 to launch the mojom formatter 
Before this change, on Windows launching the .py file would open it
with the system default handler (none, or notepad.exe) instead of
launching it with python.

This CL fixes this issue. Tested manually on Linux and Windows and
seems to work on both OS.

BUG=332935377

Change-Id: I8ef348c59dd08a4b5c2099f04968622aaa0927d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5427704
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Will Harris <wfh@chromium.org>
 1 year ago
recipe-roller e8745d8bf3 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751473131827418065

recipe_engine:
9bccd35273
  9bccd35 (iannucci@chromium.org)
      [recipe_engine/path] Make use of checkout based Paths a hard er...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iab3f37cb4a9d9352d46bcecab1b1fb872ea4e41c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5427702
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Stephanie Kim 589ccd8d54 Add GCS root and .gcs_entries file to keep track of installed gcs deps 
Now that multiple objects can share a directory, when objects are
removed, the directory should also remove the extracted contents
from that specific object. Since those exact contents are unknown, the
whole directory will be cleared.
If an entire GCS dep is added or removed, the corresponding directory
path will be cleared as well.

.gcs_entries holds a record of which GCS deps and objects
have been downloaded, per checkout. Example:
```
{
  "src": {
    "src/third_party/llvm-build/Release+Asserts": [
      "Linux_x64/llvmobjdump-llvmorg-19-init-2941-ga0b3dbaf-22.tar.xz",
      "Linux_x64/clang-llvmorg-19-init-2941-ga0b3dbaf-22.tar.xz"
    ],
    "src/third_party/node/linux": [
      "46795170ff5df9831955f163f6966abde581c8af"
    ]
  }
}
```

Bug: b/324418194
Change-Id: Icac113572523b61c83450880615418bf7df8bba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5407888
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
 1 year ago
recipe-roller b0583b002c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751479424280996801

recipe_engine:
d63fda0431
  d63fda0 (iannucci@chromium.org)
      [warnings] Change issues.chromium.org -> crbug.com. It's shorter.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia78185b1fb3b54c3568629f74f251fae31e1697f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5427697
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Stephanie Kim 2c9e581fad Allow multiple objects per GCS dep 
Allows multiple objects to use the same directory path.
This requires that each object has its own unique hash file and
unique migration file name. All object names must be unique.

Also update download_from_google_storage to check for the unique
migration file name.

Remove ConvertToGcs smoke tests since we're not converting
any git <-> gcs deps.

Example:
```
'src/third_party/llvm-build/Release+Asserts': {
  'dep_type': 'gcs',
  'condition': 'not llvm_force_head_revision',
  'bucket': 'chromium-browser-clang',
  'objects': [
      {
          'object_name': 'Linux_x64/clang-llvmorg-19-init-2941-ga0b3dbaf-22.tar.xz',
          'sha256sum': '7b33138d8592199f97d132242d7b3e10f460c5c9655d49a3ad3767218fba7a77',
          'size_bytes': 50212876,
      },
      {
         'object_name': 'Linux_x64/llvmobjdump-llvmorg-19-init-2941-ga0b3dbaf-22.tar.xz',
         'sha256sum': '14d669650cd212eb0ccb8c34a9e655338dfdee66fe2ecdaa517f6bd607c09a97',
         'size_bytes': 5302312,
       },
    ]
 },
```

TODO: update .gitignore to search for *_is_first_class and *_hash

Bug: b/324418194
Change-Id: I89d34b06ee24f4c1aa316cd51530ad078e823143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5420793
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 1 year ago
danakj e6aba2bcf1 Update the mac toolchain to 26bb3effce1bc1 
The list of toolchain hashes is here:
https://chromium.googlesource.com/infra/infra/+log/refs/heads/main/go/src/infra/cmd/mac_toolchain

Bug: chromium: 40284755
Change-Id: I225101faa8236c8c23417239e5682bb9312b8e15
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5428515
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 1 year ago
recipe-roller 680bb6e702 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751511511724825921

recipe_engine:
3628a0dbae
  3628a0d (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 27f0b4f36491 to 06dc7a1f2eeb

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id874ecfe89ec636cdd007a337d6bbcdd37be16f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5425506
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Joanna Wang f1098b6bfe Add generation version number to GCS first-class entries. 
Bug:b/328065301
Change-Id: I971c390a8f90e4f9734cd1e3d73ddb5fcf712b6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5413954
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 1 year ago
recipe-roller c810ef4b43 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751546115216362577

recipe_engine:
816f8727fd
  816f872 (mohrr@google.com)
      Add .editorconfig file

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idfdabdf562896d064615d35f71b338b736202221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5426997
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Aravind Vasudevan 7a7c5e3adc [scm] Remove unused methods 
Bug: 1475776
Change-Id: I75f8358f5ed475c180b60cfed825e66e4733f8f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5422043
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
 1 year ago
danakj 7fa774456f Add the latest Xcode versions for macOS 13.0, 13.5 and 14.0 
According to https://en.wikipedia.org/wiki/Xcode:
- macOS 13.0 is the minimum macOS version supported by
  14E222b and 14E300c
  - So we point 13.0 to the latest one, which is 14E300c
- macOS 13.5 is the minimum macOS version supported by
  15A240d, 15A507, 15C65, and 15C500b
  - So we point it to the latest one, which is 15C500b
- macOS 14.0 is the minimum macOS version supported by
  15E5204a (which looks like a typo of 15e204a according
  to xcodereleases.com and //infra/config/targets/mixins.star)
  - There will surely be more versions that support back
    to 14.0 but this is the only one for now. So we point
    it 15e204a.

This should hopefully give us C++20 support on macOS 13 and up,
like we see in the Chromium waterfall.

Bug: chromium: 40284755
Change-Id: I2049aa3c4b32990dbedbd95e9ec35cceaa1ca3a3
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5425635
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: danakj <danakj@chromium.org>
 1 year ago
Gavin Mak 371c850342 Remove aravindvasudev@google.com from OWNERS 
Change-Id: I6ac139506ec690f32c3ab97bde9dbf9043ded63f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5425449
Auto-Submit: Gavin Mak <gavinmak@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 1 year ago
danakj 8d8494a141 Add Xcode 15.2 (15C500b) for macOS version 14.2 
This is the Xcode version used in the chromium waterfall:

https://source.chromium.org/chromium/chromium/src/+/main:infra/config/targets/mixins.star;l=1832-1846;drc=d3b83cc14328bf58d20721b78ab3fd4187f52a76

Change-Id: Ia79d8ce713ea2d7a0701d8094001f9173e3466b9
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5425390
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: danakj <danakj@chromium.org>
 1 year ago
Ben Segall 90d54ff344 [reclient] Limit local resource tuning on windows to cloudtops 
Bug: b/330173550
Change-Id: I65ce93eeb216a7a4b77506fbcb515697fdecde2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5420670
Commit-Queue: Ben Segall <bentekkie@google.com>
Reviewed-by: Michael Savigny <msavigny@google.com>
 1 year ago
recipe-roller 5dc83f8b37 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751634824181063249

recipe_engine:
a7ad0d9e0d
  a7ad0d9 (mohrr@google.com)
      [post_process] Add HasLog and DoesNotHaveLog

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I45613d00927c3b350c6f4bca4373a9592dda91b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5422041
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 6a7d452df8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751635449578745697

recipe_engine:
c34697c8f9
  c34697c (iannucci@chromium.org)
      [warnings] Add support for Google Issue tracker bugs.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I23491d3b631c29d6fdaae4e240bc5b526d7f41c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5422040
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller f118b91b5c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751642369621723601

recipe_engine:
91cbd34246
  91cbd34 (jaredloucks@google.com)
      Add get_id_token() function to service account recipe module.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I97394318584381c2730716d08a2e12e16909f809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5420672
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 6e7cb70f78 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751642998938776065

recipe_engine:
5fd30390b9
  5fd3039 (mohrr@google.com)
      [python3] Don't explicitly inherit from object

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I92a83cc9fb7444c17b167c2cab395484156e6ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5420805
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 1a9ea5caf5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751724162731884273

recipe_engine:
770d39bbe1
  770d39b (mohrr@google.com)
      [python3] Remove obsolete __future__ imports

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I87fd882c22098a058cf85513c14e12e772f464cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5416896
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 7f26f1f0d1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751724790063460513

recipe_engine:
4ab8afb8a0
  4ab8afb (mohrr@google.com)
      [engine] Use 'yield from' when logical to do so

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2bf502b35d61d9094bde41f65bb2befbf8d7740b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5416895
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 881a7f92a7 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751726050641299553

recipe_engine:
248f1d78cf
  248f1d7 (mohrr@google.com)
      [cipd] Remove support for Python < 3.3

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4760fc0e087166233f97102330e53718512f44ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5416760
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 97b1b96e22 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751729194870083889

recipe_engine:
cc41de5351
  cc41de5 (mohrr@google.com)
      [cipd] Add partial annotations

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3cebc7dfb7bed4c8d0d3bb5df7829cb8c076007a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5416893
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Joanna Wang 8ce0983f79 Revert "Print presubmit command during git cl upload." 
This reverts commit 913bda46ea.

Reason for revert: no longer needed

Original change's description:
> Print presubmit command during git cl upload.
>
> Bug: 329231688
> Change-Id: I45d0afbebf01ea1cba4d7fdf32843a8e11eb424c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5401481
> Auto-Submit: Joanna Wang <jojwang@chromium.org>
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
> Commit-Queue: Joanna Wang <jojwang@chromium.org>

Bug: 329231688
Change-Id: I588b0c1a588d663a170cfd218f5338af8e9d1080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5413953
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
 1 year ago
Gavin Mak 4f31a1cef7 Omit `$ git log` line from roll-dep commit msg if --no-log 
If the user specifies `--no-log`, the message should not have a log
line.

Bug: b/332331835
Change-Id: I9883ea3cdf2b48255ef830000773f48a6e04e4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5410984
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 1 year ago
Alex Rudenko b57ec522d0 Revert "git_cl: format .nc file with clang-format" 
This reverts commit e545830db2.

Reason for revert: https://crbug.com/332481520

Original change's description:
> git_cl: format .nc file with clang-format
>
> This is for
> https://crrev.com/c/5197064/58/.clang-format#50
>
> Bug: 329138753
> Change-Id: I0938e1d610580e59a66409eb4fea4a1dad138bf1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5409735
> Reviewed-by: Joanna Wang <jojwang@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

Bug: 329138753
Change-Id: I696eeb3b12540af86e7af0cddfa42f79b27f99f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5412633
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
 1 year ago
Takuto Ikuta e545830db2 git_cl: format .nc file with clang-format 
This is for
https://crrev.com/c/5197064/58/.clang-format#50

Bug: 329138753
Change-Id: I0938e1d610580e59a66409eb4fea4a1dad138bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5409735
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 1 year ago
recipe-roller ca037e686b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751826713359574337

recipe_engine:
3868908180
  3868908 (mohrr@google.com)
      [python] Remove unnecessary typing imports

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I20bd71389210b4743cca1ccd8eaec4004da085eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5410980
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller d5dc98c054 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751827341066638673

recipe_engine:
60277337eb
  6027733 (mohrr@google.com)
      [python] Replace 'Union[x,y]' with 'x|y'

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb2b85bd023934288c858e456a21074b43f97454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5410977
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 19e6c6faa5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751828601485420321

recipe_engine:
02f5ab0041
  02f5ab0 (mohrr@google.com)
      [python] Replace 'Tuple' with 'tuple'

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie054ed97963f284fd9bea3048fcbfb7d4cc4c960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5410976
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 4e42051c5d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751832375695991057

recipe_engine:
c5580ec5cf~..9b90402c833bb8dafd20bd64c7fadcbfaacc3baa
  c5580ec (mohrr@google.com)
      [python3] Remove remaining imports of six
  9b90402 (mohrr@google.com)
      [python] Replace 'List' with 'list'

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I74962b73fec31cc46c3242160ea1f02359716b82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5410022
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller d60a598553 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751834261895858977

recipe_engine:
53a614b80c
  53a614b (mohrr@google.com)
      [python] Replace 'Dict' with 'dict'

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I047c7a199c56a33da3b2084da2caf17a46718d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5410640
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller b5cff9ca61 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8751837407924771169

recipe_engine:
ca41f8ed2e
  ca41f8e (mohrr@google.com)
      [python] Replace 'Optional[x]' with 'x | None'

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id1ff885738b84cc84307b715b2d26dff8584b2c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5410632
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
David Benjamin 2d6b598b7a windows_sdk: Fix docs to also mention arm64 
Change-Id: I39fb0f99e62a822b9aa7d1b099c3a73e4499e051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5345456
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 1 year ago
Vadim Shtayura 4a9d989f52 Roll recipe dependencies. 
To pick up
https://chromium.googlesource.com/infra/luci/recipes-py/+/fcb91e42

R=iannucci@chromium.org

Change-Id: I60d77bbdbe1eb92efd05370d45523af7600b7790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5406117
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 1 year ago
recipe-roller a5c46d2047 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8752241949455328833

recipe_engine:
35fbfce2c2
  35fbfce (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 0632b20143dc to a84377ac0800

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic617c35f9cdfc6777aa36a9131148afe51b36865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5401688
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 097ccfa40e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8752270260522406657

recipe_engine:
1c1799de87
  1c1799d (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 9b83c94cebed to 1cfcfd95c327

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idd5c1bb0109bf4e37f1f299b1ca21c0852f3cb37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5403787
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller a46e95ea68 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8752279067358474545

recipe_engine:
3e952180fa
  3e95218 (iannucci@chromium.org)
      [recipe_modules/platform] Remove mac_release.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I98597584b7e11c21d6d78faf6cbd2ddf88403f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5402923
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Joanna Wang 913bda46ea Print presubmit command during git cl upload. 
Bug: 329231688
Change-Id: I45d0afbebf01ea1cba4d7fdf32843a8e11eb424c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5401481
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 1 year ago
Michael Savigny 8de9817392 Add luci-auth account check for non-google on corp. 
Include a luci-auth check of the account logged in.

This is to check that a user isn't using a non-google account on a corp machine. Also this check is only performed every 12 hours, so it doesn't impact every build. This check was already performed with other auth mechanisms, this is just making sure it is being done for luci-auth as well.

Bug: b/330339907
Change-Id: I8ea97c8de0f2d74c2d735fa959d8227cec35df46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5379037
Auto-Submit: Michael Savigny <msavigny@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 1 year ago
Jiewei Qian 79cfa048c0 metadata: early terminate certain fields to avoid over extraction 
This CL adds a "early terminate the field based on field value" parser
mechanism to end the field as soon as the field value provides an
unambiguous answer to the question we care about.

This is to prevent over-extraction over certain fields (specifically,
local modifications) which can either be a definitive answer (e.g. No
modification) or multi-line free-form texts (which may contain unknown
fields that we don't care about at this stage).

This mitigates over extraction of README.chromium files like:

```
Local Modifications:
None

How to Uprev:
Steps...
```

Where the old parser would extract "None\n\nHow to Uprev:\nSteps..."

This CL also refactors single line fields to use the same early
termination mechanism since single line field simply ends as soon as
the line is parsed.

Union[Something, None] is changed to Optional[Something] based on
styleguide.

Bug: b/324149233
Change-Id: I3fca80eaceb071263f8ae8730afda230fff0bbb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5394917
Reviewed-by: Anne Redulla <aredulla@google.com>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
 1 year ago