aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,740 Commits
6 Branches
0 Tags
212 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '553de1a0bb'
${ noResults }
Commit Graph

9740 Commits (553de1a0bb00c8e6aa6e1fd918b27b9d8302e5bf)
 

Author SHA1 Message Date
Xinan Lin 1344a3c998 Add global 300s global timeout for Gerrit API calls 
This will not impact the calls which have explicit timeout.
For the rest, either PUT or POST or DELETE methods, 5 min should
suffice.

Fixed: 1441863
TEST=NA

Change-Id: I235bc60344b6981eb3d96930ca8b6463129a2be2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4495994
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 3 years ago
Jeff Yoon 13878e1f72 [depot_tools] Roll dirmd 
Releasing the following changes:
* crrev/c/4448527
* crrev/c/4472948
* crrev/c/4477412
* crrev/c/4471188

Bug: 1431748
Change-Id: I5629c558ae4028129d88db5399c8ea1059006061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4499278
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@google.com>
 3 years ago
recipe-roller 86a8468049 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8782190538485961329

recipe_engine:
52a5a62137
  52a5a62 (iannucci@chromium.org)
      Set py3_only for recipe-engine.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I69d6c35cd9d69a4ee9fd697db510efea1417aa89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4499273
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Garrett Beaty 37f499daec Default to an empty footers dict instead of None. 
By default during tests, the _get_footers_step call will return None for
the returned footers because it does not set any test data. This does
not match the actual behavior of the recipe because git_footers.py
returns an empty json object if the commit message has no footers. This
change updates it to return an empty dict instead of None and checks for
the cached footers value to be None instead of any non-true value so
that a commit message without footers doesn't get parsed multiple times.

Change-Id: I716a27e964eb92de138228df5cc0876322d82823
Recipe-Manual-Change: build
Recipe-Nontrivial-Roll: build_limited
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4492269
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 3 years ago
Josip Sokcevic c333c3424e Drop pylint-1.5 
R=gavinmak@google.com

Bug: 1353487
Change-Id: Ifbe09b60f891d585edbd5831e4cb3c5a97f1fe8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4491423
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 3 years ago
Joanna Wang 1398e4fc69 Update stacked changes dogfood message. 
Bug: 1441218
Change-Id: Ic82332d4ca1bda3049bb77daf90bf89aa8914577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4495347
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 3 years ago
recipe-roller afac8f672d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8782276102921184289

recipe_engine:
1b4211f38c
  1b4211f (jwata@google.com)
      [url] Fix pycurl.py to strip prefix

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idc6e6bbd8a426d934237f64ca907cccc30b2add2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4496950
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 098ccc7993 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8782279871036210673

recipe_engine:
e78c443e90
  e78c443 (sshrimp@google.com)
      Add update_invocation to resultdb module

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6db645fb9a0dd3fd5f2b5e2a3ad6db18cf082c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4496925
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Yiwei Zhang ce9bc414c0 roll lucicfg to v1.39.8 
To pick up https://crrev.com/c/4492145

R=ddoman

Bug: 1434499
Change-Id: I37797ce42f5d986998fbf21e4584451d0163f12f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4492272
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
 3 years ago
Josip Sokcevic afb5f0e3d3 Drop explicit PRESUBMIT py2 test 
R=gavinmak@google.com

Bug: 1376538
Change-Id: Ie5d1fbc2e7da1625f78016bb5d10e36d15ceb128
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4491463
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 3 years ago
Josip Sokcevic 0ddbf02283 [py3] Run gclient git test with py3 
R=gavinmak@google.com

Bug: 1376538
Change-Id: I742bc767cb6d7164921a481658517ae148127d47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4491345
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 3 years ago
Brian Ryner 9acd55ea89 Have fake_cipd accept 'export' in addition to 'ensure'. 
Change-Id: Ia82e81a2d4b5fc37856e9abbda79681b61f6fcd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4492323
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Brian Ryner <bryner@google.com>
 3 years ago
Joanna Wang ddd8578dbe Enroll everyone in stacked changes dogfood. 
Bug: b/265929888
Change-Id: Ib084e306a23a6159b8d5fe4b45bf9af731514665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4482418
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 3 years ago
Jack Rosenthal b5eff1ccff cros: Enforce minimum Python version of 3.8 
Our developer guide has stated that Python 3.8 or greater is required
since CL:4303078.  Additionally, this launcher has been warning users
of Python 3.6 and 3.7 for quite some time now.  Finally, Python 3.8 is
now the default interpeter in CrOS SDK.

I think it's safe to make 3.8 the hard minimum version.

R=vapier@chromium.org

Bug: b:187794810
Change-Id: I0d71ba916dafedd08757edc5beff539b788494bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4483617
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
 3 years ago
Vadim Shtayura 536c9b9662 [cipd] Update 2.6.11 => 2.6.12. 
Changes:
520840b412..606269b06a/cipd/client

R=dlf@google.com

Change-Id: I7f224abfc4af74454b7034c1b1c46cf774ff27ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4482874
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Dan Le Febvre <dlf@google.com>
 3 years ago
Gavin Mak d3568a42bf Handle windows paths correctly in CheckInclusiveLanguage 
Exclude file paths always use forward slash but tests currently change
based on which OS is running them, so this bug never got caught.

Bug: 1440473
Change-Id: Iafd7e57c2dedd0c9990a1a620abd3ae38631a4f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4481518
Reviewed-by: Sean McCullough <seanmccullough@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 3 years ago
Yngve Pettersen f7b9e70a2e Use relative path for cipd 
Using $base_dir/cipd as a path for the cipd command only works when
$base_dir is an absolute path, not when it is a relative path, as
the current directory is already $base_dir.

Therefore, "./cipd" must be used to run a command located in $base_dir.

Change-Id: Ia882a7fb404b7ff837944f80c0ace3f4e90e6a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4479169
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
 3 years ago
recipe-roller 6e714e6dfe Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8782896439892459441

recipe_engine:
8389d65c78
  8389d65 (flowerhack@google.com)
      [docs] Update incorrect docstring.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I981aac6264250e95d7b2c63474ec9ba8b7f1e093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4470348
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Ben Segall 7a0fe8bf3c Move reclient cache dir to gclient root to avoid wipeout on gn clean 
This speeds up small builds as we will still persist the credential
cache and it will speed up all builds as we will keep the deps cache
and compiler info cache.

Bug: b/278498980
Change-Id: I2fe26395a7493c461860b34ef3f109b2147abb5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4454889
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Ben Segall <bentekkie@google.com>
 3 years ago
Michael Achenbach b5cec8c867 Fix Python2 fallback in git-cl post-upload hooks 
This fixes an uninitialized variable.

Bug: 1411979, 1435326
Change-Id: Ib28ed259238ff478e78e36b48e74eaf51617cd6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4457528
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
Yoshiki Iguchi dec6fddc86 Revert "[lucicfg] Roll out lucicfg 1.39.5" 
This reverts commit 183769121f.

Reason for revert: causing an error in`lucicfg fmt`: crbug.com/1435227

Original change's description:
> [lucicfg] Roll out lucicfg 1.39.5
>
> R=​rgw, vadimsh
>
> Bug: 1417086
> Change-Id: I2416f5eab5e8a6d653f4db181443c22d0b0d893a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4455283
> Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

Bug: 1435227
Bug: 1417086
Change-Id: I78e543465eb126f599382a1022d24a1dc4b34d41
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4458211
Auto-Submit: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 3 years ago
Junji Watanabe 48fcabef4c [autosiso] suggest using siso command direclty for non build commands 
`autosiso` doesn't handle non build commands. e.g. help, version, login
We should encourage users to use `siso` command directly,
and get rid of  `autosiso` eventually at some point.

Bug: b/278675516
Change-Id: I651e537d8d03674f5d1996983083e25ab5d149c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4452374
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 3 years ago
Josip Sokcevic 34f62b4af7 Run post submit hooks on vpython3 if vpython is unavailable 
If bot doesn't have vpython, run post submit hooks with vpython3.
presubmit_support already checks this too, and it will run those
presubmits regardless of USE_PYTHON3 variable.

Bug: 1411979
Change-Id: Id7edb8a10c39d625154dcc5a131becad3d3ebcbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4457567
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
Bruce Dawson 407e5e7b66 Show error on Fixes: and suggest Fixed: 
The Bug: syntax is well known as a way of tagging bugs in a commit
message, at least partially because when it is missing there is a
presubmit warning suggesting that it be used.

The Fixed: syntax is less well known because there is no such reminder.
And, if somebody types "Fixes: " instead of "Fixed: " there is no error.
Therefore it is not surprising that "Fixes: " was used seven times in
the last 10,000 commits. See crrev.com/c/4416218 for one example.

This change adds both a reminder that Fixed: exists as well as an error
if Fixes: is used.

Fixed: 1434702
Change-Id: Id940d0af5cfea206ee923fbb779bf686b34c5f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4436316
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 3 years ago
Robert Iannucci 183769121f [lucicfg] Roll out lucicfg 1.39.5 
R=rgw, vadimsh

Bug: 1417086
Change-Id: I2416f5eab5e8a6d653f4db181443c22d0b0d893a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4455283
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 3 years ago
Ariel Zhang 2d1c655c2c Add CL description getter 
For context crrev.com/c/4450427.

R=gbeaty@google.com

Change-Id: Ic0a7847009be274010daeaf3181242ae34477a39
Bug: b/214597409
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4451469
Commit-Queue: Ariel Zhang <arielzhang@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 3 years ago
Ben Segall 6b62f42578 Fix reclientreport after functions moved to reclient_helper 
Bug: b/277763387
Change-Id: Ib0705b5f8e676df97a058e0d1fa7699e64a5ca1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4454887
Reviewed-by: Anas Sulaiman <mrahs@google.com>
Auto-Submit: Ben Segall <bentekkie@google.com>
Commit-Queue: Anas Sulaiman <mrahs@google.com>
 3 years ago
Junji Watanabe 607284d719 [siso] add autosiso wrappers 
Developers will be able to use `autosiso` command to invoke siso builds.
This CL extracts reclient management logic from `ninja_reclient` to be  reused in both Ninja and Siso builds.

Bug: b/278675516
Change-Id: I3e64a3188db184f4d3f851063a0feef7d3a73d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4445366
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 3 years ago
recipe-roller 0d6cb8fa70 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783348794280333425

recipe_engine:
5a794c0398
  5a794c0 (yiwzhang@google.com)
      use tricium spellchecker generated by the builder

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4da22edd7dbbb177d963db2a9060c3126898fb8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4451467
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Chan Li af20d7cbaa [depot_tools] roll bb 
To release https://crrev.com/c/4424857

Bug: 1430324
Change-Id: I0bf8051f9b716646cbf5a551bda8caf6486d0f10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4449948
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 3 years ago
recipe-roller b15d30b775 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783359490318040257

recipe_engine:
6ab407d40c
  6ab407d (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2293629b4919 to 56489f37e8ef

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I07118c23d6554f1b0e66b0836b12d968bd9507e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4449947
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Joanna Wang fd9cea79c1 Use --upstream when calling bot_update (passed to gclient sync). 
Should resolve this flaky issue in infra-try builds : https://ci.chromium.org/ui/p/infra/builders/try/infra-try-bionic-64/b8783448305870388449/overview

in logs we see

'''
________ running 'git reset --hard HEAD' in '/b/s/w/ir/cache/builder/infra'
[0:00:02] HEAD is now at 64b4e8f867 Committed patch
[0:00:03] Finished running: git -c core.quotePath=false status --porcelain
[0:00:03] Attempting rebase onto d94466a8462dd19c2a3fc0ca173fd1c89a1f3f28...
[0:00:04] Current branch tmp_checkin_branch is up to date.
[0:00:04] Finished running: git rev-parse HEAD
Checked out revision 64b4e8f867c7b8757438b7e64985654d80a3b135
'''
64b4e8f867 is not a valid infra/infra commit. It is a local commit created from the patch of the last try-job run.

Prior to switching recipes to infra_superproject, we have been depending on https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:recipes/recipe_modules/bot_update/resources/bot_update.py;l=753;drc=489304d94984bb006a03e842cf2c171c73e7d367 to bring the checkout back to a valid remote infra/infra commit before we get to `gclient sync`. But with infra_superproject as the new root solution, `git checkout --force <pin>` runs for infra_superproject.

'git reset --hard HEAD' is coming from:
https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:gclient_scm.py;l=786-791;drc=cf4658579326856b9b25cfe2efbfc8683af88814

This is noop. The previous patch commit IS HEAD.

With --upstream we get: `git reset --hard refs/remotes/origin/main`


Bug: 1421776, 1434522
Change-Id: I0d192a160fcc7c3d405765e2e03e05aeb60f6875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4445126
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 3 years ago
recipe-roller 20ca4c37b7 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783360748880568545

recipe_engine:
114bdbdc9a
  114bdbd (yiwzhang@google.com)
      use the version defined in tricium analyzer instead of live

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e0b5326465f944d0173bf1c2567e3b35d0dbb34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4449946
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Eric Lok e4ff80f5cf Update version of reclient 
Fixes issue where reclient erroneously shutdown during startup via
bootstrap.

BUG=b:269549741
TEST=Run bootstrap locally using the new version specified in this
change.

Change-Id: Ic443ba48d4d976a5341847bd7855e7d7fb63cc61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4445369
Commit-Queue: Eric Lok <lokeric@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Eric Lok <lokeric@google.com>
 3 years ago
Josip Sokcevic 54762c2217 Handle 401 from gsutil 
Instruct user to use gsutil.py config if they get 401 from gsutil
operation. Setting project ID is no longer applicable.

R=aravindvasudev@google.com

Bug: 1433494
Change-Id: Ibbb22a9b5bb3a92e35f689371701eb051b38c202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4442760
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 3 years ago
Ben Segall 9e36ef60d0 Add convenience wrapper for reclientreport for autoninja users 
This is designed to be called by a developer when they want to submit an reclient bug report.
Developers could just call the //buildtools/reclient/reclientreport binary directly but this wrapper provides an easier way to set the same log flags that are set by ninja_reclient.
I dont think we should bundle this logic into autoninja as this is not required in 99% of builds.

Bug: b/277763387
Change-Id: I0204b6acc22f199b461ef710d0dfd07e05534af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4414921
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Ben Segall <bentekkie@google.com>
 3 years ago
recipe-roller da6ce67245 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783443167691062689

recipe_engine:
162ea7d277
  162ea7d (yiwzhang@google.com)
      use simple tricium functions built by builder

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id54015cfc77996fde7a44dccf5e2d41339c4656b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4442754
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 84792b3a3b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783450715536891281

recipe_engine:
2239570161
  2239570 (iannucci@chromium.org)
      Adjust racy test in run_test.py

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iebb0f4404ea7752a28d38bf9ca15960d32ae0b1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4442753
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Chan Li 59ebbc12eb [depot_tools] Roll led 
To release changes:
https://crrev.com/c/4438369
https://crrev.com/c/4424854

Bug: 1434119, 1433082
Change-Id: Ia6ecaca76beec1a85650a2ee60192d3be40bad8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4442747
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
 3 years ago
recipe-roller 3019ba78bb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783461402702744545

recipe_engine:
d3d4e72e12
  d3d4e72 (ddoman@chromium.org)
      [recipes-py] roll recipe_proto

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ee0f253a26370d2f2ed09702e20d44b9ee5ef3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4440555
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller ed0026c9fd Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783462670917359201

recipe_engine:
1548506817
  1548506 (ddoman@chromium.org)
      [recipes-py] remove api.resultdb.get_test_result_history()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I374a027b290b946c42e24ab209059836832d04d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4440553
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 923f33d743 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783497891200885713

recipe_engine:
f12826f7a6
  f12826f (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8221a7a30ba2 to 265d6513a697

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I29b13d3673ff99d6e52575e58cca069b1945f793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4436318
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 93c715cc64 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783528731649231569

recipe_engine:
618bc26448
  618bc26 (yiwzhang@google.com)
      change the package and version for legacy copyright tricium fun...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8b86eee3e8eeec119b7148ee9d44814c138feec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4436315
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Ben Pastene 97dadd025f Apply the gerrit REST timeout to only 'GetChanges' calls 
https://crrev.com/c/4420526 put a 10s timeout on all calls made via
this script.

But it appears there are a variety of endpoints that take more than
10s, the latest being "SubmitChange", eg:
https://ci.chromium.org/ui/p/chromeos/builders/release/release-R113-15393.B-orchestrator/25/overview

So instead of applying the timeout to everything, and then opting
certain long-running calls out of it, this just opts-in the
"GetChanges" call to the timeout. This should cover the failure mode
that was originally solved for chrome's bots. And also bump the
timeout to 30s since we don't trust all get-changes queries to
reliably finish in under 10s.

This also bumps the step level timeout for the query in tryserver
recipe_mod to 8 min since there could be ~5min worth of sleeping +
150s worth of waiting+timing-out. So worst case the step will now
take 8min to fully exhaust all timeouts/sleeps.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: b/278083716
Change-Id: Ib366e004e0bb07297ba732590d488cae779e38ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4426524
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
 3 years ago
Josip Sokcevic 9a285c2794 Fix infra_to_superproject for Linux 
When using shell=True on Linux, subprocess only executes first item on
the list. In this case, it calls fetch without providing config. Windows
works just fine.

R=jojwang@google.com

Fix: 1433139
Change-Id: Ib3b0bef4d05c0ff076d936e1d8a00047158e2e96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4428533
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
Joanna Wang 4a2243196c Use shutil.copytree instead for migration script instead. 
tested:
`infra_to_superproject`
`infra_to_superproject --no-backup`
Bug: 1415507
Change-Id: I684d9467cddaeca4a2a640bb034d4b839699bd56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4419634
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 3 years ago
Ben Pastene 04182559c5 Don't put a timeout on 'CreateChange' gerrit rest calls 
https://crrev.com/c/4420526 put a 10s timeout on all calls made via
this script. But the "CreateChange" endpoint can sometimes take 1+ min.

eg: One of the calls in the following build took 1.1 min:
https://ci.chromium.org/ui/p/chrome/builders/official.infra/chrome-release/8203/overview

So this removes the timeout for CreateChange calls since it's
unclear what a good timeout for that would be.

Bug: 1433047
Change-Id: If6e68663a11add1d72691e97018dba73cfed4f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4423859
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
 3 years ago
Fumitoshi Ukai 3ca8d0d0ca add siso wrapper 
Bug: b/277855544, b/277859568
Change-Id: I520834647881745db7a42fd357bc829a7c6779d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4413517
Reviewed-by: Philipp Wollermann <philwo@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
 3 years ago
Patrick Meiring e718a91487 [ResultDB] Roll RDB CLI. 
Adds -sources, -sources-file, -inherit-sources options
to `rdb stream`.

Includes changes:
520840b412..925188ce48/resultdb/

BUG=b:274041961
TEST=None

Change-Id: I0c4d08475cf61e94c858f7f33a58626079339d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4421806
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Patrick Meiring <meiring@google.com>
Auto-Submit: Patrick Meiring <meiring@google.com>
 3 years ago
recipe-roller 88f79dd119 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8783982974160448945

recipe_engine:
56bdc99272
  56bdc99 (ddoman@chromium.org)
      [recipes-py] add validate.proto for pgv

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I57f26f8f62d42c0565f7343784435889cb8d1d49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4420530
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago