Flaw in loop logic, causes it to miss the occasional file.
BUG=None
TEST=None
TBR=maruel
Review URL: http://codereview.chromium.org/209008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26427 0039d316-1c4b-4281-b951-d872f2087c98
Part of a larger refactoring to abstract SCM-specific bits.
presubmit_support, revert, gcl: modify to import gclient_scm and gclient_utils
Part of a larger refactoring to abstract SCM-specific bits.
revert, gcl: modify to import gclient_scm and gclient_utils
Part of a larger refactoring to abstract SCM-specific bits.
gclient: pull out SCM bits
Pulled out SCMWrapper into gcliet_scm.py as part of a larger refactoring to
abstract SCM-specific bits. Plan is to evenutally add git support.
Pulling out SCMWrapper also required pulling out utility functions into
a gclient_utility.py.
Patch contributed by msb@
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26423 0039d316-1c4b-4281-b951-d872f2087c98
name of the top level "DEPS" file of a solution from within the .gclient spec.
This allows users to edit their gclient once and use a different (perhaps
experimental) DEPS file instead of the traditionally named "DEPS".
Review URL: http://codereview.chromium.org/203040
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26031 0039d316-1c4b-4281-b951-d872f2087c98
Defaulting to a value in codereview.settings
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/200078
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25886 0039d316-1c4b-4281-b951-d872f2087c98
isn't included in the calculation.
BUG=none
TEST=submit change with presubmit warning, note reported time
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25806 0039d316-1c4b-4281-b951-d872f2087c98
the root of the source tree. It is similar to "gclient diff", and
shares much of the implementation, but it seems that developers may
want the semantics of each in different situations, which is why it is
being added as a new command.
Generalized SubprocessCallAndCapture into SubprocessCallAndFilter.
Added RunSVNAndFilterOutput; changed RunSVNAndGetFileList to use it.
Fixed problem in presubmit_canned_checks.py where it was not working
on Windows. Updated unit tests for gclient.
Review URL: http://codereview.chromium.org/193004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25410 0039d316-1c4b-4281-b951-d872f2087c98
BUG=none
TEST=creates a working Chromium git repository in src
Review URL: http://codereview.chromium.org/173599
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24991 0039d316-1c4b-4281-b951-d872f2087c98
Make git-try use trychange for both SVN and HTTP try
server submits. Simplifies git-try and reduces chance
of differences in behavior between SVN and HTTP try
job submits.
Exit early if the checkout's configured email address
does not pass validation.
Simplify trychange import.
BUG=none
TEST=git-try submits a job to the try server
Review URL: http://codereview.chromium.org/173394
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24315 0039d316-1c4b-4281-b951-d872f2087c98
Based on Mark Mentovai's mail.
Review URL: http://codereview.chromium.org/164068
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@22616 0039d316-1c4b-4281-b951-d872f2087c98
so you can type only cpplint in console like the other scripts(gclient, gcl, etc)
BUG=None
TEST=None
Patch contributed by thiago.farina@gmail.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@22576 0039d316-1c4b-4281-b951-d872f2087c98
1) don't save empty changelists to begin with. This guards against an accidental or canceled "gcl change" creating an empty file.
2) create a "clearempties" command which clears all changelists that don't have any files in them.
Review URL: http://codereview.chromium.org/160139
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@22538 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
johnnyg@chromium.org
robertshield@google.com
bradnelson@google.com
thestig@chromium.org
dpranke@google.com
gspencer@google.com
pam@chromium.org
sgk@google.com
kbr@google.com
thakis@chromium.org
chase@chromium.org
mattm@chromium.org
mark@chromium.org
jam@chromium.org
phajdan.jr@chromium.org
laforge@chromium.org
estade@chromium.org
ukai@chromium.org