maruel@chromium.org
46e832a00b
Add svn:mime-type canned checks.
...
TEST=new unit tests
BUG=none
Review URL: http://codereview.chromium.org/131056
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18739 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
ccde1c92e6
Write the command to execute in the error message so people don't have to learn how svn works.
...
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/126050
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18273 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
f5888bb793
Add CheckChangeHasNoStrayWhitespace().
...
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/118527
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18081 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0874d47499
Update CheckChangeSvnEolStyle() to be upload-friendly.
...
TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/118525
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18079 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
bc50eb4a88
Add CheckChangeHasDescription.
...
TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/119427
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18077 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e9b71c9b3a
Add CheckChangeHasOnlyOneEol and CheckChangeHasNoCrAndHasOnlyOneEol.
...
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/118505
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18075 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1a0e3cb2cc
Add the default parameter to CheckChangeSvnEolStyle.
...
TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/119433
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18074 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
c809ec2749
Suppress RunPythonUnitTests output while running.
...
The output is only shown when it's failing. It makes the presubmit check much cleaner.
Also rename TestDescription and TestContent that were ill named.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118415
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18055 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
b7d469083f
Add CheckChangeSvnEolStyle presubmit canned check.
...
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/119421
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18053 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
3410d917f3
Add InputApi.AffectedSourceFile() and custom filtering support.
...
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119365
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17975 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
5c2720e46c
Make the CheckLongLines() less restrictive in cases where it's hard to enforce.
...
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118416
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17937 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
44a17adf95
Add InputApi.ReadFile() and presubmit_canned_checks.CheckChangeHasNoCR().
...
ReadFile limits to reading files inside the repository.
CheckChangeHasNoCR reads the text files looking for \r and fails if found.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118370
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17857 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
de0ba297d9
Fix presubmit_support.py run standalone and RunPythonUnitTests
...
TEST=none
BUG=none
TBR=joi
Review URL: http://codereview.chromium.org/119285
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17839 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
8949138ee9
Use more sensible behavior in presubmit checks.
...
It's less annoying to type Y than to have to rerun the scripts with --no_presubmit for certain checks.
TEST=none
BUG=none
TBR=joi
Review URL: http://codereview.chromium.org/119284
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17838 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
d7dccf5614
Add InputApi.is_committing to be able to return a failure or notification, depending on the check.
...
Add input_api.traceback, useful for dumping information.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119252
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17837 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1487d53b6c
Improve the presubmit_canned_checks testing by using a real mock and testing for more cases.
...
Remove a superfluous check in CheckLongLines().
Add unittest to InputApi.
Review URL: http://codereview.chromium.org/114082
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17805 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e1a524ff00
Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code.
...
Review URL: http://codereview.chromium.org/113883
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16983 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
7b305e8c18
Add new presubmit check RunPythonUnitTests.
...
Review URL: http://codereview.chromium.org/115516
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16390 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
kuchhal@chromium.org
00c41e457b
Add presubmit checks to look for BUG= and TEST= tags in change list description (Part 1 of 2).
...
BUG=11287
TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used.
Review URL: http://codereview.chromium.org/113294
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15905 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@google.com
fb2b8eb2e2
Create the Next Generation of depot_tools. Eh.
...
Review URL: http://codereview.chromium.org/92087
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14349 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago