The Android WebView code includes several manually-maintained .mk files
that are included by the Android build system. These contain some fairly
long lines as they need to refer to deep pathnames, which means the CQ
cannot be used as it always triggers a presubmit warning.
Allow .mk files to have 200 columns per line instead, which should be
enough for the long paths that are used. Add a test case for this.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12252067
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@182733 0039d316-1c4b-4281-b951-d872f2087c98
gpylint doesn't like the use of "type" as a variable name (redefining a
builtin) - change the signature of the method to use the exc_ prefix
like sys.exc_*. The variables are not actually used anyway.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12255048
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@182722 0039d316-1c4b-4281-b951-d872f2087c98
This fix adds the crosbug.com shorturl scheme for the chromium-os project.
BUG=None
TEST=manual run of ./my_activity.py
Review URL: https://chromiumcodereview.appspot.com/12226135
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@182300 0039d316-1c4b-4281-b951-d872f2087c98
This is basically a wrapper script for running a WebKit change against
the try bots. It can be run from within third_party/WebKit and will try to apply the patch against ToT WebKit.
This tells the try server we want to use ToT WebKit by passing third_party/WebKit@HEAD as the first line of the patch file.
BUG=None
Review URL: https://codereview.chromium.org/12226013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@181972 0039d316-1c4b-4281-b951-d872f2087c98
Chromite will be added to the Chrome checkout at third_party/chromite -
detect when the checkout is a gclient checkout, and look for chromite at
that path.
BUG=None
TEST=ran 'cbuildbot' in both a repo and gclient checkout.
Review URL: https://chromiumcodereview.appspot.com/12094111
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@181563 0039d316-1c4b-4281-b951-d872f2087c98
Use closest git commit to the target svn revision.
Otherwise --checkout may be required to create
a git commit for a specific svn revision.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11886086
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@179023 0039d316-1c4b-4281-b951-d872f2087c98
The old code would always exit 0, because it returned the exit status of the if command
BUG=none
TEST=try to run git crup in src/ with unstaged changes. Should bail out and not run hooks
R=szager@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12040046
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@178356 0039d316-1c4b-4281-b951-d872f2087c98
Very long comments, like when posting a diff that failed to apply, cause extra
burden on the Commit Queue logs.
TBR=csharp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11929027
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@177713 0039d316-1c4b-4281-b951-d872f2087c98
r176777 introduced a change that relied on os.path.samepath, which does not exist on Windows.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12021013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@177701 0039d316-1c4b-4281-b951-d872f2087c98
previously we would return "*" as one of the suggested owners when
a CL included a file that anyone could approve. If the change had
other owners, the "*" was unnecessary, and if the change only included
wildcard-owned files, "*" isn't very helpful, so I've changed the text slightly.
R=maruel@chromium.org
BUG=169168
Review URL: https://chromiumcodereview.appspot.com/11867016
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@177575 0039d316-1c4b-4281-b951-d872f2087c98
The previous --force-branch option is renamed --checkout (the old name preserved for backwards compatibility).
Usage:
--checkout Create a branch and check it out.
--create Create a branch.
-n, --name <name> Specify the name of branch to create or reset.
This will force the branch using 'git branch -f '.
-q, --quiet Quiet.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11962003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@177286 0039d316-1c4b-4281-b951-d872f2087c98
pylint checks were erronously excluded for PRESUBMIT.py files in
root directory of repos because the regex was getting a './' added.
R=iannucci@chromium.org
TBR=M-A
Review URL: https://chromiumcodereview.appspot.com/11880040
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@176777 0039d316-1c4b-4281-b951-d872f2087c98
This fixes a potential issue with RunPylint in windows where paths
can contain special characters.
TBR=iannucci@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11786007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@175481 0039d316-1c4b-4281-b951-d872f2087c98
It's bad python practice to use a class-level member that is mutable. self.calls
is already initialized in __init__ so it's not useful (and dangerous) to have it
as a class member.
R=cmp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11801018
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@175368 0039d316-1c4b-4281-b951-d872f2087c98
The AffectedSourceFiles query matches against files with paths relative
to repository root. On the other hand _FindAllFiles checks white_lists
and black_lists against files paths relative to PRESUBMIT.py
As a result, when a PRESUBMIT.py is not at RepositoryRoot, RunPylint
can misbehave.
I fix this by modifying the white_lists and black_list regexes to
include the relative directory of PRESUBMIT.py.
Also adding some logging to pylint and simplified misc logic.
Review URL: https://chromiumcodereview.appspot.com/11776016
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@175364 0039d316-1c4b-4281-b951-d872f2087c98
I've found it helpful and instructive to see what we're posting to
rietveld. Let's add it as a debug log for others too. Can be helpful
to debug certain network issues.
Review URL: https://chromiumcodereview.appspot.com/11778015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@175361 0039d316-1c4b-4281-b951-d872f2087c98
This fixes the following crash:
Traceback (most recent call last):
File "/usr/local/google/home/pliard/ssd/depot_tools/drover.py", line 682, in <module>
sys.exit(main())
File "/usr/local/google/home/pliard/ssd/depot_tools/drover.py", line 678, in main
return drover(options, args)
File "/usr/local/google/home/pliard/ssd/depot_tools/drover.py", line 493, in drover
options.branch = getBranchForMilestone(options.milestone)
File "/usr/local/google/home/pliard/ssd/depot_tools/drover.py", line 393, in getBranchForMilestone
version = string.split(parameters[2], '.')
IndexError: list index out of range
Sending crash report ...
args: ['/usr/local/google/home/pliard/ssd/depot_tools/drover.py', '--merge', '175139', '--milestone', '25']
cwd: /mnt/ssd/pliard/chromium/src/drover
exception: list index out of range
host: vox.par.corp.google.com
stack: File "/usr/local/google/home/pliard/ssd/depot_to
user: pliard
version: 2.7.3 (default, Aug 1 2012, 05:14:39)
[GCC 4.6.3
This function is called when the --milestone switch is provided. It requests
omahaproxy to fetch the branch corresponding to the provided milestone.
This function expects some CSV data coming from omahaproxy although it appeared
to actually receive the same HTML data that a browser receives when requesting
http://omahaproxy.appspot.com (user agent issue?).
Review URL: https://chromiumcodereview.appspot.com/11801007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@175337 0039d316-1c4b-4281-b951-d872f2087c98
Adding -u and -f as short options for --upload and --force.
There is precedent for these short options elsewhere in
git_cl.py
TBR=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11783007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@175310 0039d316-1c4b-4281-b951-d872f2087c98
On mac, I ran:
git checkout v1.1.0
ninja
./ninja ninja_test
./ninja_test # all passed
strip ninja
I verified that the empty build speed doesn't change.
Mac binary size grew by ~8kB.
The linux binaries were built by tony@chromium.org.
The windows binary was built by scottmg@chromium.org.
BUG=167996
Review URL: https://codereview.chromium.org/11734004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174818 0039d316-1c4b-4281-b951-d872f2087c98
Call update_depot_tools and re-invoke from git-crup, to get latest
updates.
Move more of the target os functionality into git-crup.sh, so there's
no longer a need for a first-checkout script.
`git submodule sync` is horribly slow on windows. Replicate the
functionality (but faster) in git-crup.sh.
TBR=mmoss@chromium.org,cmp@chromium.org
Review URL: https://codereview.chromium.org/11709003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174747 0039d316-1c4b-4281-b951-d872f2087c98
To be used in conjunction with the --template argument to git-clone.
The hooks all redirect to build/git-hooks, which are files under
revision control. This allows us to version the hooks along with
the source code.
TBR=mmoss@chromium.org,cmp@chromium.org
Review URL: https://codereview.chromium.org/11689005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174738 0039d316-1c4b-4281-b951-d872f2087c98
If the working copy isn't on a named branch, don't try to
pull; just fetch.
Use --quiet flag to git-submodule, to prevent interleaving of
terminal output.
Check target os before updating a submodule.
TBR'ing, since no one really has a stake in this, and maruel doesn't
do bash :).
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/11645056
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174280 0039d316-1c4b-4281-b951-d872f2087c98
This version handles the case where we need to suggest two reviewers
who have overlapping sets of directories they can review.
R=maruel@chromium.org
BUG=76727
Review URL: https://chromiumcodereview.appspot.com/11639028
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174216 0039d316-1c4b-4281-b951-d872f2087c98
This adds the possibility to specify the format for your activity
through: -f <format>, --output-format=<format>
<format> is specified as in strings.format(...).
It is also possible to specify the output format for specific
activity types.
This enables users to use other formats such as Markdown:
[%(title)s](%(url)s)
This CL also adds support for new variables such as author,
and adds a generic framework for adding more variables.
BUG=166519
Review URL: https://chromiumcodereview.appspot.com/11607007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174203 0039d316-1c4b-4281-b951-d872f2087c98
In https://codereview.chromium.org/11574007/ I attempted to make it possible to use the TRYSERVER_ROOT setting in codereview.settings. It seems like some checkouts ran into errors with it not finding the codereview.settings file when it was parsed. This is probably due to the fact that the following call chain reads the self.toplevel_root variable:
_GclStyleSettings -> GetCodeReviewSetting -> ReadRootFile
By moving _GclStyleSettings up before self.toplevel_root is set probably causes this.
This CL attempts to correct this.
BUG=none, but try job upload fails for some users.
TEST=submitting try job to locally running try server.
Review URL: https://chromiumcodereview.appspot.com/11571052
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173928 0039d316-1c4b-4281-b951-d872f2087c98
This would cause a few exceptions on the CQ until it realizes the checkout is
not present anymore.
R=petermayo@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11649011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173916 0039d316-1c4b-4281-b951-d872f2087c98
iannucci@chromium.org
sadrul@chromium.org
szager@chromium.org
torne@chromium.org
deymo@chromium.org
tony@chromium.org
bcwhite@chromium.org
maruel@chromium.org
rcui@google.com
mmoss@chromium.org
laforge@chromium.org
scheib@chromium.org
jochen@chromium.org
chrisha@chromium.org
dpranke@chromium.org
ilevy@chromium.org
pliard@chromium.org
thakis@chromium.org
ferringb@google.com
nyquist@chromium.org
kjellander@chromium.org