Owen Rodley
5339c686ff
Update "cit" tool to use vpython instead of run.py.
...
Note that this can't be submitted until the infra "cit" branch has been
bumped to at least https://crrev.com/c/3041136 . See
https://crbug.com/1236862 for details.
Bug: 1229907
Change-Id: I331cdd5d0ce35fb23e4634e125c462a7ed19e837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3071511
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Owen Rodley <orodley@chromium.org>
4 years ago
Josip Sokcevic
3912091152
Use py3 for remaining tools in depot_tools path
...
R=apolito@google.com, dpranke@google.com
Bug: 1199102
Change-Id: I06ff344ac91464eb558e92598c87e43ecfa830dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2994488
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Edward Lesmes
cf06cad1be
[subprocess2] Replace VOID with DEVNULL
...
subprocess.DEVNULL was introduced in Python3 to serve same purpose
as subprocess2.VOID, so rename VOID to DEVNULL in subprocess2.
Change-Id: I6dade3306ffc3bc2441ac6083f362b099c2427e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2587758
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
James Darpinian
f994d87e56
Revert "Reland "depot_tools: Move six to depot_tools' .vpython""
...
This reverts commit d52b306f84
.
Reason for revert: Broke ANGLE CQ with "ImportError: No module named six"
Example: https://ci.chromium.org/p/angle/builders/try/mac-dbg/6758
Original change's description:
> Reland "depot_tools: Move six to depot_tools' .vpython"
>
> This is a reland of 3a98df0bdd
>
> Original change's description:
> > depot_tools: Move six to depot_tools' .vpython
> >
> > Bug: 984182
> > Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> > Reviewed-by: Michael Moss <mmoss@chromium.org>
>
> Bug: 984182
> Change-Id: Ibf7034201e65a18f833cf1e7432f81a903a99aae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1732880
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
TBR=iannucci@chromium.org,mmoss@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org
Change-Id: Id4488249b607441df9f00aa51f4a1f2bc4ad5cfd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1739582
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
6 years ago
Edward Lemur
d52b306f84
Reland "depot_tools: Move six to depot_tools' .vpython"
...
This is a reland of 3a98df0bdd
Original change's description:
> depot_tools: Move six to depot_tools' .vpython
>
> Bug: 984182
> Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Michael Moss <mmoss@chromium.org>
Bug: 984182
Change-Id: Ibf7034201e65a18f833cf1e7432f81a903a99aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1732880
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Edward Lesmes
365720e237
Revert "depot_tools: Move six to depot_tools' .vpython"
...
This reverts commit 3a98df0bdd
.
Reason for revert:
Can't roll into skia and build_internal
Original change's description:
> depot_tools: Move six to depot_tools' .vpython
>
> Bug: 984182
> Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Michael Moss <mmoss@chromium.org>
TBR=iannucci@chromium.org,mmoss@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org
Change-Id: I51e502e6f7633a6f26898f1ecbcd86ccf9c7c123
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1718996
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
6 years ago
Edward Lemur
3a98df0bdd
depot_tools: Move six to depot_tools' .vpython
...
Bug: 984182
Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
6 years ago
Raul Tambre
80ee78e7fa
Convert print statements to Python 3 style
...
Ran "2to3 -w -n -f print ./" and manually added imports.
Ran "^\s*print " and "\s+print " to find batch/shell scripts, comments and the like with embedded code, and updated them manually.
Also manually added imports to files, which used print as a function, but were missing the import.
The scripts still work with Python 2.
There are no intended behaviour changes.
Bug: 942522
Change-Id: Id777e4d4df4adcdfdab1b18bde89f235ef491b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595684
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
6 years ago
Robert Iannucci
5d6b00fac6
[cit] Use subprocess2 to properly sink stdout.
...
This should fix the "halts mid-way" symptoms observed on linux.
R=agable@chromium.org, hinoka@chromium.org
Bug: 782543
Change-Id: Ia5254b7f8e73b5646f2782e36acc52b4772b095e
Reviewed-on: https://chromium-review.googlesource.com/865821
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
7 years ago
Ryan Tseng
de1ed19dc2
cit.py: Use infra.git's cit branch instead of the deployed branch
...
So that we can roll the cit.py pin without breaking other services.
BUG=
Change-Id: I5992d753d8ddf23c29f1ef6c09866a86c7f7c2ae
Reviewed-on: https://chromium-review.googlesource.com/450760
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
8 years ago
dsansome
72decfedaa
If cit is run with an unknown tool, print usage rather than throwing an exception
...
BUG=
TBR=hinoka
Review-Url: https://codereview.chromium.org/2181413004
9 years ago
hinoka
9a0de0b9f1
Add cipd binary support to cit.py
...
BUG=
Review-Url: https://codereview.chromium.org/2117943002
9 years ago
tandrii
56396af3e5
cit: print to stderr to allow piping from cit log cat.
...
R=hinoka@chromium.org,stip@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2062053002
9 years ago
dsansome@chromium.org
0878b053b1
Sort the list of tools shown by cit.py's help message
...
(it looks nicer)
BUG=
Review URL: https://codereview.chromium.org/1682293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298842 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
mmoss@chromium.org
c349971db4
Fix some path processing to work better on Windows.
...
R=hinoka@chromium.org
BUG=555036
Review URL: https://codereview.chromium.org/1471973004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297698 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
iannucci@chromium.org
3add4b62b8
Fix cit.py when ~/.chrome-infra exists but does not have infra.
...
R=hinoka@chromium.org, stip@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1457563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297583 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
dnj@chromium.org
8829c52f4c
cit: Add ability to select infra branch.
...
TBR=hinoka@chromium.org
BUG=None
TEST=local
- Ran with different branches, seems to work.
R=hinoka@chromium.org
Review URL: https://codereview.chromium.org/1414223003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297284 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
hinoka@chromium.org
d61f1556bb
cit.py fix
...
gclient should be checking out origin/deployed, not deployed.
--revision deployed is local, origin/deployed actually causes it to fetch
BUG=
Review URL: https://codereview.chromium.org/1236133005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296055 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
hinoka@chromium.org
bdc4728fb1
Added tool to call tools in infra.git
...
Example usage: yo cq_stats --help
BUG=
R=stip@chromium.org
Review URL: https://codereview.chromium.org/1232573007 .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296053 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago