Blink wants to override the maxlen which is currently configurable in CheckLongLines but not in PanProjectChecks. This exposes the parameter on PanProjectChecks.
Review URL: https://chromiumcodereview.appspot.com/13403004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192394 0039d316-1c4b-4281-b951-d872f2087c98
This reverts commit 6a2e4710bf.
cmp says:
This CL causes NewGit and Git submodules workflows to comingle in ways that result in bad and unexpected failures for new and existing users. One failure is for the new Blink developers who need to use git-svn with their WebKit third_party checkout. Another failure is in the Windows NewGit workflow where gclient sync takes longer than necessary to complete.
The right approach at this point given the costs of this change is to revert it and rethink the best way to get projects the functionality they need while restoring the functionality existing projects have required for over a year now.
Please discuss the recursive/recurseSubmodules code face-to-face with cmp@google.com before attempting to make this live again. Thanks.
R=cmp@chromium.org
BUG=224074
Review URL: https://chromiumcodereview.appspot.com/13470027
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192236 0039d316-1c4b-4281-b951-d872f2087c98
Currently the NewGit workflow sets up git submodules to point to a
.git dir through a textfile indirection. git-svn isn't smart enough to
deal with this, and so we need to change things to use symlinks instead.
In the meantime, 'fetch blink' will fail. For now, we'll turn off
the svn configuration.
TBR=iannucci@chromium.org
BUG=
Review URL: https://codereview.chromium.org/13560005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192230 0039d316-1c4b-4281-b951-d872f2087c98
This is done as a hack since we don't really have real option parsing :(.
R=iannucci@chromium.org, agable@chromium.org, maruel@chromium.org
Review URL: https://codereview.chromium.org/13586004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192154 0039d316-1c4b-4281-b951-d872f2087c98
This is the bare minimum to have fetch.py working for chromium.
The DEPS file pulls the new tools/recipes repo in, which will contain
the recipe for chromium and all other checkout recipes eventually (followup
CL coming shortly). fetch and fetch.bat simply invoke fetch.py. fetch.py
takes a recipe and some arguments on the command line, invokes the recipe
to get its instructions, and performs the actual checkout.
Currently only supports Gclient-Git-Svn checkout (the kind needed for
Chromium), but other checkout types will be pulled from annotated_checkout.py
soon.
Review URL: https://codereview.chromium.org/13463006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192130 0039d316-1c4b-4281-b951-d872f2087c98
PresubmitPromptOrNotify prints the message and prompts the user only
if the presubmit is on upload, not commit.
This is useful to provide upload-time sanity checks without blocking
the CL from being landed via the commit-queue.
Review URL: https://chromiumcodereview.appspot.com/12676031
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@190711 0039d316-1c4b-4281-b951-d872f2087c98
to rietveld for the first time. This came up in a discussion with Nico about
changing -m for -t in the git cl upload command.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12965015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@190399 0039d316-1c4b-4281-b951-d872f2087c98
- Check for -h|--help before anything is modified.
- Discard stderr from 'git submodule update'.
- Be careful not to overwrite script while it's executing
on win.
- Run hooks by invoking 'git runhooks'.
- Fix --dry-run option.
R=iannucci@chromium.org
CC=jar@chromium.org,scottmg@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/12865010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189926 0039d316-1c4b-4281-b951-d872f2087c98
grdp is the file that included to grd files.
Review URL: https://chromiumcodereview.appspot.com/12609012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189571 0039d316-1c4b-4281-b951-d872f2087c98
Windows will sometimes freak out if a file is rewritten while
it's being executed. That can happen when update_depot_tools.bat
runs.
R=iannucci@chromium.org,maruel@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12755033
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189429 0039d316-1c4b-4281-b951-d872f2087c98
svn commit likes to hang indefinitely whenever the svnserve server forgets
about the client. This changes ensures the commit queue won't be blocked by
this problem.
R=maruel@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/12440058
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189382 0039d316-1c4b-4281-b951-d872f2087c98
This causes the 'git config' to only add or update the branch-heads fetch
entry, and not replace any other existing entry (e.g. refs/heads/*).
Review URL: https://chromiumcodereview.appspot.com/12634013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@189326 0039d316-1c4b-4281-b951-d872f2087c98
* Use base chrome svn url for reverts to work with
branches and tools repos.
* Add heuristic to drover so it can search multiple
svn repos for the likely revision to revert.
Each of chrome, chrome-internal, native_client are separated by
more than 20k revisions, so we can programmatically determine
which repo the user wants to revert with high confidence.
TESTS=
- pylint (part of presubmit)
- tried recent tools/build chrome revision
- tried NaCl revision
- tried NaCl revision with --no-alt-urls (got rev from chrome)
- tried NaCl without valid svn credentials (got rev from chrome)
Review URL: https://chromiumcodereview.appspot.com/12670008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@188792 0039d316-1c4b-4281-b951-d872f2087c98
This suite is very slow (26s), while the rest of the test suites
are fast.. Since subprocess2 is a relatively static module,
blacklist the suite for upload.
Review URL: https://chromiumcodereview.appspot.com/12544027
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@188657 0039d316-1c4b-4281-b951-d872f2087c98
continuation of: https://codereview.chromium.org/11664024
Moved it from chrome/trunk/src/build to depot_tools/
BUG=153360
TEST=two unittests included in tests/
For end-to-end testing, check out a large directory. Run
find . -name .svn -prune -o -size +1000k -type f -print0 | upload_to_google_storage.py -b chrome-artifacts -0 -
(replacing chrome-artifacts with an upload-able bucket)
to test upload
run "find . -name .svn -prune -o -size +1000k -type f -print0 | xargs -0 rm" to remove the files uploaded. Check that the large binary files have been removed
run "download_from_google_storage.py -r -d -b chrome-artifacts ." to download the files again.
Review URL: https://chromiumcodereview.appspot.com/12042069
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@187951 0039d316-1c4b-4281-b951-d872f2087c98
This adds a comma-separated list of reviewers to the optional outputs
for changes. This can be added to the output using the custom formatter
option. E.g. --output-format-changes="{url} {title} <{reviewers}>"
Also, for webkit changes, use CommitterList to map reviewer names to
emails so that they are similar format to other changes.
Review URL: https://chromiumcodereview.appspot.com/12446008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@187351 0039d316-1c4b-4281-b951-d872f2087c98
Put a blank line in between drover title and message.
Also include snippet of commit title in drover title,
but keep total title line length below 50 chars.
Review URL: https://chromiumcodereview.appspot.com/12656003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@187329 0039d316-1c4b-4281-b951-d872f2087c98
Some versions of git don't support 'clone --config'.
Review URL: https://codereview.chromium.org/12688005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@187296 0039d316-1c4b-4281-b951-d872f2087c98
Some SVN-only trybots get errors when running gclient revert with this
change. I assume it's because the flag is not present for the gclient
revert command, and that the code checking if options.with_branch_heads
is set is common to both revert and sync.
BUG=none
TEST=reverted locally and gclient revert worked again.
Review URL: https://chromiumcodereview.appspot.com/12616006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186967 0039d316-1c4b-4281-b951-d872f2087c98
This will replace the hack in commit-queue/verification/presubmit_shim, and will
be used on the presubmit trybot.
R=maruel@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12481002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186922 0039d316-1c4b-4281-b951-d872f2087c98
The "branch-heads" are refspecs created from upstream svn branches. This flag
is mostly needed for official builders, and adds about 1/2GB of data to the
checkout, so not currently enabling by default.
Review URL: https://codereview.chromium.org/12546017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186598 0039d316-1c4b-4281-b951-d872f2087c98
If we uploaded a CL w/o any reviewers specified, and then
ran the owners check on it (so that we had a Rietveld
issue number) we would crash in a Python assertion. This
wasn't caught in unit testing because of a limitation
in the unit test scaffolding.
TBR=maruel@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12546003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186454 0039d316-1c4b-4281-b951-d872f2087c98
Until an issue is uploaded to Rietveld, we don't know the official
email address to use for an owners check. There are three ways to fix
this: we could attempt to log in to rietveld prior to doing the check
and extract the address to use, or we could use ~/.last_codereview_email_address,
or we can use the email address we can determine from the checkout.
All three options have flaws; the first is particularly awkward since there
doesn't seem to be a good way to fetch the email without posting an issue.
The second is flawed if we use different addresses for different repos,
and the third is flawed if the checkout's email address is different from
the rietveld address, or if it is anonymous.
However, since this is only being used for owners checks (in this case),
anonymous checkouts probably don't matter, and hopefully the cases where
the email addresses differ are rare.
R=maruel@chromium.org
BUG=118388, 150049
Review URL: https://chromiumcodereview.appspot.com/12377023
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186259 0039d316-1c4b-4281-b951-d872f2087c98
Move watchlist generation out of RunHooks so that bypass-hooks
does not skip watchlists.
BUG=163406
Review URL: https://chromiumcodereview.appspot.com/12295004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@185979 0039d316-1c4b-4281-b951-d872f2087c98
jamesr@chromium.org
dpranke@chromium.org
iannucci@chromium.org
agable@chromium.org
dmikurube@chromium.org
koz@chromium.org
wez@chromium.org
rogerta@chromium.org
szager@chromium.org
dzhioev@chromium.org
csharp@chromium.org
mmoss@chromium.org
jam@chromium.org
hinoka@google.com
ilevy@chromium.org
cjhopman@chromium.org
jochen@chromium.org
maruel@chromium.org
kjellander@chromium.org
sbc@chromium.org