Commit Graph

9 Commits (26bc518eaef421d8ef3cadb1be19c1255d5b51ea)

Author SHA1 Message Date
Gavin Mak 326546b771 Add PYTHON_VERSION_COMPATIBILITY to presubmit recipe module
Bug: 1227140
Change-Id: Ie11384422ef3a01fe6bc02d335a3525aeb91e7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3123952
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
4 years ago
Saagar Sanghavi 0fa91d0f35 ResultDB wrapping for CQ/CI builds.
Add ('rdb', 'stream', '--') to wrapper.
Uses -- to send args to subprocess. (This was the bug with original CL)

Note - to test this, we will have to push changes and revert
immediately if we notice any breakage.

Recipe-Nontrivial-Roll: build
Change-Id: Ibe46314c2f791a99c0e670ff6cc44f6f24fb9f70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2342254
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
5 years ago
Ben Pastene fb9c1110ef Revert "ResultDB reporting for bot-triggered builds"
This reverts commit bd65053490.

Reason for revert: "flag provided but not defined: -u"
https://crbug.com/1113350

Original change's description:
> ResultDB reporting for bot-triggered builds
> 
> Recipe-Nontrivial-Roll: build
> Change-Id: Id062a66c8a37aeedc85eaa16b1aa1eea4304f5c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2330655
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>

TBR=nodir@chromium.org,estaab@chromium.org,ehmaldonado@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,saagarsanghavi@google.com

Bug: 1113350
Change-Id: I2c496d6c170a2ffb9226c5bb201d467f5847de6a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2340035
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
5 years ago
Saagar Sanghavi bd65053490 ResultDB reporting for bot-triggered builds
Recipe-Nontrivial-Roll: build
Change-Id: Id062a66c8a37aeedc85eaa16b1aa1eea4304f5c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2330655
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
5 years ago
John Budorick f21ffb4f98 Copy presubmit logic up into the presubmit recipe module.
Bug: 925774
Change-Id: I27e8670578095db71384d77cdb3d606bfdcf1077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1684760
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
6 years ago
Debrian Figueroa dd2737e2b5 Augment presubmit_support to output a json summary.
Adds functionality to presubmit api to return error,
notification and warning messages caught in
presubmit_support.py in the form of a json.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug:971895
Change-Id: I42a3df3994077342216d002381b6135012b4334c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1666250
Commit-Queue: Debrian Figueroa <debrian@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
6 years ago
John Budorick 3b1e64245a presubmit: use depot_tools.on_path rather than a handrolled equivalent.
Noticed this while attempting to debug issues with the
src-internal-presubmit builder. Not sure if this is the cause but
would like to at least rule it out.

Bug: 925774
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
Change-Id: I323f49e23d2c8af11b374e22ebfbcf5bcd836ba3
Reviewed-on: https://chromium-review.googlesource.com/c/1464049
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
Robert Iannucci 5702f0baef [recipes] convert all recipe_modules to use new context module.
R=recipe-roller@chromium.org

Bug:
Change-Id: I84c19965b779f1010c00cd8c857b7533eec7413f
Reviewed-on: https://chromium-review.googlesource.com/502929
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Paweł Hajdan, Jr f14709556d Move recipes to their own subdirectory
This will help remove confusion when depot_tools' recipes.py
ends up in PATH.

BUG=699120

Change-Id: Id4c21b0cc6bb022ea2c21145abe76bebb0a8d9c1
Reviewed-on: https://chromium-review.googlesource.com/458430
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago