7da798be10
infra_paths: do nothing if path_config is not specified
...
Currently if path_config is not specified, infra_paths
defaults to buildbot paths. We want to make this behavior explicit,
so we don't have to introduce a new "luci" path configuration which
tells infra_paths module to do nothing.
Buildbot now specifies path_config=buildbot since
https://chromium-review.googlesource.com/c/412029/ ,
so now we can remove this default.
This also affects all expectation files because this CL switches
the default path configuration from Buildbot to LUCI.
In particular, it changes default git cache dir from [GIT_CACHE]
to [CACHE]/git.
Also code paths that work only in Buildbot environment has to
have a test with path_config=buildbot.
R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586
Change-Id: Ifeabe13e69810dd24a6deb4830699f8c9fafafae
Reviewed-on: https://chromium-review.googlesource.com/411989
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
9 years ago
fbf01c5431
remove slave_build path
...
slave_build path, defined by infra_paths module, is unnecessarily tied
to our buildbot setup which we are trying to deprecate in favor of LUCI.
In practice it is always == start_dir and that's what we want in LUCI too.
Update all code that uses slave_build path to use start_dir instead.
R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586
Change-Id: Id52aa535d6a4f52670d581bf56aab65f670b1861
Reviewed-on: https://chromium-review.googlesource.com/412075
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
9 years ago
bef52ff000
git recipe_module: git new-branch.
...
R=iannucci@chromium.org,qyearsley@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2369073002
9 years ago
2cbf79f3c9
git: use new python script to bootstrap git on windows
...
BUG=635421, 629679
Recipe-Tryjob-Bypass-Reason: downstream changes expected
Review-Url: https://codereview.chromium.org/2264583002
9 years ago
d755329820
git: fix git cache support
...
It's now based on bot_update logic.
BUG=630601
Review-Url: https://codereview.chromium.org/2209383002
9 years ago
9d5696da80
Make git recipe api add depot_tools to PATH
...
"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.
BUG=
Recipe-Tryjob-Bypass-Reason: Expectations known to change
Review-Url: https://codereview.chromium.org/2192163002
9 years ago
dc24ee1a99
git recipe_module: add experimental git-cache support.
...
BUG=630601
R=phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2173823002
9 years ago
6a33f25283
git: apply a 5 minutes timeout to "ensure git tooling on windows" step
...
This covers 99% of successful runs on all builders based on event_mon
data.
BUG=629025
Review-Url: https://codereview.chromium.org/2162143004
9 years ago
b2580abf45
Manually roll recipes.cfg recipe_engine 2c5509f:9d78ba3
...
TBR=estaab, iannucci, martiniss
BUG=chromium:593999
Review-Url: https://codereview.chromium.org/2132363002
9 years ago
b770809308
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/d9039313202dfb6adaf890674abdd8ee6aec940d recipe engine: remove explicit cwd default in step recipe module (phajdan.jr@chromium.org )
R=phajdan.jr@chromium.org
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1926633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300229 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
25837199f3
Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
...
Hopefully everything will be back to normal now...
Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
>
> Depends on https://codereview.chromium.org/1906323003
>
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
TBR=iannucci@chromium.org,hinoka@chromium.org,phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1915033006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300210 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
3407a99675
Roll recipe_engine to 2f86f02a302172514bf282684e0a4aa18b683e41
...
TBR=phajdan.jr
BUG=606708
Review URL: https://codereview.chromium.org/1921893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300206 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
d34c90601f
Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
...
Reason for revert:
re-landing because wrong order of reverts :(
Original issue's description:
> Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
>
> Reason for revert:
> breaks skia bots :(
>
> Original issue's description:
> > depot_tools: add infra_paths recipe module for infra-specific paths
> >
> > Depends on https://codereview.chromium.org/1906323003
> >
> > BUG=chromium:605919
> >
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
>
> TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300199
TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1921373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300200 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
54e0d26399
Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
...
Reason for revert:
breaks skia bots :(
Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
>
> Depends on https://codereview.chromium.org/1906323003
>
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1917263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300199 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
f30e872853
depot_tools: add infra_paths recipe module for infra-specific paths
...
Depends on https://codereview.chromium.org/1906323003
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1915463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300184 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
88e173be1a
depot_tools: adjust for resource API changes in recipe engine
...
This is rolling in https://codereview.chromium.org/1777003003
BUG=593420
Review URL: https://codereview.chromium.org/1785443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299187 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
5c2f2a6768
Fix recipe module git to use package_resouce.
...
TBR=phajdan.jr@chromium.org,martiniss@chromium.org
BUG=590806
Review URL: https://codereview.chromium.org/1751003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299027 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
e8f4da09ba
Revert of Fix git recipe module to use git.bad as package resouce. (patchset #1 id:1 of https://codereview.chromium.org/1742403002/ )
...
Reason for revert:
broke win builder bug 590806
Original issue's description:
> Fix git recipe module to use git.bad as package resouce.
>
> R=phajdan.jr@chromium.org
> BUG=579160
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299005
TBR=phajdan.jr@chromium.org,tandrii@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579160
Review URL: https://codereview.chromium.org/1750733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299011 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
575d41a4f1
Fix git recipe module to use git.bad as package resouce.
...
R=phajdan.jr@chromium.org
BUG=579160
Review URL: https://codereview.chromium.org/1742403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299005 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
846218da18
Make git.checkout return the commit hash.
...
R=dnj@chromium.org, hinoka@chromium.org, luqui@chromium.org, martiniss@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1693993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298774 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
8a602a63df
Roll recipe dependencies (nontrivial).
...
recipe_engine -> 44b384f9b4f1085e9cfe43ea6308735a3af8d4e5: RELAND of Make the recipe engine allow modules named the same thing to co-exist.
R=martiniss@chromium.org,luqui@chromium.org
TBR=iannucci@chromium.org
BUG=582280
Review URL: https://codereview.chromium.org/1660163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298530 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
4c3969479a
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1 )
...
Previous attempt: https://codereview.chromium.org/1642023002
TBR=martiniss
BUG=582074
Review URL: https://codereview.chromium.org/1651033004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
f77c42a6a3
Revert of depot_tools: import bot_update gclient git rietveld tryserver recipe modules (patchset #6 id:100001 of https://codereview.chromium.org/1642023002/ )
...
Reason for revert:
breakages: https://code.google.com/p/chromium/issues/detail?id=582229
Original issue's description:
> depot_tools: import bot_update gclient git rietveld tryserver recipe modules
>
> BUG=582074
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298447
TBR=maruel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582074, 582229
Review URL: https://codereview.chromium.org/1644173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298457 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
29689c6822
depot_tools: import bot_update gclient git rietveld tryserver recipe modules
...
BUG=582074
Review URL: https://codereview.chromium.org/1642023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298447 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
Nodir Turakulov
tandrii
phajdan.jr
borenet
recipe-roller@chromium.org
martiniss@chromium.org
iannucci@chromium.org