aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
8,109 Commits
6 Branches
0 Tags
183 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '1e982d5727'
${ noResults }
Commit Graph

13 Commits (1e982d5727bb51c8da2da13e5aeec02fd0b94632)

Author SHA1 Message Date
Bruce Dawson a806594b95 Reland "Reland "use python3 for goma related scripts"" 
This reverts commit fc3fb20e51.

Reason for revert: Previous versions of this changed used %scriptdir% in
goma_ctl.bat and goma_auth.bat but never defined it. This eluded manual
testing because these scripts would work properly as long as they were
run from the depot_tools directory, but would fail when run from
elsewhere.

The fix to make this reland work can be found by comparing patchset 1 to
patchset 3.

Original change's description:
> Revert "Reland "use python3 for goma related scripts""
>
> This reverts commit 2a6dffaf4b.
>
> Reason for revert: with this change in depot_tools when I run "goma_ctl ensure_start" from cmd.exe I get
> "The system cannot find the path specified."
>
> Original change's description:
> > Reland "use python3 for goma related scripts"
> >
> > This reverts commit 59140d436a.
> >
> > Reason for revert:
> > Make this works in git bash.
> >
> > Original change's description:
> > > Revert "use python3 for goma related scripts"
> > >
> > > This reverts commit 138ec7c56d.
> > >
> > > Reason for revert:
> > > This might have caused the following issue:
> > > https://bugs.chromium.org/p/chromium/issues/detail?id=1221233
> > >
> > > Original change's description:
> > > > use python3 for goma related scripts
> > > >
> > > > This uses python3 like autoninja{,.bat}.
> > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
> > > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
> > > >
> > > > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
> > > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> > > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > >
> > > Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
> > > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> >
> > Bug: 1221233
> > Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
>
> Bug: 1221233
> Change-Id: I5050b9199f3076e6d6f812b8bac01e8cd1dc53bf
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992150
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

Bug: 1221233
Change-Id: I50412a5ea62f1607660cb7a7ab8851251c3dfe91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992151
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 4 years ago
Bruce Dawson fc3fb20e51 Revert "Reland "use python3 for goma related scripts"" 
This reverts commit 2a6dffaf4b.

Reason for revert: with this change in depot_tools when I run "goma_ctl ensure_start" from cmd.exe I get
"The system cannot find the path specified."

Original change's description:
> Reland "use python3 for goma related scripts"
>
> This reverts commit 59140d436a.
>
> Reason for revert:
> Make this works in git bash.
>
> Original change's description:
> > Revert "use python3 for goma related scripts"
> >
> > This reverts commit 138ec7c56d.
> >
> > Reason for revert:
> > This might have caused the following issue:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=1221233
> >
> > Original change's description:
> > > use python3 for goma related scripts
> > >
> > > This uses python3 like autoninja{,.bat}.
> > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
> > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
> > >
> > > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> >
> > Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
> > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
>
> Bug: 1221233
> Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

Bug: 1221233
Change-Id: I5050b9199f3076e6d6f812b8bac01e8cd1dc53bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992150
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 4 years ago
Takuto Ikuta 2a6dffaf4b Reland "use python3 for goma related scripts" 
This reverts commit 59140d436a.

Reason for revert:
Make this works in git bash.

Original change's description:
> Revert "use python3 for goma related scripts"
>
> This reverts commit 138ec7c56d.
>
> Reason for revert:
> This might have caused the following issue:
> https://bugs.chromium.org/p/chromium/issues/detail?id=1221233
>
> Original change's description:
> > use python3 for goma related scripts
> >
> > This uses python3 like autoninja{,.bat}.
> > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
> > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
> >
> > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
>
> Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Bug: 1221233
Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 4 years ago
Yoshisato Yanagisawa 59140d436a Revert "use python3 for goma related scripts" 
This reverts commit 138ec7c56d.

Reason for revert:
This might have caused the following issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=1221233

Original change's description:
> use python3 for goma related scripts
>
> This uses python3 like autoninja{,.bat}.
> https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
> https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
>
> Fixed: 1203012
> Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 4 years ago
Takuto Ikuta 138ec7c56d use python3 for goma related scripts 
This uses python3 like autoninja{,.bat}.
https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat

Fixed: 1203012
Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 4 years ago
Nodir Turakulov 47a4b0bc59 Add revert instructions 
Add revert instructions to .bat and bash files which are the entry
points to various infra tools deployed via CIPD.

Bug: 1206818
Change-Id: Ib0045aea86f29d0f7e3a43c6ff314c4b7aa74171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2892387
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 4 years ago
Allen Bauer 845b830530 Fixed goma_ctl.bat to pipe to nul instead of creating a file called null. 
Bug: 1066954
Change-Id: Icdf68547f94376616a21997c37cf51cd38659c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2132954
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
 5 years ago
Robert Iannucci 8b34eb4d1e [goma_ctl] Use vpython to call goma_ctl.py. 
goma_ctl.py recommends that folks run `pip install pywin32`, which will
work up until python in depot_tools is updated, at which point it will
break again.

Running with vpython means that the vpython spec which ships with goma
will correctly take effect.

R=brucedawson@chromium.org, tikuta@chromium.org

Bug: 1033106
Change-Id: Icafadf381df782ab30d6cc156419dd7ed424d2bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1962721
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 5 years ago
Fumitoshi Ukai 27bd4e420d Reland "put goma client in depot_tools" 
This reverts commit a0aed87f71.

Reason for revert: install goma client without update_hook

update_hook would disrupt current users, so start without update_hook,
which means goma cient in depot_tools user might need to
restart compiler_proxy manually when updated.
 https://docs.google.com/document/d/1pnwfkU6Rd9dRtQC0sg2vATmyRbkYWhnNUTD5k1PddC0/edit#

Original change's description:
> Revert "put goma client in depot_tools"
>
> This reverts commit 7778035801.
>
> Reason for revert: AttributeError: 'GomaEnvPosix' object has no attribute 'RestartCompilerProxy'
>
> Original change's description:
> > put goma client in depot_tools
> >
> > install goma client cipd package in depot_tools.
> >
> > should not use $MYPATH/goma_ctl in cipd_bin_setup
> > since $MYPATH/goma_ctl uses cipd_bin_setup in itself,
> > so causing recursive calls.
> > invoke python to run .cipd/goma_ctl.py in cipd_bin_setup
> > instead.
> >
> > Bug: b/77663154
> > Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350
> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
>
> TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com
>
> Change-Id: Ie050dfb524dd885634c31be829d733613e80aece
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: b/77663154
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1872129
> Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com


Bug: b/77663154
Change-Id: I8bb51631e4418ff63953099814bdb464128eb279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1875982
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 5 years ago
Fumitoshi Ukai a0aed87f71 Revert "put goma client in depot_tools" 
This reverts commit 7778035801.

Reason for revert: AttributeError: 'GomaEnvPosix' object has no attribute 'RestartCompilerProxy'

Original change's description:
> put goma client in depot_tools
> 
> install goma client cipd package in depot_tools.
> 
> should not use $MYPATH/goma_ctl in cipd_bin_setup
> since $MYPATH/goma_ctl uses cipd_bin_setup in itself,
> so causing recursive calls.
> invoke python to run .cipd/goma_ctl.py in cipd_bin_setup
> instead.
> 
> Bug: b/77663154
> Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com

Change-Id: Ie050dfb524dd885634c31be829d733613e80aece
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/77663154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1872129
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 5 years ago
Fumitoshi Ukai 7778035801 put goma client in depot_tools 
install goma client cipd package in depot_tools.

should not use $MYPATH/goma_ctl in cipd_bin_setup
since $MYPATH/goma_ctl uses cipd_bin_setup in itself,
so causing recursive calls.
invoke python to run .cipd/goma_ctl.py in cipd_bin_setup
instead.

Bug: b/77663154
Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 5 years ago
Fumitoshi Ukai 8076771cb1 Revert "put goma client in depot_tools" 
This reverts commit 6e48505301.

Reason for revert: cause recursive calls of update_hook

  |   \_ bash /usr/local/google/home/ukai/depot_tools/gclient sync
ukai      29514  0.0  0.0  16104  3648 pts/10   S+   14:40   0:00  |
   |       \_ bash /usr/local/google/home/ukai/depot_tools/update_depot_tools sync
ukai      29586  0.0  0.0  15972  3276 pts/10   S+   14:40   0:00  |
   |           \_ bash /usr/local/google/home/ukai/depot_tools/goma_ctl update_hook
ukai      29614  0.0  0.0  15972  3192 pts/10   S+   14:40   0:00  |
   |               \_ bash /usr/local/google/home/ukai/depot_tools/goma_ctl update_hook

Original change's description:
> put goma client in depot_tools
> 
> install goma client cipd package in depot_tools.
> 
> Bug: b/77663154
> Change-Id: Ibcfc42b9b7705bcf71b4ba2e834b4ebf09ad25fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1846892
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,tikuta@chromium.org,ehmaldonado@chromium.org,apolito@google.com

Change-Id: I644799c06f74a436b201c4c6c3de44af30c51556
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/77663154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866349
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 5 years ago
Fumitoshi Ukai 6e48505301 put goma client in depot_tools 
install goma client cipd package in depot_tools.

Bug: b/77663154
Change-Id: Ibcfc42b9b7705bcf71b4ba2e834b4ebf09ad25fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1846892
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 5 years ago