aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
7,446 Commits
6 Branches
0 Tags
210 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '19512276d2'
${ noResults }
Commit Graph

6 Commits (19512276d2c5680cd458c9a7e2b4034611ca6f96)

Author SHA1 Message Date
Robert Iannucci 8b34eb4d1e [goma_ctl] Use vpython to call goma_ctl.py. 
goma_ctl.py recommends that folks run `pip install pywin32`, which will
work up until python in depot_tools is updated, at which point it will
break again.

Running with vpython means that the vpython spec which ships with goma
will correctly take effect.

R=brucedawson@chromium.org, tikuta@chromium.org

Bug: 1033106
Change-Id: Icafadf381df782ab30d6cc156419dd7ed424d2bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1962721
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 6 years ago
Fumitoshi Ukai 27bd4e420d Reland "put goma client in depot_tools" 
This reverts commit a0aed87f71.

Reason for revert: install goma client without update_hook

update_hook would disrupt current users, so start without update_hook,
which means goma cient in depot_tools user might need to
restart compiler_proxy manually when updated.
 https://docs.google.com/document/d/1pnwfkU6Rd9dRtQC0sg2vATmyRbkYWhnNUTD5k1PddC0/edit#

Original change's description:
> Revert "put goma client in depot_tools"
>
> This reverts commit 7778035801.
>
> Reason for revert: AttributeError: 'GomaEnvPosix' object has no attribute 'RestartCompilerProxy'
>
> Original change's description:
> > put goma client in depot_tools
> >
> > install goma client cipd package in depot_tools.
> >
> > should not use $MYPATH/goma_ctl in cipd_bin_setup
> > since $MYPATH/goma_ctl uses cipd_bin_setup in itself,
> > so causing recursive calls.
> > invoke python to run .cipd/goma_ctl.py in cipd_bin_setup
> > instead.
> >
> > Bug: b/77663154
> > Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350
> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
>
> TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com
>
> Change-Id: Ie050dfb524dd885634c31be829d733613e80aece
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: b/77663154
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1872129
> Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com


Bug: b/77663154
Change-Id: I8bb51631e4418ff63953099814bdb464128eb279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1875982
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 6 years ago
Fumitoshi Ukai a0aed87f71 Revert "put goma client in depot_tools" 
This reverts commit 7778035801.

Reason for revert: AttributeError: 'GomaEnvPosix' object has no attribute 'RestartCompilerProxy'

Original change's description:
> put goma client in depot_tools
> 
> install goma client cipd package in depot_tools.
> 
> should not use $MYPATH/goma_ctl in cipd_bin_setup
> since $MYPATH/goma_ctl uses cipd_bin_setup in itself,
> so causing recursive calls.
> invoke python to run .cipd/goma_ctl.py in cipd_bin_setup
> instead.
> 
> Bug: b/77663154
> Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com

Change-Id: Ie050dfb524dd885634c31be829d733613e80aece
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/77663154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1872129
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 6 years ago
Fumitoshi Ukai 7778035801 put goma client in depot_tools 
install goma client cipd package in depot_tools.

should not use $MYPATH/goma_ctl in cipd_bin_setup
since $MYPATH/goma_ctl uses cipd_bin_setup in itself,
so causing recursive calls.
invoke python to run .cipd/goma_ctl.py in cipd_bin_setup
instead.

Bug: b/77663154
Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 6 years ago
Fumitoshi Ukai 8076771cb1 Revert "put goma client in depot_tools" 
This reverts commit 6e48505301.

Reason for revert: cause recursive calls of update_hook

  |   \_ bash /usr/local/google/home/ukai/depot_tools/gclient sync
ukai      29514  0.0  0.0  16104  3648 pts/10   S+   14:40   0:00  |
   |       \_ bash /usr/local/google/home/ukai/depot_tools/update_depot_tools sync
ukai      29586  0.0  0.0  15972  3276 pts/10   S+   14:40   0:00  |
   |           \_ bash /usr/local/google/home/ukai/depot_tools/goma_ctl update_hook
ukai      29614  0.0  0.0  15972  3192 pts/10   S+   14:40   0:00  |
   |               \_ bash /usr/local/google/home/ukai/depot_tools/goma_ctl update_hook

Original change's description:
> put goma client in depot_tools
> 
> install goma client cipd package in depot_tools.
> 
> Bug: b/77663154
> Change-Id: Ibcfc42b9b7705bcf71b4ba2e834b4ebf09ad25fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1846892
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,tikuta@chromium.org,ehmaldonado@chromium.org,apolito@google.com

Change-Id: I644799c06f74a436b201c4c6c3de44af30c51556
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/77663154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866349
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 6 years ago
Fumitoshi Ukai 6e48505301 put goma client in depot_tools 
install goma client cipd package in depot_tools.

Bug: b/77663154
Change-Id: Ibcfc42b9b7705bcf71b4ba2e834b4ebf09ad25fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1846892
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
 6 years ago