Commit Graph

3854 Commits (18df0cdf0b74ebb760debc5ce34e8ef486a9c57c)
 

Author SHA1 Message Date
agable 96ebc1d0e1 Delete roll-dep-svn
R=dnj@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2282223002
9 years ago
tandrii 81665dcf76 Add more debugging in presubmit owners check for Gerrit.
BUG=641384
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2293523002
9 years ago
Paweł Hajdan, Jr 42ffe773c3 win_tools.bat: call git_bootstrap.py, remove deprecated svn bootstrap
BUG=635421, 629679
R=tandrii@chromium.org

Review URL: https://codereview.chromium.org/2286333002 .
9 years ago
tandrii c4344b5958 Fix Gerrit git cl land and add test.
R=andybons@chromium.org
BUG=641127

Review-Url: https://codereview.chromium.org/2280563003
9 years ago
agable 7090f652d1 Remove all references to GIT_MODE from depot_tools
BUG=640251,472386

Review-Url: https://codereview.chromium.org/2286793003
9 years ago
hinoka 0b7cf885e0 Remove Deps2Git references from bot_update.py
BUG=

Review-Url: https://codereview.chromium.org/2283043002
9 years ago
phajdan.jr 5224ece27c git_bootstrap.py: add a switch to control client bitness
BUG=635421, 629679

Review-Url: https://codereview.chromium.org/2280973002
9 years ago
tandrii f8757b7e02 gclient: kill git fetch operation that hangs.
This provides env variable GCLIENT_KILL_GIT_FETCH_AFTER
that kills git fetch if it produces no output for that
many seconds.

Note that this is not final patch, but an experiment.
See http://crbug.com/635641#c24 for the deployment plan.

BUG=635641
R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2241843002
9 years ago
agable 4b21db06e4 Default gclient's GIT_MODE to True
Also contains some other changes (to the example, and to safesync url)
in order for test coverage to remain complete. Will be followed shortly
by a wholesale removal of svn support from the gclient module.

R=iannucci@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2270083004
9 years ago
agable f14eaff814 Remove --base_url from git cl and upload.py
R=tandrii@chromium.org
BUG=638750

Review-Url: https://codereview.chromium.org/2271873003
9 years ago
agable 92bec4f56f Delete gcl, drover, and trychange
These tools are relatively standalone, and only ever worked for SVN.
Removing these is a good start to removing other SVN support code.

R=maruel@chromium.org
BUG=475321

Review-Url: https://codereview.chromium.org/2269413002
9 years ago
qyearsley 12fa6ff69b Run auto-spell-checker (codespell) on files in depot_tools.
This should only change spelling in:
 - messages that are printed
 - comments
 - docstrings

Review-Url: https://codereview.chromium.org/2277513002
9 years ago
qyearsley eab3c04311 Change "tryjob" -> "try job" in git_cl.py and trychange.py.
I know this is an unimportant change, and that across Chromium,
"try job" and "tryjob", and "try bot" and "trybot" are basically
interchangeable, still I think it's nice to have the spelling
consistent within one module.

I prefer the version with a space just because that's what's used
in the documentation:
https://www.chromium.org/developers/testing/try-server-usage

Review-Url: https://codereview.chromium.org/2269283002
9 years ago
recipe-roller b9f5e3796c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/b9c3996241af9c5b0d60c0e7670897ecc3894e46 Fix recipes.py remote on Windows (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:639891,chromium:584079

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2271803003
9 years ago
agable 75e7fc2af1 Just use git refs for lkcr and lkgr
R=iannucci@chromium.org, martiniss@chromium.org
BUG=640251
Recipe-Tryjob-Bypass-Reason: None of the affected recipes need safesync anyway, will manually roll

Review-Url: https://codereview.chromium.org/2268893004
9 years ago
recipe-roller 37ac639b57 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/772978c9b350224f62085c258408a02dcd97986c Remove preloaded 'google' module (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=638824

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2274673002
9 years ago
kmarshall 9249e01b70 git cl archive: Add "--dry-run" and "--notags" flags.
This CL adds a couple flags to "git cl archive".
dry-run: Lists the cleanup tasks, but exits before any changes are
made to Git.
notags: Deletes branches only; does not create archival tags.

R=tandrii@chromium.org,groby@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2276663002
9 years ago
tandrii 33a46ffb3f git cl: workaround against integer overflows of git config.
R=maruel@chromium.org,phajdan.jr@chromium.org
BUG=640115

Review-Url: https://codereview.chromium.org/2272613002
9 years ago
tandrii e594e21959 Add git cl bash completition.
R=maruel@chromium.org,emso@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2269593002
9 years ago
borenet 16b0eb6cb8 roll-dep: Show the git log for catapult
TBR=maruel
BUG=skia:5660

Review-Url: https://codereview.chromium.org/2262283002
9 years ago
recipe-roller 3451b645cc Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6769b4ea18de83ed9676b90a0893417a47be62cc Fix autoroller for gitiles (support commit metadata) (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:584079

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2266003002
9 years ago
phajdan.jr e328cf9c78 git cl issue: add --json switch for machine-readable output
This was requested in https://chromium-review.googlesource.com/c/373499

BUG=none

Review-Url: https://codereview.chromium.org/2263103002
9 years ago
recipe-roller b8f8dd796b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/990f604880743564b4d20029026487d7477c3ed3 fetch: set remote.origin.url to correct value rather than failing (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:584079

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2263093002
9 years ago
rmistry 2250d5b3b0 Add apply_gerrit_ref to bot_update api.
BUG=skia:5627

Review-Url: https://codereview.chromium.org/2249983004
9 years ago
phajdan.jr 2cbf79f3c9 git: use new python script to bootstrap git on windows
BUG=635421, 629679

Recipe-Tryjob-Bypass-Reason: downstream changes expected
Review-Url: https://codereview.chromium.org/2264583002
9 years ago
tandrii df09a46d7c git cl patch: bail out quickly if there is no branch.
This is because later calls to SetIssue() would fail.

R=michaelpg@chromium.org
BUG=611020

Review-Url: https://codereview.chromium.org/2259993002
9 years ago
tandrii 5d48c32f3d git cl: cleanup branch config get/set/unset.
Previously there was a soup with add-hoc formatting with
current branch name, which wasn't always set (see bug 611020).
This CL makes sure all such operations now:
 * properly use types --int and --bool
 * go through the *only* appropriate get/set/unset function.

Furthermore, tests were a mess wrt to raising exceptions when
git processes terminated with an exception. This CL cleaned up,
though I didn't go through all expectations, so some returns of
empty stdout instead of raising CalledProcess error are likely
remaining.

Disclaimer: this CL is not necessarily fixing the referenced bug
below, but it should at least provide better stacktrace when
the bug manifestst itself.

BUG=611020
R=agable@chromium.org

Review-Url: https://codereview.chromium.org/2259043002
9 years ago
phajdan.jr 6d0a5acdc4 Add git_bootstrap.py, which bootstraps git on Windows using CIPD
It's backwards compatible with the logic in win_tools.bat
and is intended to eventually replace it.

BUG=635421, 629679

Review-Url: https://codereview.chromium.org/2254843004
9 years ago
martiniss 439170a2e7 infra/config/recipes.cfg: Add recipe roller as owner
BUG=623207

Review-Url: https://codereview.chromium.org/2236883003
9 years ago
tandrii 4d8955052f git cl: avoid infinite recursion during debug/development.
R=andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2260453002
9 years ago
hinoka 196aa81d8a Remove old unused SVN related scripts from depot_tools
BUG=

Review-Url: https://codereview.chromium.org/2253013004
9 years ago
iannucci e53c935fe7 Add --issue to set-commit and set-close too.
R=phajdan.jr@chromium.org, tandrii@chromium.org, vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2245263007
9 years ago
tandrii 99a72f2514 Gerrit git cl upload: self-lgtm on TBR.
BUG=626364
R=andybons@chromium.org
TEST=manual: https://chromium-review.googlesource.com/#/c/372138

Review-Url: https://codereview.chromium.org/2259583002
9 years ago
iannucci 3c972b9039 Add --issue flag to git cl status.
R=phajdan.jr@chromium.org, vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2250323003
9 years ago
tandrii ea9514aa20 Fix bug in git cl status and add logging.
BUG=629863
R=seanmccullough@chromium.org,andybons@chromium.org

Review-Url: https://codereview.chromium.org/2249303003
9 years ago
tandrii eefe83265b Gerrit git cl upload: auto-filter patchset titles.
Without it, upload fails because ref is invalid.

BUG=622062
R=andybons@chromium.org

Review-Url: https://codereview.chromium.org/2252043002
9 years ago
recipe-roller 54d295468b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6c19ddf62e5c5cdcfda2a2ed55bdb4518f2e0c7a raw_io: fix passing retcode in test_api.stream_output (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=none

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2251983002
9 years ago
tobiasjs ff061c0d1d Do not assume that all presubmit directories still exist.
In the case where a CL deletes the last file in the directory,
it is listed in the presubmit files list, but the directory to
which it refers will not exist, leading to os.listdir failing.

BUG=638343

Review-Url: https://codereview.chromium.org/2250353003
9 years ago
iannucci bd604a16cb Revert of Whitespace change to trigger cipd package for git installer. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2251883002/ )
Reason for revert:
need another build :)

Original issue's description:
> Whitespace change to trigger cipd package for git installer.
>
> TBR=phajdan@chromium.org, vadimsh@chromium.org
> BUG=635421
>
> Committed: 31c2115e6a

TBR=phajdan.jr@chromium.org,vadimsh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635421

Review-Url: https://codereview.chromium.org/2252983002
9 years ago
iannucci 31c2115e6a Whitespace change to trigger cipd package for git installer.
TBR=phajdan@chromium.org, vadimsh@chromium.org
BUG=635421

Review-Url: https://codereview.chromium.org/2251883002
9 years ago
Robert Iannucci ed7d0e3804 Make git version numbers external to batch script.
R=stip@chromium.org, phajdan.jr@chromium.org
BUG=635421

Review URL: https://codereview.chromium.org/2249163005 .
9 years ago
phajdan.jr 40ca0f912a upload recipe bootstrap script (6a4b2e4)
TBR=martiniss

BUG=none

Review-Url: https://codereview.chromium.org/2249943004
9 years ago
phajdan.jr 289d03e1c8 git-cl status: allow querying just the status of current CL
BUG=620494

Review-Url: https://codereview.chromium.org/2252473004
9 years ago
tobiasjs 2836bcf810 Support additional user presubmit scripts named PRESUBMIT*.py.
This allows users to specify additional local presubmit tests that
do not need to exist as locally maintained changes to PRESUBMIT.py
files.

BUG=

Review-Url: https://codereview.chromium.org/2232203002
9 years ago
recipe-roller d090526a27 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f50a2af3c5190b5b9780855085bd5a8df0d4ec58 Add the ability to dump initial recipe properties. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2247133002
9 years ago
iannucci e7f68952a4 Change default codereview instance to one we maintain.
R=agable@chromium.org
BUG=637561

Review-Url: https://codereview.chromium.org/2250573002
9 years ago
iannucci e38699bd95 Fix broken git tests on mac.
Unfortunately there's a bunch of other broken stuff, but it's something :/

R=agable@chromium.org, thakis@chromium.org
BUG=607344

Review-Url: https://codereview.chromium.org/2244023003
9 years ago
tandrii 0c561b329b Cleanup old debugging code.
TBR=phajdan.jr@chromium.org
BUG=537417

Review-Url: https://codereview.chromium.org/2242123003
9 years ago
recipe-roller 00c6a32890 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9581df50945817b006054cc9a4415a38803885a7 Revert of Require internal recipe tryjob (patchset #1 id:1 of https://codereview.chromium.org/2187493005/ ) (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=628801

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2244013002
9 years ago
martiniss 8f8e75bf00 Revert of Require internal recipe tryjob (patchset #1 id:1 of https://codereview.chromium.org/2187073004/ )
Reason for revert:
Waiting until can land all 3 next week.

Original issue's description:
> Require internal recipe tryjob
>
> BUG=628801
>
> Committed: 1dae95a13f

TBR=estaab@chromium.org,nodir@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628801

Review-Url: https://codereview.chromium.org/2238403002
9 years ago