aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,854 Commits
6 Branches
0 Tags
188 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '18df0cdf0b'
${ noResults }
Commit Graph

3854 Commits (18df0cdf0b74ebb760debc5ce34e8ef486a9c57c)
 

Author SHA1 Message Date
qyearsley 5eb0519b4c git cl try: Remove --name option, stop sending "reason" property. 
When triggering the build, there's a field called "reason",
which is currently populated by default with the user's
branch name.

I have a feeling that this is optional and could be completely
omitted.

Andrii notes that if users want to send a "reason" string,
they could send invoke git cl try with the argument -p reason="<reason>".

PSA on infra-dev:
https://groups.google.com/a/chromium.org/d/msg/infra-announce/PXkM1WinTYY/w2IvN5B4AwAJ

BUG=659552

Review-Url: https://codereview.chromium.org/2428383010
 9 years ago
justincohen d74a7b4c14 Call status before reset in gclient sync. 
Calling status before reset will ensure files that have no been changed do not
get deleted by reset --hard.

BUG=642711

Review-Url: https://codereview.chromium.org/2447813003
 9 years ago
agable c3937b9128 Correctly guard file_list modification in gclient update 
TBR=smut@chromium.org
BUG=658959

Review-Url: https://codereview.chromium.org/2448993003
 9 years ago
skobes 2f3f137de7 Continue to the next file after a conflict in apply_patch. 
BUG=658915

Review-Url: https://codereview.chromium.org/2446013002
 9 years ago
tandrii 51a7b096ca bot_update: understand new Gerrit patch properties. 
This change is backwards compatible, so no expectation changes expected
in downstream rolls.

Depends on https://codereview.chromium.org/2442173003 recipe_engine
change.

BUG=645616
R=martiniss@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2439373002
 9 years ago
recipe-roller c1a668d883 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/24a5bf068cee997aec0c60df51ca81bfa5ac5416 Add cleaned up Gerrit props to properties.test_api.tryserver. (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2446133002
 9 years ago
agable c972d189fa Remove SVN support from checkout.py 
R=hinoka@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2398603003
 9 years ago
agable 1a8439a7d9 Clean up gclient sync's construction of the set of modified files 
R=iannucci@chromium.org
BUG=643346

Review-Url: https://codereview.chromium.org/2425253003
 9 years ago
agable 83faed0486 Remove unnecessary rev_str variable from gclient_scm 
Some initial cleanup before larger refactorings.

R=iannucci@chromium.org
BUG=643346

Review-Url: https://codereview.chromium.org/2430523004
 9 years ago
agable 037edb823f Remove SVN support from apply_issue 
R=iannucci@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2394963003
 9 years ago
qyearsley 1fdfcb6316 Refactoring: Extract helper functions from CMDtry in git_cl.py. 
The purpose of this change is to prepare for modifying git cl try
so that builders on multiple masters can be triggered in one invocation
(http://crbug.com/640740).

This should not affect behavior; this CL makes several non-essential
changes to formatting and comments.

Review-Url: https://codereview.chromium.org/2442153002
 9 years ago
nodir 70d11c3759 git_cl: fix GetPreferredTryMasters() feature 
It was broken in https://chromiumcodereview.appspot.com/2419113002

R=borenet@chromium.org
BUG=658317

Review-Url: https://codereview.chromium.org/2442393002
 9 years ago
recipe-roller 66cdab51e1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/19b97eb65b25648c4101c279e30f2aa9d7754844 Refactor expectations of properties recipe_module. (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2448453003
 9 years ago
skobes 6468b9068b Make git cl patch work with binary files. 
BUG=557512

Review-Url: https://codereview.chromium.org/2445543002
 9 years ago
qyearsley 99e2cdf47a Print failure reason when git cl try can't trigger jobs on a CL. 
This is a very little fix.

Review-Url: https://codereview.chromium.org/2441213002
 9 years ago
bradnelson d975b30c20 Automatically CC folks listed in CC= lines. 
Detect CC=<users> lines the way we detect R= and TBR=.
Add these as CC'ed users for rietveld and gerrit.

R=iannucci@chromium.org,hinoka@chromium.org,dnj@chromium.org

Review-Url: https://codereview.chromium.org/2433323004
 9 years ago
agable 41e3a6c553 Remove SVN support from gclient_utils and gclient_scm 
This removes SVN support (most notably the SVNWrapper class, and the git-svn
logic in GitWrapper.GetUsableRev) from gclient_scm. It also removes some
references to SVN from comments in gclient_utils.

R=maruel@chromium.org
BUG=641588

Review-Url: https://chromiumcodereview.appspot.com/2393773003
 9 years ago
hinoka bc0b4c6e41 Change path to internal-try rietveld credentials 
To match where it ended up being located.

BUG=642150

Review-Url: https://chromiumcodereview.appspot.com/2436853002
 9 years ago
recipe-roller d501e8acf6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6e11fcc25f244f962bf750349a805bb3261977ff Remove debugging print. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://chromiumcodereview.appspot.com/2433213002
 9 years ago
recipe-roller 16b03c7394 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9d854c6e7ce9ed004ef0854d0d2c3c5aabcca66f Add Swarming magic environment variables to ENV_WHITELIST (borenet@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://chromiumcodereview.appspot.com/2436773002
 9 years ago
borenet 6c0efe6050 Add -B/--bucket flag to git-cl try 
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2419113002
 9 years ago
tandrii 2a16b95eb1 git cl: refactor direct usage of time.sleep and time.time. 
R=machenbach@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2433813004
 9 years ago
Aaron Gable 6ff1fc0e01 Automatically map urls to their raw appengine forms 
BUG=657216
R=dnj@chromium.org

Review URL: https://codereview.chromium.org/2431893002 .
 9 years ago
Dan Jacques 78de30e1bb Revert "git_cl: Allow server overriding." 
This reverts commit a8fb3a2892.
 9 years ago
Dan Jacques a8fb3a2892 git_cl: Allow server overriding. 
BUG=chromium:657064
TEST=local
  - Ran "git cl status" during outage with override, works.

R=tandrii@chromium.org

Review URL: https://chromiumcodereview-hr.appspot.com/2425673005 .
 9 years ago
sdefresne 69b1be10a4 Fix typo in --manually_grab_svn_rev deprecated flag. 
Chrome on iOS downstream bot still use that flag and they cannot
recover as the flag has been misspelt when resurrected.

TBR=agable@chromium.org
TBR=dnj@chromium.org
BUG=656865

Review-Url: https://codereview.chromium.org/2428893002
 9 years ago
recipe-roller 1c822ade1f Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/bb6caf8060139fd4bcefee43f54ae00150e7ce3a Remove 'use_mirror' and 'root' properties. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:656731

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2425083002
 9 years ago
recipe-roller aa9e16acd4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/7076377b62701f77783d2d5e002fe2708ffab273 Fix VerifySubset when comparing empty lists (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2422313002
 9 years ago
agable d437d76b64 Reland "Remove SVN and File support from gclient" 
This is a revert of 398a46ee09
Which was itself a revert of b3a24c3fd5

BUG=641588

Review-Url: https://codereview.chromium.org/2404413002
 9 years ago
tandrii 48df58136d Gerrit git cl: make it work with minimal file. 
BUG=656555
R=emso@chromium.org,andybons@chromium.org

Review-Url: https://codereview.chromium.org/2421253002
 9 years ago
recipe-roller 1dbb595dbf Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a15c8474d308784e94fe4e15deb7c7860d717059 Reland: Add post_process hooks to recipe testing facilities. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2424483002
 9 years ago
rmistry c9ebbd2463 Fix logic to detect Gerrit CL in CQ 
BUG=chromium:656042

Review-Url: https://codereview.chromium.org/2419123002
 9 years ago
recipe-roller 49ea106b94 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9de4473f1587a0ba103ecaf8ce6b6e882ac40093 Revert post_process hooks for now. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2415303002
 9 years ago
recipe-roller 99366c494b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/61e9e2a3a9d074748850aa1b46dd170a51649aab Use deepcopy to avoid coupling between test cases. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2415963003
 9 years ago
recipe-roller 284076e87b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d97fe4474b8ebefb906e594aba840fff58720dae Add post_process hooks to recipe testing facilities. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2418613005
 9 years ago
recipe-roller d05b9b1575 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2e9ed981d6e2f75889aef93cb2b6a5e50a8aac37 Annotation protobuf code can now dump final. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2415803002
 9 years ago
recipe-roller 20fc95cca9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/4608377873373f343214b23d06a912fecfd31bbe Add clients, requirement injection. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2414793003
 9 years ago
recipe-roller 0884b021d8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e7c7c99cb0445fa97b7bf27f330fe58449f3d6b6 Add "regenerate protobufs" fast vendoring path. (dnj@chromium.org)
  https://crrev.com/2aab92c00dddf99d117e5846f327f85e8a3ce96a RecipeScript no longer copies recipe global attrs. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2413883002
 9 years ago
tandrii de281aee41 git cl try: make code less Rietveld-specific. 
This also adds first test to cover case of custom properties.

R=machenbach@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2409223002
 9 years ago
katthomas df66a34f68 Remove git lockfile flakiness on win (bot_update) 
Hypothesis: Sometimes bot update fails because windows fails to delete
a lockfile associated with a git process.

Test: If this happens, let's delete that lockfile and try again.

BUG=651602

Review-Url: https://codereview.chromium.org/2382653005
 9 years ago
scottmg bda914b8c3 Add .mojom to git-gs 
R=maruel@chromium.org

Review-Url: https://codereview.chromium.org/2410393002
 9 years ago
lpique 398a46ee09 Revert of Remove SVN and File support from gclient (patchset #4 id:60001 of https://codereview.chromium.org/2398493004/ ) 
Reason for revert:
The Chrome buildbots pass "--transitive" still. Removing the option causes them to fail to build.

Example:

https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-chrome-pfq-informational/builds/21555

Original issue's description:
> Remove SVN and File support from gclient
>
> FileImpl was only usable with SVN.
>
> R=maruel@chromium.org
> BUG=641588
>
> Committed: b3a24c3fd5

TBR=maruel@chromium.org,agable@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641588

Review-Url: https://codereview.chromium.org/2405173003
 9 years ago
recipe-roller 7e269f0d05 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e129c96c485b33149256838d912c5f324bf59dd7 Add LogDog / annotation protobuf support. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2410173003
 9 years ago
agable b3a24c3fd5 Remove SVN and File support from gclient 
FileImpl was only usable with SVN.

R=maruel@chromium.org
BUG=641588

Review-Url: https://codereview.chromium.org/2398493004
 9 years ago
tandrii e113dfd7a1 git cl try: refactor to add Gerrit support in the future. 
R=nodir@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2400713003
 9 years ago
tandrii 568043bdd9 git cl try: remove --use-rietveld and related code. 
R=nodir@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2401943002
 9 years ago
tandrii 64103db728 Revert of gclient: kill git fetch operation that hangs. (patchset #12 id:220001 of https://codereview.chromium.org/2241843002/ ) 
Reason for revert:
Didn't help.

Original issue's description:
> gclient: kill git fetch operation that hangs.
>
> This provides env variable GCLIENT_KILL_GIT_FETCH_AFTER
> that kills git fetch if it produces no output for that
> many seconds.
>
> Note that this is not final patch, but an experiment.
> See http://crbug.com/635641#c24 for the deployment plan.
>
> BUG=635641
> R=hinoka@chromium.org
>
> Committed: f8757b7e02

TBR=hinoka@chromium.org,hinoka@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=635641

Review-Url: https://codereview.chromium.org/2410853002
 9 years ago
tandrii 30d956272d Revert of bot_update/gclient: kill git fetch after timeout regardless of output. (patchset #2 id:20001 of https://codereview.chromium.org/2293013002/ ) 
Reason for revert:
didn't work.

Original issue's description:
> bot_update/gclient: kill git fetch after timeout regardless of output.
>
> Also spits out whatever output was produced by git fetch for debugging.
>
> BUG=635641
> R=machenbach@chromium.org,hinoka@chromium.org
>
> Committed: db8b839320

TBR=hinoka@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=635641

Review-Url: https://codereview.chromium.org/2410053002
 9 years ago
tandrii 45b2a5891a git cl try-results regression tests for Gerrit. 
The flow looks like this:

  $ git cl status
  Branches associated with reviews:
    gerrit-4483 : https://chromium-review.googlesource.com/381231 (waiting)

  $ git cl try-results
  Warning: Codereview server has newer patchsets (2) than most recent
  upload from local checkout (None). Did a previous upload fail?
  By default, git cl try uses latest patchset from codereview,
  continuing using such patchset 2.

  Warning: Some results might be missing because You are not logged in.
  Please login first by running:
    depot-tools-auth login chromium-review.googlesource.com
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
  Total: 2 try jobs

  $ depot-tools-auth login chromium-review.googlesource.com
   <<<auth in my browser>>>

  Logged in to chromium-review.googlesource.com as <some@email.com>

	To login with a different email run:
		depot-tools-auth login chromium-review.googlesource.com
	To logout and purge the authentication token run:
		depot-tools-auth logout chromium-review.googlesource.com

  $ git config branch.gerrit-4483.gerritpatchset 2
  $ git cl try-results
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
    Infra Mac Tester              https://luci-milo.appspot.com/swarming/...
  Total: 3 try jobs

R=sergiyb@chromium.org,emso@chromium.org
BUG=599931
TEST=new unittests + end-to-end local.

Review-Url: https://codereview.chromium.org/2392463009
 9 years ago
vapier ae39f566ca repo: update to v1.12.34-cr2 
We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works

Review-Url: https://codereview.chromium.org/2402193002
 9 years ago