If an exception occurs during a try block which prevents a step from actually executing, then the finally block's attempt to access step.active_result will fail, and the original exception will be hidden behind a new exception from the recipe engine. This CL changes this behavior so that the original exception will always fire.
Review-Url: https://codereview.chromium.org/2175103002
Reason for revert:
this is wrong. if directory is not empty, git clone fails
Original issue's description:
> bot_update: fix git dir check
>
> existance of a dir does not mean it is a git repo. Check .git dir
> presence instead.
>
> This is the reason why swarmbucket build.git builds fail.
>
> TBR=hinoka@chromium.org
> BUG=
>
> Committed: cdac80c9fbTBR=hinoka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2173683003
site config is not present on builders which use kitchen, so we need to use credentials provided by puppet in the /creds directory.
BUG=624212
TBR=hinoka
Review-Url: https://codereview.chromium.org/2108073002
The script already contains references to chrome-internal, and when running
under remote_run we have no access to hacky build_internal checkout.
BUG=593999, 584079
Review-Url: https://codereview.chromium.org/2101573002
The change in https://codereview.chromium.org/1982243002
didn't take into account that the script runs on the actual
bot OS, so Windows will have backslashes as dir separators.
BUG=438952
Review-Url: https://codereview.chromium.org/2021783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300672 0039d316-1c4b-4281-b951-d872f2087c98
The --extra_patchlevel flag was added in
https://codereview.chromium.org/1988583002/
In order to make it possible for WebRTC patches to apply in
src/third_party/webrtc of a Chromium checkout, one directory
level needs to be trimmed.
BUG=438952, 611808
Review-Url: https://codereview.chromium.org/1982243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300618 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/d9039313202dfb6adaf890674abdd8ee6aec940d recipe engine: remove explicit cwd default in step recipe module (phajdan.jr@chromium.org)
R=phajdan.jr@chromium.org
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1926633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300229 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
I believe this is mostly likely to have broken Angle, but this is speculative.
http://crbug.com/606150
Original issue's description:
> bot_update: call gclient sync after checking out a gerrit ref
>
> BUG=chromium:602906
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300109
TBR=hinoka@chromium.org,yyanagisawa@chromium.org,hinoka@google.com,phajdan.jr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:602906
Review URL: https://codereview.chromium.org/1918903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300159 0039d316-1c4b-4281-b951-d872f2087c98
Removes deprecated patch_project_roots in bot_update,
and the TODOs used for migration.
Depends: https://codereview.chromium.org/1913863002
R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563
Review URL: https://codereview.chromium.org/1920933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300153 0039d316-1c4b-4281-b951-d872f2087c98
IMPORTANT: See bug http://crbug.com/605563#c3 for deployment and emergency roll-back plan.
This patch is first of a series. It provides a cleaner and generic way to apply patches to non-root of first solution.
R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563
Review URL: https://codereview.chromium.org/1917433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300141 0039d316-1c4b-4281-b951-d872f2087c98
Avoid to call git reset --soft to preserve current revision to
FETCH_HEAD. 'got_revision' property would also be that from
FETCH_HEAD.
BUG=596787
Review URL: https://codereview.chromium.org/1837453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299721 0039d316-1c4b-4281-b951-d872f2087c98
Also makes bot_update use this.
This allows for clank to manually set the gclient config.
BUG=590788
Review URL: https://codereview.chromium.org/1815863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299398 0039d316-1c4b-4281-b951-d872f2087c98
Sometimes the spec passed in via parameters also have got_revision_mapping that
we want to use.
BUG=590788
Review URL: https://codereview.chromium.org/1748143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299015 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
I believe this breaks trybot patching on Windows.
Example: https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/6811
Error:
'E:\b\build\scripts\slave\.recipe_deps\depot_tools\python' is not recognized as an internal or external command,
operable program or batch file.
I'm speculatively reverting.
Original issue's description:
> bot_update: add depot_tools to PATH so that e.g. apply_issue can be found
>
> BUG=437264
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298556
TBR=jochen@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437264
Review URL: https://codereview.chromium.org/1662763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298561 0039d316-1c4b-4281-b951-d872f2087c98
I acknowledge this is really gross. This allows us to roll the changes into
build_limited in the short term.
Longer term, paths could be passed from outside.
BUG=582074
Review URL: https://codereview.chromium.org/1665753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298550 0039d316-1c4b-4281-b951-d872f2087c98
recipe_engine -> 44b384f9b4f1085e9cfe43ea6308735a3af8d4e5: RELAND of Make the recipe engine allow modules named the same thing to co-exist.
R=martiniss@chromium.org,luqui@chromium.org
TBR=iannucci@chromium.org
BUG=582280
Review URL: https://codereview.chromium.org/1660163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298530 0039d316-1c4b-4281-b951-d872f2087c98
hinoka
rmistry
tandrii
Andrew Bonventre
martiniss
nodir
smut
phajdan.jr
agable
kjellander@chromium.org
recipe-roller@chromium.org
yyanagisawa@chromium.org
machenbach@chromium.org
szager@chromium.org
hinoka@chromium.org
luqui@chromium.org