Commit Graph

1260 Commits (0927b7eef86dd283507fda2fc71cc7b502aab23c)
 

Author SHA1 Message Date
maruel@chromium.org ed6ce00382 Centralize testing to make it simpler to test when rename are supported correctly
R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7789030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99980 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 6cdac9ef45 Make rietveld status handling saner
Add support for a few svn:* properties.
Silently ignore svn:mergeinfo. It's useless once we're switched to git-land anyway.

More testing.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7840003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99952 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 2f4a0fa92a Improve rietveld tests.
I plan to do some refactoring and these tests will help reduce the likehood of
regression.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7739039

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99799 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 3187f70542 Revert r99735 "Change default --jobs value from 1 to 4."
It breaks upstream webkit and nacl. I'll make then both use --jobs 1 before
relanding.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7833051

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99761 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org ee118f98d6 Change default --jobs value from 1 to 4.
It is now safe to use.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7779023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99735 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
tonyg@google.com 0d16357c70 Update repo.git URL from broken kernel.org to Chromium hosted.
Review URL: http://codereview.chromium.org/7779014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99564 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org be60565b8a Improve is_delete detection.
Make tests more exhaustive in prospect to file move handling.
Rename 'c' variables to 'p' to easy copy paste.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7828017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99439 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org d52417c909 Do not run integration tests on upload, they are too slow.
gclient_scm_test.py throws randomly gclient_utils.Error.
Simply update the test expectation. It has no effect on runtime.

BUG=
TEST=


Review URL: http://codereview.chromium.org/7828024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99436 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 118fb1cdcb Fix parallelization of multiple solutions once for all.
Verify correctness with a unit test written explicitly to verify all corner cases.

BUG=60725
TEST=new unit test

Review URL: http://codereview.chromium.org/6598087

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99234 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org be113f1365 Make filename processing a static method.
This is in preparation to support file rename, as a source_filename needs to be
added and processed.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7809001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99185 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 031524151a Implement reverse mangling of svn properties.
That means some properties will being to be applied.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7776015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99182 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org f40e2a5627 Add regression test for the parallel jobs dependency issue.
Well, the funny thing is that it doesn't find the bug but the framework is
already good enough as-is to be worth checked-in, so the next commit can show
the relevant difference.

R=dpranke@chromium.org
BUG=60725
TEST=

Review URL: http://codereview.chromium.org/7773001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98869 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 0895b75236 Move the parser creation code in its own function to enable unit testing.
Unit test follow in next CL.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7766005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98480 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 943b12735f Improve search algorithm for GAE SDK in depot_tools integration tests.
Still not enough to fix presubmit checks on commit queue but a step in the
right direction.
Review URL: http://codereview.chromium.org/7748020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98445 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 6b5eae2d19 Make GAE instance bind all interfaces when a variable is set.
It's mostly for debugging when testing with a leaking service. It's going to be
rarely used but I used it often enough to warrant it being committed.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7744030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98438 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dilmah@chromium.org d22b970a0e Ignore C++ comments while checking for Singleton<T> in headers.
(without ignoring comments this check gives false positives on code like base/threading/thread_local.h)
Review URL: http://codereview.chromium.org/7747023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98421 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 4f6d25c4ac Update upload.py from rietveld @ 7696eca367d2.
---

Trap failure to get password from keyring

It happens when using upload.py from a ssh session without a X session but
gnomekeyring is used.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7715013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97909 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org b615edaef7 Update upload.py from ed59464f8468.
R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7709021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97854 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
zbehan@chromium.org e07b3ce3d8 chrome_set_ver: Add symlink to chromite_wrapper for new tool
BUG=none
TEST=run it
Review URL: http://codereview.chromium.org/7605017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@96223 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
zbehan@chromium.org 38e22e95a3 Update chromite wrapper
* Add a new version of the chromite wrapper as chromite_wrapper
* Create symlinks (chromite, cros_sdk, cbuildbot) pointing to it

TEST=inside repo checkout, run cros_sdk, chromite, cbuildbot
Review URL: http://codereview.chromium.org/7484062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@94011 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org d587f39361 Do not interfere with git cl patch <issue>
R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7493050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@94004 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
phajdan.jr@chromium.org 26dd22b8ca GTTF: make gclient config overwrite the .gclient file if it exists
This prevents bots waiting 20 minutes and failing the update step.
Review URL: http://codereview.chromium.org/7492019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93678 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 13f623cabf Fix git-cl --contributor flag support for presubmit checks.
Chromium's presubmit check assumes the author is an email address.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7484002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93645 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
bauerb@chromium.org 4dd093752e Add merge attribute to OptionsObject in gclient_scm_test.py.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7488015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93628 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
bauerb@chromium.org 2aad1b262d Add --merge option to gclient sync.
BUG=none
TEST=

Review URL: http://codereview.chromium.org/7277035

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93611 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 891f6454c9 Fix support for pylint 0.24.
TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7487001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93451 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org cc73ad68ff Remove manual --tbr support and convert it into automatic TBR= detection.
It result in less code, forces uploading the change for eventual review and most
importantly enables the commit queue to correctly handle this.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7253015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@91575 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org c33455af29 Remove files without an extension from the presubmit checks.
This may include Makefile but it's saner to not include it by default

R=dpranke@chromium.org
BUG=
TEST=updated

Review URL: http://codereview.chromium.org/7251002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@90403 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 004fb7182b Replace OSError by the correct class IOError
R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7215025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89884 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org a5129fb808 Fix Checkout.post_processsors setup. __init__() was ignoring the argument!
TEST=Rewrote the unit test to catch that case.

R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/7192010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89700 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org eba646225d Improve CheckLongLines() to increase the hard limit at 50% when an exception is found.
Improve the list of exception to include very_long_symbol_names.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7097012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89696 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org b25b69b8d0 Add --depth option to repo.
See related repo change:
  https://review.source.android.com/#change,22722

Review URL: http://codereview.chromium.org/7111045
Patch from Doug Anderson <dianders@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89361 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
cmp@chromium.org 9e6ec10bba Wrap calls to git.bat in quotes.
Review URL: http://codereview.chromium.org/7178001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89268 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
cmp@chromium.org 8a4fb64c90 In Windows Git, set autocrlf and filemode by default.
Review URL: http://codereview.chromium.org/7172033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89261 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 57e48b821b Fix presubmit check to not enforce git-try to be parsed as python
R=cmp@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7172014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89208 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
cmp@chromium.org 79d98483b0 git-try should be called as 'git try' from now on.
Review URL: http://codereview.chromium.org/7111049

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89036 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
cmp@chromium.org bbb46658fa Make git try work on Windows.
This mirrors the git-cl changes by first moving git-try
to git_try.py (which git cl already had), then copying
git-cl to git-try and updating all references to git-cl
and git_cl.py to the corresponding git try references.

The main issue is that in the MINGW/Msysgit case we want
to use the Python in depot_tools since that is 100%
compatible with the Command Prompt.  Hence we need
to call it directly and then pass it the name of the
git_try.py script.

Note that 'git-try' will not (ever) work on Windows,
and users should only ever run 'git try'.  Hence the
need to modify the output of the command to avoid
further confusion.
Review URL: http://codereview.chromium.org/7114002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89031 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 63f78b0f63 Need to strip the config result value otherwise it contains a \n.
It was broken in 88979. Someone my limited testing missed that.

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7147016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88987 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org e424b220ae Make TrialDirMixIn so it can be used stand alone.
This will be used in commit queue tests.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7046110

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88986 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 69eaecb312 Use tuple everywhere with explicit conversion.
TEST=Add PanProjectChecks unittest, there was none.

R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/7104141

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88982 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 03b3bdcb53 Fix support for AUTHOR presubmit check in git cl.
Properly load --contributor value or use the git config user.email value.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7134097

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88979 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 244e344739 Add linux3 support.
'Cause linux2 is so last decade.

TBR=evan@chromium.org
BUG=85845
TEST=

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88788 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 51919774d5 Make prepare() accept a revision argument.
R=dpranke@chromium.org
TEST=few
BUG=

Review URL: http://codereview.chromium.org/6995115

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88779 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 6ed8b50be6 Make post_processors part of the Checkout object state.
R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7044090

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88777 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 740f9d7ede Initializes correctly 'url'.
R=evan@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7129059

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88697 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
bauerb@chromium.org 20d1943ffb Ignore empty lines in OWNERS files.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7003057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88341 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dpranke@chromium.org 751797ac3c turn off source filter for owners check
BUG=
TEST=

Review URL: http://codereview.chromium.org/7024021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88160 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 378a419f0d git diff can have 'new file mode' for new files and 'new mode' for current files
R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7065074

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87979 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 4869bcfb2e Do no delete file if they exist, even if p.is_new is True.
For a yet unknown reason, a chmod +x on a git svn checkout will set a 'A'
status. Will investigate separately.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6993033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87903 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 58fe662dc7 Add support for empty files, __init__.py is a common example.
Use p.is_new signal and set it manually with rietveld patches.
Add regression test for +x.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7054057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87858 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago