maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								4ff922af46 
								
							
								 
							
						 
						
							
							
								
								Remove gcl.ChangeInfo dependency in presubmit_support.py.  
							
							 
							
							... 
							
							
							
							TEST=none
BUG=none
Review URL: http://codereview.chromium.org/126068 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18309 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								8d5c9a5a52 
								
							
								 
							
						 
						
							
							
								
								Fix gcl breakage.  
							
							 
							
							... 
							
							
							
							Small refactor of ChangeInfo to not hardcode the use of GetRepositoryRoot().
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/125051 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18272 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								17f59f2dd9 
								
							
								 
							
						 
						
							
							
								
								A step closer to make presubmit SCM independent.  
							
							 
							
							... 
							
							
							
							Stop presubmit_support.py from calling gcl.GetRepositoryRoot(). Instead, save the repository root in ChangeInfo and name it GetLocalRoot() to make it less confusing.
Add GetFileList() and GetFileNames() to ChangeInfo to make it less confusing and more "interface-like".
TEST=updated unit tests with a lot of pain
BUG=none
Review URL: http://codereview.chromium.org/119442 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18266 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								a6f27cd0a4 
								
							
								 
							
						 
						
							
							
								
								Add --no_watchlists to some tests to work around unit tests failures.  
							
							 
							
							... 
							
							
							
							TESTS=still none
BUG=none
TBR=nirnimesh
Review URL: http://codereview.chromium.org/126031 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18245 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								b9d5fd015d 
								
							
								 
							
						 
						
							
							
								
								Revert 18198 because the root chromium codereview.settings has wrong try server settings. :(  
							
							 
							
							... 
							
							
							
							Will reapply in 3 days.
TEST=gcl try works.
BUG=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/126020 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18232 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								899410c9ee 
								
							
								 
							
						 
						
							
							
								
								Add automatic try server settings detection support.  
							
							 
							
							... 
							
							
							
							Don't rely on the freaky tryserver.py script anymore. Use gcl codereview settings instead.
TEST=gcl try still works, shouldn't break git-try
BUG=none
Review URL: http://codereview.chromium.org/123020 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18198 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								08677ab96c 
								
							
								 
							
						 
						
							
							
								
								Oops, this file was missing from   http://codereview.chromium.org/122040  
							
							 
							
							... 
							
							
							
							TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18179 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								2c3024ac53 
								
							
								 
							
						 
						
							
							
								
								Refactor the unit tests to remove a lot of duplicate code.  
							
							 
							
							... 
							
							
							
							Remove old unused git-cl test files.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/122040 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18177 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								07bbc21467 
								
							
								 
							
						 
						
							
							
								
								Actually make use of the may_prompt flag.  
							
							 
							
							... 
							
							
							
							This is annoying when using gcl presubmit.
TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/122010 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18141 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								df1595ac20 
								
							
								 
							
						 
						
							
							
								
								Fix the ALL_CAPS black list regexp.  
							
							 
							
							... 
							
							
							
							Add some regexp unit test.
TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/118530 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18139 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								92022ec600 
								
							
								 
							
						 
						
							
							
								
								Melting pot of changes.  
							
							 
							
							... 
							
							
							
							Fix GclChangeInfo.__getattr__ to only accept uppercase tags.
Rename illnamed GclChangeInfo.Change() to GclChangeInfo.Name().
Fix random comments.
TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/122016 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18138 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								f5888bb793 
								
							
								 
							
						 
						
							
							
								
								Add CheckChangeHasNoStrayWhitespace().  
							
							 
							
							... 
							
							
							
							TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/118527 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18081 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								0874d47499 
								
							
								 
							
						 
						
							
							
								
								Update CheckChangeSvnEolStyle() to be upload-friendly.  
							
							 
							
							... 
							
							
							
							TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/118525 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18079 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								bc50eb4a88 
								
							
								 
							
						 
						
							
							
								
								Add CheckChangeHasDescription.  
							
							 
							
							... 
							
							
							
							TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/119427 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18077 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								e9b71c9b3a 
								
							
								 
							
						 
						
							
							
								
								Add CheckChangeHasOnlyOneEol and CheckChangeHasNoCrAndHasOnlyOneEol.  
							
							 
							
							... 
							
							
							
							TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/118505 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18075 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								c809ec2749 
								
							
								 
							
						 
						
							
							
								
								Suppress RunPythonUnitTests output while running.  
							
							 
							
							... 
							
							
							
							The output is only shown when it's failing. It makes the presubmit check much cleaner.
Also rename TestDescription and TestContent that were ill named.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118415 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18055 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								b0dfd35742 
								
							
								 
							
						 
						
							
							
								
								Make the presubmit output much more compact.  
							
							 
							
							... 
							
							
							
							Disable prompting when using gcl presubmit xxx.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118498 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18054 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								b7d469083f 
								
							
								 
							
						 
						
							
							
								
								Add CheckChangeSvnEolStyle presubmit canned check.  
							
							 
							
							... 
							
							
							
							TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/119421 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18053 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								3410d917f3 
								
							
								 
							
						 
						
							
							
								
								Add InputApi.AffectedSourceFile() and custom filtering support.  
							
							 
							
							... 
							
							
							
							TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119365 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17975 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								51ee007126 
								
							
								 
							
						 
						
							
							
								
								Add --force as a synonym for --no_presubmit as per Nicolas' request.  
							
							 
							
							... 
							
							
							
							Factor out some code in FilterFlag() to make the code much more readable.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119315 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17884 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								44a17adf95 
								
							
								 
							
						 
						
							
							
								
								Add InputApi.ReadFile() and presubmit_canned_checks.CheckChangeHasNoCR().  
							
							 
							
							... 
							
							
							
							ReadFile limits to reading files inside the repository.
CheckChangeHasNoCR reads the text files looking for \r and fails if found.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118370 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17857 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								de0ba297d9 
								
							
								 
							
						 
						
							
							
								
								Fix presubmit_support.py run standalone and RunPythonUnitTests  
							
							 
							
							... 
							
							
							
							TEST=none
BUG=none
TBR=joi
Review URL: http://codereview.chromium.org/119285 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17839 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								8949138ee9 
								
							
								 
							
						 
						
							
							
								
								Use more sensible behavior in presubmit checks.  
							
							 
							
							... 
							
							
							
							It's less annoying to type Y than to have to rerun the scripts with --no_presubmit for certain checks.
TEST=none
BUG=none
TBR=joi
Review URL: http://codereview.chromium.org/119284 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17838 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								d7dccf5614 
								
							
								 
							
						 
						
							
							
								
								Add InputApi.is_committing to be able to return a failure or notification, depending on the check.  
							
							 
							
							... 
							
							
							
							Add input_api.traceback, useful for dumping information.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119252 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17837 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								32ba260f1e 
								
							
								 
							
						 
						
							
							
								
								Added patchset persistence in gcl, this is necessary to implement a presubmit queue.  
							
							 
							
							... 
							
							
							
							Now enforces ChangeInfo.issue (and .patchset) to be a int.
Renamed LoadChangelistInfo() to ChangeInfo.Load().
Removed ChangeInfo.__init__() default parameters.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118355 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17836 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								1487d53b6c 
								
							
								 
							
						 
						
							
							
								
								Improve the presubmit_canned_checks testing by using a real mock and testing for more cases.  
							
							 
							
							... 
							
							
							
							Remove a superfluous check in CheckLongLines().
Add unittest to InputApi.
Review URL: http://codereview.chromium.org/114082 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17805 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								4661e0c77b 
								
							
								 
							
						 
						
							
							
								
								The broken PRESUBMIT.py was fixed so reintegrating revision 17554 (which was good in the first place).  
							
							 
							
							... 
							
							
							
							BUG=none
TEST=none
TBR=joi
Review URL: http://codereview.chromium.org/119130 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17578 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								0018e7313d 
								
							
								 
							
						 
						
							
							
								
								Seems like revision 17554 busted the presubmit scripts, reverting.  
							
							 
							
							... 
							
							
							
							TEST=None
BUG=None
TBR=joi
Review URL: http://codereview.chromium.org/119122 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17561 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								8b40a9b81b 
								
							
								 
							
						 
						
							
							
								
								Fix ListRelevantPresubmitFiles().  
							
							 
							
							... 
							
							
							
							It was affected by the current directory!
Review URL: http://codereview.chromium.org/119101 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17554 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								143993e97b 
								
							
								 
							
						 
						
							
							
								
								Fix gcl unit tests.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/118159 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17488 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								ca14c12a62 
								
							
								 
							
						 
						
							
							
								
								Rewrite the presubmit test to be much more hermetic.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/115964 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17314 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								388f1d2656 
								
							
								 
							
						 
						
							
							
								
								Save 50 lines by converting the unit test to mox.MoxTestBase.  
							
							 
							
							... 
							
							
							
							BUG=None
TEST=None
Review URL: http://codereview.chromium.org/118019 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17215 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								b76227689c 
								
							
								 
							
						 
						
							
							
								
								Convert gclient_test.py to mox.MoxTestBase and saves 40+ lines  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/118014 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17213 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								77c4f0f135 
								
							
								 
							
						 
						
							
							
								
								Remove SVN-specific function InputApi.FilterTextFiles().  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/115923 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17202 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								15bdffa063 
								
							
								 
							
						 
						
							
							
								
								Make AffectedFile member variables private.  
							
							 
							
							... 
							
							
							
							Cache SvnAffectedFile.IsTextFile() return value.
Improve the unit test by not/less relying on the local file system.
Review URL: http://codereview.chromium.org/113964 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17180 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								786886257e 
								
							
								 
							
						 
						
							
							
								
								warnings.catch_warnings() is only available on python 2.5  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/115881 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17114 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								1e08c00d60 
								
							
								 
							
						 
						
							
							
								
								Add AffectedFile.IsTextFile() and deprecate AffectedTextFiles().  
							
							 
							
							... 
							
							
							
							Make DepotToLocalPath() and LocalToDepotPath() not static. It is necessary for a subsequent change since I need to factor out it's SCM assumption.
Review URL: http://codereview.chromium.org/113933 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17091 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								6ebe68a73d 
								
							
								 
							
						 
						
							
							
								
								Make the member variable 'protected' in the python sense.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113899 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17039 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								e1a524ff00 
								
							
								 
							
						 
						
							
							
								
								Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113883 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16983 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								f3eee5692c 
								
							
								 
							
						 
						
							
							
								
								Add a unit test for input_api.change.tags.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113859 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16959 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								9711bbafde 
								
							
								 
							
						 
						
							
							
								
								Add InputApi.version so the presubmit script can mark a minimum supported version for instance.  
							
							 
							
							... 
							
							
							
							BUG=None
R=joi
Review URL: http://codereview.chromium.org/115719 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16819 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								dbbeedc691 
								
							
								 
							
						 
						
							
							
								
								Factor out SVN-specific methods out of AffectedFile.  
							
							 
							
							... 
							
							
							
							TEST=New unit tests.
BUG=None
Review URL: http://codereview.chromium.org/113783 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16785 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								0ff1fab804 
								
							
								 
							
						 
						
							
							
								
								Add repository root presubmit support.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/115616 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16738 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								98fc2b9bf6 
								
							
								 
							
						 
						
							
							
								
								Add support to cache arbitrary file.  
							
							 
							
							... 
							
							
							
							Rename repository_root to REPOSITORY_ROOT.
Review URL: http://codereview.chromium.org/115615 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16598 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								374d65e518 
								
							
								 
							
						 
						
							
							
								
								Move the changelist files into a subdirectory for cached files implementation.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/115612 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16597 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								8c3ccf39eb 
								
							
								 
							
						 
						
							
							
								
								Fix error printing in gcl.GetRepositoryRoot() and fix its unit tests.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113650 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16499 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								003c269b98 
								
							
								 
							
						 
						
							
							
								
								When -s or --server is used, don't try the patch.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/115534 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16477 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								7b305e8c18 
								
							
								 
							
						 
						
							
							
								
								Add new presubmit check RunPythonUnitTests.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/115516 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16390 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								5771f2622c 
								
							
								 
							
						 
						
							
							
								
								Clean up revert.py and fixes an issue when only one file is reverted in a subdirectory.  
							
							 
							
							... 
							
							
							
							Add a basic unit test.
Review URL: http://codereview.chromium.org/115514 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16388 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								3d23524cb0 
								
							
								 
							
						 
						
							
							
								
								Add more presubmit support. Add PRESUBMIT.py to depot_tools.  
							
							 
							
							... 
							
							
							
							Changed InputApi.PresubmitLocalPath() to contain the absolute path without the script name.
Review URL: http://codereview.chromium.org/113354 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16157 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								2806acc58c 
								
							
								 
							
						 
						
							
							
								
								Remove two seams options.gclient and options.scm_wrapper in gclient.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/115322 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16155 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								0329e67bae 
								
							
								 
							
						 
						
							
							
								
								Remove the options.path_exists which only existed as a seam. It's not really needed in python.  
							
							 
							
							... 
							
							
							
							Also fix 2 other mocks.
Review URL: http://codereview.chromium.org/115286 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15976 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								1033accb23 
								
							
								 
							
						 
						
							
							
								
								Rename presubmit.py to presubmit_support.py to reduce confusion and be able to add a PRESUBMIT.py check into depot_tools.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113337 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15954 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								39593706a7 
								
							
								 
							
						 
						
							
							
								
								Fix unit test due to change r15911.  
							
							 
							
							... 
							
							
							
							TBR=estade
Review URL: http://codereview.chromium.org/115283 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15928 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								kuchhal@chromium.org
							
						 
						
							 
							
							
							
								
							
								00c41e457b 
								
							
								 
							
						 
						
							
							
								
								Add presubmit checks to look for BUG= and TEST= tags in change list description (Part 1 of 2).  
							
							 
							
							... 
							
							
							
							BUG=11287
TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used.
Review URL: http://codereview.chromium.org/113294 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15905 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								4810a96600 
								
							
								 
							
						 
						
							
							
								
								Deprecate gcl.GetSVNStatus() for gclient.CaptureSVNStatus() and fix some status information that was lost.  
							
							 
							
							... 
							
							
							
							This was breaking gclient revert on unversioned files.
TEST=ran "for %a in (tests\*test.py) do python %a" and all tests succeeded.
Review URL: http://codereview.chromium.org/115264 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15894 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								46a9410947 
								
							
								 
							
						 
						
							
							
								
								Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo().  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113290 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15891 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								5c3a2ff6a2 
								
							
								 
							
						 
						
							
							
								
								Add a flag not print errors in CaptureSVN()  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113288 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15887 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								be0d1ca0e4 
								
							
								 
							
						 
						
							
							
								
								Add more tests and cleanup ChangeInfo class.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113269 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15885 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								df7a3134bd 
								
							
								 
							
						 
						
							
							
								
								Simplify some functions by removing the options.stdout mock. Fix the unit test accordingly.  
							
							 
							
							... 
							
							
							
							Fix breakage caused by r15861 and add a regression test.
Review URL: http://codereview.chromium.org/113278 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15872 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								96b9171280 
								
							
								 
							
						 
						
							
							
								
								Revert 15861 because of  
							
							 
							
							... 
							
							
							
							File "D:\b\depot_tools\bootstrap\\..\gclient.py", line 446, in SubprocessCallAndCapture
   out.write(in_byte)
TBR=nsylvain
Review URL: http://codereview.chromium.org/115244 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15862 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								e77173e573 
								
							
								 
							
						 
						
							
							
								
								Simplify some functions by removing the options.stdout mock. Fix the unit test accordingly.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113272 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15861 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								11e0fd6997 
								
							
								 
							
						 
						
							
							
								
								Revert changes 15823 and 15824 because they broke gclient revert.  
							
							 
							
							... 
							
							
							
							TBR=sgk
Review URL: http://codereview.chromium.org/115217 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15827 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								46b9ae6961 
								
							
								 
							
						 
						
							
							
								
								Starts reusing functions in gclient.py from gcl.py.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113218 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15824 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								09b3ba2160 
								
							
								 
							
						 
						
							
							
								
								Cleanup gclient.py use of options where unnecessary.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113216 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15823 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								2dc8a4d3d4 
								
							
								 
							
						 
						
							
							
								
								Change CaptureSVNInfo() to return a dictionary instead of a object.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/113086 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15750 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								edd27d1770 
								
							
								 
							
						 
						
							
							
								
								- Add '!' and 'L' status support.  
							
							 
							
							... 
							
							
							
							- Fix gclient revert/status when one of the dependency directory is deleted.
- Remove an unneeded svn update after svn checkout.
- Updated tests.
Review URL: http://codereview.chromium.org/100256 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15068 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								e105d8d039 
								
							
								 
							
						 
						
							
							
								
								Pull gclient revision 72 and add the gclient unit test.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/99226 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14957 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								207fdf3647 
								
							
								 
							
						 
						
							
							
								
								Convert gcl.GetSVNFileInfo() to xml format.  
							
							 
							
							... 
							
							
							
							Add gcl's first unit test.
Add version string.
Review URL: http://codereview.chromium.org/100095 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14771 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								c1675e27e6 
								
							
								 
							
						 
						
							
							
								
								Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRESUBMIT.py scripts.  
							
							 
							
							... 
							
							
							
							Also add a version number to gcl.py.
Review URL: http://codereview.chromium.org/99072 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14644 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@chromium.org
							
						 
						
							 
							
							
							
								
							
								02e9e068f9 
								
							
								 
							
						 
						
							
							
								
								When I copied presubmit_unittest.py, I picked the old one. Fix with the latest version from the "old" depot_tools.  
							
							 
							
							... 
							
							
							
							TBR=nsylvain
Review URL: http://codereview.chromium.org/100055 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14635 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago  
						
					 
				
					
						
							
							
								 
								maruel@google.com
							
						 
						
							 
							
							
							
								
							
								fb2b8eb2e2 
								
							
								 
							
						 
						
							
							
								
								Create the Next Generation of depot_tools. Eh.  
							
							 
							
							... 
							
							
							
							Review URL: http://codereview.chromium.org/92087 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14349 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							17 years ago