The Unicode box drawing turn out malformed on Windows (even with
fix_encoding.py). This CL refactors the box drawing code, and makes
Windows box drawing use regular ASCII characters. Details:
* Add print_red_boxed_text() to programatically print box aroun given
list og strings.
* Unicode box drawing characters are escaped, removing the use of
non-ASCII characters in source code.
* Convert message source to generators for greater flexibilty, and
remove the need for manual horizontal padding.
* Add proper use colorama with Style.BRIGNT and Style.RESET_ALL.
* For Windows, revert to ASCII characters for box drawing.
Change-Id: I71a728db480709b4376d538aaecd701f9197e7ac
Reviewed-on: https://chromium-review.googlesource.com/c/1461249
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ METRICS COLLECTION IS TAKING PLACE ┃
┃ ┃
┃ To suppress this message opt in or out using: ┃
┃ $ gclient metrics [--opt-in] [--opt-out] ┃
┃ For more information please see metrics.README.md ┃
┃ in your depot_tools checkout or visit ┃
┃ https://goo.gl/yNpRDV. ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
R=ehmaldonado, mmoss, tandrii
Change-Id: Iab3a5a18aa57e603c8f253f3fcbbf7f96727e003
Reviewed-on: https://chromium-review.googlesource.com/c/1368409
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Elliott Friedman <friedman@chromium.org>
Mentioning these commands make it easier for folks to get rid of the
large notice.
Bug: None
Change-Id: I85dd0e1ec0d33999af46f9e20b95bea05bd40a1e
Reviewed-on: https://chromium-review.googlesource.com/c/1330181
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
When we change the version number in metrics_utils:
If the user is not a Googler, or has opted out explicitly, nothing happens
and we still don't collect metrics.
If we're collecting metrics from the user, we stop collecting metrics
and display a notice telling them what has changed.
That notice will be displayed ten times, after which we will
resume collecting metrics. A notice telling them we're collecting metrics
will still be displayed.
Bug: None
Change-Id: If1cc12b2fc06f0d6237714c4f182367b1afdf9fb
Reviewed-on: https://chromium-review.googlesource.com/c/1285395
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Print notice to stderr to avoid interfering with scripts that parse stdout.
Bug: 832386
Change-Id: Ifbcc52809213311489f5c8434b3c16ea53373e57
Reviewed-on: https://chromium-review.googlesource.com/1145697
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Edward Lemur
Samuel Huang
Jared Saul
Elliott Friedman
Peter Boström
