Otherwise, all the parameters are coagulated into a single one.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119308
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17968 0039d316-1c4b-4281-b951-d872f2087c98
Factor out some code in FilterFlag() to make the code much more readable.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119315
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17884 0039d316-1c4b-4281-b951-d872f2087c98
ReadFile limits to reading files inside the repository.
CheckChangeHasNoCR reads the text files looking for \r and fails if found.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118370
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17857 0039d316-1c4b-4281-b951-d872f2087c98
If the root path ends with a path separator (\ or /), the function used to cut an additional character from the path and the returned value would be incorrect. This fix makes sure the behavior is consistent and correct no matter if the root path ends with a separator or not.
(This fixes the "epot_tools" tools bug.)
Review URL: http://codereview.chromium.org/118376
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17855 0039d316-1c4b-4281-b951-d872f2087c98
This is needed if you do not have VS in your PATH on purpose and makes life easy if you do not have it there by accident.
Review URL: http://codereview.chromium.org/112098
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17854 0039d316-1c4b-4281-b951-d872f2087c98
It's less annoying to type Y than to have to rerun the scripts with --no_presubmit for certain checks.
TEST=none
BUG=none
TBR=joi
Review URL: http://codereview.chromium.org/119284
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17838 0039d316-1c4b-4281-b951-d872f2087c98
Now enforces ChangeInfo.issue (and .patchset) to be a int.
Renamed LoadChangelistInfo() to ChangeInfo.Load().
Removed ChangeInfo.__init__() default parameters.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118355
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17836 0039d316-1c4b-4281-b951-d872f2087c98
They automatically git clone the original repository and execute the original script. So if they are first in the path, they will be executed. If a user has another git-cl/try in the path prior, these stubs won't be used at all and won't mess with the user's setup.
Also fix a bug with git handling in trychange.py
Review URL: http://codereview.chromium.org/119244
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17737 0039d316-1c4b-4281-b951-d872f2087c98
- Create a new parameter for "gcl change 12354 <filename>" to read comments from a text file. This allows us to programmatically inject comments into a gcl upload
- Added helper methods in change to order of which other_files have changed (brings changed files to the top of the list). This makes it easier to find which files have change, and simply cut and paste the top of the list (after many merges, the list of unmodified files grows to be quite extensive... very useful)
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17684 0039d316-1c4b-4281-b951-d872f2087c98
It was affected by the current directory!
Review URL: http://codereview.chromium.org/119101
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17554 0039d316-1c4b-4281-b951-d872f2087c98
Cache SvnAffectedFile.IsTextFile() return value.
Improve the unit test by not/less relying on the local file system.
Review URL: http://codereview.chromium.org/113964
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17180 0039d316-1c4b-4281-b951-d872f2087c98
Make DepotToLocalPath() and LocalToDepotPath() not static. It is necessary for a subsequent change since I need to factor out it's SCM assumption.
Review URL: http://codereview.chromium.org/113933
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17091 0039d316-1c4b-4281-b951-d872f2087c98
Ironically, it was broken.
Review URL: http://codereview.chromium.org/115679
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16856 0039d316-1c4b-4281-b951-d872f2087c98
BUG=gcl commit doesn't show any "svn: 'bleh' is not a working copy" error
R=jam
Review URL: http://codereview.chromium.org/113782
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16781 0039d316-1c4b-4281-b951-d872f2087c98
some of the files have attribute changes, the server responds with a
list of files where the files with attribute changes have backslashes
(as they do in the svn diff output). Fix this in the client.
A server-side fix might also be nice; where does the server-side code live?
BUG=none
TEST=none
Patch contributed by Joi.
Review URL: http://codereview.chromium.org/112050
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16688 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
skylined@chromium.org
laforge@chromium.org