This is copied into other projects, so clean it up here.
Change-Id: I6ef0829210053b7dd3e4961a6e5a80c8fe1493c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4983215
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
python3 is the only supported version of python in depot_tools.
Changes include:
* updating python version requirements
* removing third_party/six
Bug: 1475402
Change-Id: Ib86231413fcac494ceb27d1783e53b9d86533c26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4845292
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
This CL adds the Shipped field (and may update the
License File field) in Chromium READMEs. Changes were
automatically created, so if you disagree with any of
them (e.g. a package is used only for testing purposes
and is not shipped), comment the suggested change and
why.
See the LSC doc at go/lsc-chrome-metadata.
Bug: b:285450740
Change-Id: Id4efb2646598d1dd6f12147a9651326021330d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4664434
Commit-Queue: Anne Redulla <aredulla@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
This reverts commit 684096347b.
Reason for revert:
Breaks git-cl split.
https://bugs.chromium.org/p/chromium/issues/detail?id=1054888
Original change's description:
> Improve git cl split
>
> This CL changes the behavior of `git cl split` to split the change
> by the size of the resulting CLs. For now, this is based on the number
> of bytes changed, and not by the number of changed lines. Depending
> on the shape of change, this may still produce more CLs than expected
> (and possibly more than before).
>
> A future change will switch the split to be based on the number
> of affected lines, and also introduce a mode to base the split
> on the number of affected files.
>
> Bug: 998922
> Change-Id: I49f868972a61b89b426ef9e2ceedc733eacb4350
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778744
> Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
TBR=fdoray@chromium.org,dpranke@chromium.org,yannic.bonenberger@gmail.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com
Bug: 998922
Change-Id: I466e1245d5f1c934443d850c48c42d3e694e71c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080205
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
This CL changes the behavior of `git cl split` to split the change
by the size of the resulting CLs. For now, this is based on the number
of bytes changed, and not by the number of changed lines. Depending
on the shape of change, this may still produce more CLs than expected
(and possibly more than before).
A future change will switch the split to be based on the number
of affected lines, and also introduce a mode to base the split
on the number of affected files.
Bug: 998922
Change-Id: I49f868972a61b89b426ef9e2ceedc733eacb4350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778744
Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
This reverts commit 7fd6347be3.
Reason for revert: This broke Flutter CI - we're not using vpython everywhere yet
Original change's description:
> depot_tools: Remove third_party/httplib2.
>
> depot_tools' scripts have been using vpython httplib2 for a while.
>
> Change-Id: I9403d92332c74de0ed69d6f59f60c81772d0577a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978983
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
TBR=ehmaldonado@chromium.org,apolito@google.com
Change-Id: Ie53a8d07ccfba5a7cc5bcb431d4f7b897f66788a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989012
Reviewed-by: Dan Field <dnfield@google.com>
Commit-Queue: Dan Field <dnfield@google.com>
depot_tools' scripts have been using vpython httplib2 for a while.
Change-Id: I9403d92332c74de0ed69d6f59f60c81772d0577a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978983
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
This allows people to pin a specific version of pylint when running
it. The default behavior is unchanged: we run pylint-1.5.6 still
as we've created a vpython wheel in cipd for it. But for projects
that want to move to a newer version, they can pick any of the new
1.x wrappers. Having the full set of versions here allows projects
to incrementally move to newer versions as the lint delta between
1.5 & 1.6 tends to be much smaller than 1.5 & 1.9.
We don't include support for the newer 2.x series as those only
support Python 3 which the codebase isn't ready for.
Bug: 866772
Test: `./pylint ...` still works & shows pylint-1.5
Test: `./pylint-1.5 ...` runs the v1.5 version
Test: `./pylint-1.8 ...` runs the v1.8 version
Change-Id: I7c47187493564db81e3eb28c6dbd09e6309ead46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752507
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Fixes colorama unintentionally overriding multiple sys.stdout wrappers of our own.
And provides a fix for a SyntaxWarning on Python 3.8:
C:\Google\depot_tools\third_party\colorama\ansitowin32.py:43: SyntaxWarning: invalid escape sequence \[
ANSI_RE = re.compile('\033\[((?:\d|;)*)([a-zA-Z])')
Tests are updated to account for the annotation wrapper no longer being overriden.
A fix by agable for the annotation wrapper working with carriage returns is also included (https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1592612).
Bug: 958138, 958321
Change-Id: I2fe1def85c66cfe5229a1c25c2f677e498593eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1591513
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Ran "2to3 -w -n -f print ./" and manually added imports.
Ran "^\s*print " and "\s+print " to find batch/shell scripts, comments and the like with embedded code, and updated them manually.
Also manually added imports to files, which used print as a function, but were missing the import.
The scripts still work with Python 2.
There are no intended behaviour changes.
Bug: 942522
Change-Id: Id777e4d4df4adcdfdab1b18bde89f235ef491b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595684
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
This is a reland of dd0c341bd2
The problem is that chromium-review.googlesource.com started requiring SNI.
httplib2 0.9.2 does not support that, but it seems to have been fixed since 0.10.1:
8aaecf4496
Original change's description:
> httplib: Update to 0.11.3
>
> The `DST Root CA X3` certificate was missing from cacerts.txt in the old
> version. This resulted in failure to connect to Let's Encrypt hosts.
> e.g., https://review.coreboot.org
>
> BUG=none
> TEST=Made sure my_activity.py continues to function and it can also
> connect to review.coreboot.org
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> Change-Id: I519916b58a59b8f13c227218e93c392a63a24800
> Reviewed-on: https://chromium-review.googlesource.com/1173064
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Bug: 914564, 891505
Change-Id: Icd2a57da802864b2ebb17417b73434e1284a292d
Reviewed-on: https://chromium-review.googlesource.com/c/1432633
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
This reverts commit dd0c341bd2.
As it seems to be breaking the "git cl upload". Reverting the change
as per suggestion from original author.
BUG=891505
Change-Id: Ica3f9aaa78d33cee6935ffcff789417ce098905e
Reviewed-on: https://chromium-review.googlesource.com/c/1260043
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com>
The `DST Root CA X3` certificate was missing from cacerts.txt in the old
version. This resulted in failure to connect to Let's Encrypt hosts.
e.g., https://review.coreboot.org
BUG=none
TEST=Made sure my_activity.py continues to function and it can also
connect to review.coreboot.org
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I519916b58a59b8f13c227218e93c392a63a24800
Reviewed-on: https://chromium-review.googlesource.com/1173064
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
** WARNING: please do not revert this CL without checking with vapier@ first ***
We disable new warnings that are triggered in depot_tools to pylintrc.
So the lint output before & after this CL are mostly unchanged. The
repos checked: depot_tools, src, and build.
Also update its deps along the way:
- Update astroid to 1.4.9.
- Drop now unused logilab.common.
- Import lazy_object_proxy 1.3.1.
- Import wrapt 1.10.11.
This should address the issue where some Chromium bots don't have the
lazy_object_proxy/wrapt python modules installed. These have optional
C modules that we don't compile either as they have Python fallbacks.
Bug: 863669
Change-Id: Iade0e6d89598e2c836ed647996f43db356c43cd0
Reviewed-on: https://chromium-review.googlesource.com/1145485
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
This reverts commit 3899f1bcce.
Reason for revert: causing PRESUBMIT error on catapult repo
BUG:chromium:865897
Original change's description:
> pylint: upgrade to 1.5.6
>
> We disable new warnings that are triggered in depot_tools to pylintrc.
> So the lint output before & after this CL are mostly unchanged. The
> repos checked: depot_tools, src, and build.
>
> Also update astroid to 1.4.9 and drop logilab.common as needed.
>
> Bug: 863669
> Change-Id: Ib602560c1bcad5a9e8b6ca731d9465f43220f044
> Reviewed-on: https://chromium-review.googlesource.com/1137382
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
TBR=vapier@chromium.org,iannucci@chromium.org,jbudorick@chromium.org
Change-Id: I8ea087123db4e52fdf7ebff8b1ed356fd60a6059
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863669
Reviewed-on: https://chromium-review.googlesource.com/1145160
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
We disable new warnings that are triggered in depot_tools to pylintrc.
So the lint output before & after this CL are mostly unchanged. The
repos checked: depot_tools, src, and build.
Also update astroid to 1.4.9 and drop logilab.common as needed.
Bug: 863669
Change-Id: Ib602560c1bcad5a9e8b6ca731d9465f43220f044
Reviewed-on: https://chromium-review.googlesource.com/1137382
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Grab a few random fixes like deleting old abstract-class-little-used,
abstract-class-not-used, and star-args.
Bug: None
Test: `./pylint *.py` shows no regressions
Change-Id: I494379e18da002d479cb193412fcc49f8c66f376
Reviewed-on: https://chromium-review.googlesource.com/1103763
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
This library is no longer used by anything in depot_tools.
Bug: 770408
Change-Id: I8f0a99f73cf9c52731994c830085678ca652d2c4
Reviewed-on: https://chromium-review.googlesource.com/1072491
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Using the remote url is much more useful than the hash of the
first commit in the repo, since we can use it to track down
repos, teams, and people still using Rietveld for review.
Bug: 600469
Change-Id: I067594794ba77692c11daf63b5f5844d36209a08
Reviewed-on: https://chromium-review.googlesource.com/556301
Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
This issue is fixed in Python 2.7.12, but we don't guarantee
that we use that version everywhere. The root issue is that,
on certain platforms (e.g. Mac), the exception indicating that
the underlying command (e.g. 'hg') was not found is too large,
and loading the pickle representing the exception fails.
This CL catches this specific exception and treats it identically
to the OS properly raising a 'command not found' code.
BUG=699173
Change-Id: I0483ab0d1d0b6a3dfcfd26f2d9644817b5b5284f
Reviewed-on: https://chromium-review.googlesource.com/455537
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
It's too ridiculously slow on Windows and Mac, and there's very little benefit to finding files that were "copied" from an historical file (as
opposed to one that's in the current patch).
BUG=544889
Review-Url: https://codereview.chromium.org/2488823002
A quick "git grep gsutil" reveals that this is no longer being used, and all
references to gsutil are pointed to gsutil.py.
BUG=
Review-Url: https://codereview.chromium.org/2280023003
Jordan
Scott Lee
Yiwei Zhang
Mike Frysinger
Gavin Mak
Anne Redulla
Joanna Wang
Josip Sokcevic
Edward Lemur
Yannic Bonenberger
Dan Field
Edward Lemur
Mike Frysinger
James Darpinian
Raul Tambre
Raul E Rangel
Mrunal Kapade
Ned Nguyen
Daniel Bratell
Aaron Gable
Mun Yong Jang
Paweł Hajdan, Jr
Michael Anthony Knyszek
Andrii Shyshkalov
Mike Stipicevic
Sergiy Byelozyorov
scottmg
hinoka