As we shift CrOS to 3.11 entirely, we'll stop testing 3.8, so start
pushing people to upgrade to 3.11. This way when we eventually
require 3.11, people won't be surprised.
Bug: 318532035
Change-Id: I3be6b4cce56321984ff4aad4f6998660be29550c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6165449
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Alex Klein <saklein@chromium.org>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
The background is we maintain a fork of a fork of cros and as we're
moving to submodules this is what our repo looks like e.g. chromite is
at the top, and it's using submodules.
It doesn't seem like this would negatively affect anyone else, and would
make our system a lot simpler.
Change-Id: Ib1c9fd95a36e55fc13bede9bb539daedd5efe0ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5132338
Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Since citc doesn't support gitignore, it doesn't like it when you
dirty checkouts with pyc/pyo files. Disable it here when running
the launchers.
Change-Id: I0fd65da489d477bcc3027cf0059ce7122bb90c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4983229
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: George Engelbrecht <engeg@google.com>
Leave the recipes/ code at 2 space to match the rest of the recipes
project in other repos.
Reformatted using:
files=( $(
git ls-tree -r --name-only HEAD | \
grep -Ev -e '^(third_party|recipes)/' | \
grep '\.py$';
git grep -l '#!/usr/bin/env.*python' | grep -v '\.py$'
) )
parallel ./yapf -i -- "${files[@]}"
~/chromiumos/chromite/contrib/reflow_overlong_comments "${files[@]}"
The files that still had strings that were too long were manually
reformatted because they were easy and only a few issues.
autoninja.py
clang_format.py
download_from_google_storage.py
fix_encoding.py
gclient_utils.py
git_cache.py
git_common.py
git_map_branches.py
git_reparent_branch.py
gn.py
my_activity.py
owners_finder.py
presubmit_canned_checks.py
reclient_helper.py
reclientreport.py
roll_dep.py
rustfmt.py
siso.py
split_cl.py
subcommand.py
subprocess2.py
swift_format.py
upload_to_google_storage.py
These files still had lines (strings) that were too long, so the pylint
warnings were suppressed with a TODO.
auth.py
gclient.py
gclient_eval.py
gclient_paths.py
gclient_scm.py
gerrit_util.py
git_cl.py
presubmit_canned_checks.py
presubmit_support.py
scm.py
Change-Id: Ia6535c4f2c48d46b589ec1e791dde6c6b2ea858f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4836379
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Our developer guide has stated that Python 3.8 or greater is required
since CL:4303078. Additionally, this launcher has been warning users
of Python 3.6 and 3.7 for quite some time now. Finally, Python 3.8 is
now the default interpeter in CrOS SDK.
I think it's safe to make 3.8 the hard minimum version.
R=vapier@chromium.org
Bug: b:187794810
Change-Id: I0d71ba916dafedd08757edc5beff539b788494bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4483617
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
In preparation for updating chromite requirements to Python 3.8,
start warning when people run with older versions.
Bug: b:187794810
Change-Id: I7b5430384c0818bca05df5642d8583fd16204105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4062907
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
We moved chromite to require python 3.6 all the time, so update
the wrappers to match.
Bug: 997354
Test: `cros_sdk` still works
Change-Id: I78f5dc101f98a074fdc92a1f270395e2d04a2ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2324825
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
This is a reland of 35b70cac56.
With the recent vpython3 PATH fixes, hopefully this should pass now.
Original change's description:
> cros: switch CrOS programs to python3
>
> We start warning if people have outdated systems.
>
> Bug: 997354
> Test: `cros --help` uses python3 now
> Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Bug: 997354
Change-Id: Ic7e040af6a34d112cd0a1c1421cdd25bc557ee19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052625
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
We start warning if people have outdated systems.
Bug: 997354
Test: `cros --help` uses python3 now
Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
The support/ dir has only ever been used to host a single CrOS file.
We can move that to `cros` (which is the primary tool in the CrOS
world), and have the few other wrapped programs point to that.
Bug: None
Change-Id: I3ba3cc7375d357d62fb464e1b6dc37e73bc83cb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1876639
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
The cros wrapper in depot_tools is a centralized wrapper for all cros
commands. Adding this to depot_tools allows developers to run the 'cros'
tool from anywhere inside a Chrome OS checkout.
BUG=none
TEST=Verify the cros wrapper works.
Review URL: https://chromiumcodereview.appspot.com/11600002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173491 0039d316-1c4b-4281-b951-d872f2087c98
Mike Frysinger
Ruben Rodriguez Buchillon
Mike Frysinger
Mike Frysinger
Jack Rosenthal
Brian Ryner
John Budorick
davidjames@chromium.org