This CL updates the CIPD client in depot_tools to the latest version.
The new cipd client has `-json-output` option for auth-info subcommand. https://crrev.com/c/5467900
Change-Id: Iae0396a159a67c1a59af8dfe5e74b755ccfd1475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5772153
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
This is to pick up 95f2bed7f4
which should help with cache invalidation woes (specifically should help
prevent evicting cache items which are just about to be used).
This has already been rolled out to swarming.
R=bryner, chanli, fancl
Bug: 1374490
Change-Id: I0377c2092fc59c36c49eed8a0960df6b34cb73df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4599527
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Fixed issue where token to paste was refreshing fast and made it difficult to copy in terminal emulators such as Alacritty and Konsole.
Bug:1411481, 1406354
Change-Id: I260c18c4aca873530d7ead55ab8826b01edffd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4231602
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
Per go/oauth-oob-deprecation we are switching to go/luci-cli-oauth-login updating the packages that use luci-auth.
Bug:1406354
Change-Id: I3fc0fd2cc88d395f28e080d90aaaaae672c33da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4195020
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Leina Sun <sunxiaodi@google.com>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
Reviewed-by: Sean McCullough <seanmccullough@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
This actually updates the CIPD client to a version that has
a windows-arm64 build, as well as modifies the bootstrap script
to support multiple possible Windows platforms (which is very
similar to what was done to support mac-arm64 on OSX).
By default windows-amd64 is still used everywhere, even on arm64 OS.
To opt-in into windows-arm64, create a file .cipd_client_platform
under depot_tools directory with a single line "windows-arm64".
The bootstrap script now recognizes this file (if it exists) and
rebootstraps the CIPD client if the platform changes. Since this
check needs to happen on every CIPD invocation, it is done in
the batch file, to avoid hitting relatively heavy Powershell on
the hot path.
Finally, do some minor style cleanup in the powershell script to
make it look more consistent.
CIPD client change log:
9cc9fd49..5252f4fc7/cipd
R=bryner@google.com
Change-Id: I4fe5c4ea5e0b5cbb43e7b8c4702dc9fb0627c056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4153336
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Should be landed once the new cipd is rolled out everywhere (including
bots)
Bug: 1329641
Change-Id: I32edaa167dd26dbf891435215eeb7c833aba091f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3680100
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
This version was built with go1.17. Has no other significant
changes.
R=iannucci@chromium.org, chanli@chromium.org
Change-Id: Ic1b3aa1fd74f5e87b7e0429fa0f52d7989400ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3651160
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
It now fetches and installs packages in parallel. This has a side
effect that the order of unzipping of packages in a manifest is
non-deterministic and depends on when particular packages finish
downloading.
To be able to show progress of parallel operations there's also
a new terminal UI with progress bars. It activates when running
CIPD at `info` logging level (default) if the stderr is attached
to a terminal (i.e. not piping to a file or the recipe engine).
Two new env vars control the new behavior:
* CIPD_PARALLEL_DOWNLOADS: set to 0 to completely disable
parallelism and restore pre 2.6.0 behavior. Set to 1 to fetch
and unzip packages in paralle, but fetch at most one package
at once. Default is 4.
* CIPD_SIMPLE_TERMINAL_UI: set to 1 to use log-based UI instead
of progress bars.
R=iannucci@chromium.org
BUG=1217435
Change-Id: I16815dbc397137fbb8ef09e09d0a04c77660c0c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2993750
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
All packages except mac-amd64 ones are built with go1.16. mac-amd64
are built with go1.15, to preserve OSX 10.10/10.11 compatibility.
Note that we still use mac-amd64 even on arm64 OSX, since
the bootstrap script still installs mac-amd64 version of CIPD.
R=iannucci@chromium.org, tandrii@chromium.org
BUG=1102967
Change-Id: I8fdb27397fbbf238fe39e81305d4642a0500ab33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2699690
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
It was built with go1.15 which has a bug in deflate implementation
which may result in corruption when uploading >2GB files.
R=iannucci@chromium.org
BUG=1129704
Change-Id: Id61eaaed5dd18d8e51ac5150a9d29a5825805a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2418899
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Includes bug fix for crbug.com/936911 and no other changes.
R=tandrii@chromium.org, iannucci@chromium.org
BUG=936911
Change-Id: I92e6725dc16b513579db87b81e389f9d61bdf62b
Reviewed-on: https://chromium-review.googlesource.com/c/1496034
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Includes a bug fix for incorrect handling of subcommands with typos in them. No
other changes.
BUG=931755
R=iannucci@chromium.org
Change-Id: I4a3c523452939bdb5a6f26637f1f7b4a2eeb4b0c
Reviewed-on: https://chromium-review.googlesource.com/c/1474373
Auto-Submit: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
The most notable change is in how the integrity of the tag cache file is
checked. Once deployed, existing tag cache files will be considered invalid and
wiped.
The only observable side effect is the following line in the log:
"can't deserialize tag cache - no sha256 is recorded in the file"
R=tandrii@chromium.org, iannucci@chromium.org
Change-Id: I7ea300a4e7ad8be0c1d42ae561c5202420d2db62
Reviewed-on: https://chromium-review.googlesource.com/c/1327823
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
The new version uses SHA256 for uploads by default. It also fully supports
$ResolvedVersions and 'selfupdate-roll'.
The roll was generated by:
$ ./cipd selfupdate-roll \
-version-file cipd_client_version \
-version git_revision:fb963f0f43e265a65fb7f1f202e17ea23e947063
BUG=821194, 870166
R=nodir@chromium.org, iannucci@chromium.org
Change-Id: If7c23c43ff2c1bf50c9c50f4e9e17a23e84859b9
Reviewed-on: https://chromium-review.googlesource.com/1227431
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Linux and OSX only for now. This also rolls CIPD client to a version that
supports pinned hashes (v2.2.5).
CIPD_CLIENT_VER and CIPD_CLIENT_SRV are no longer supported as env vars, since
it makes no sense when pinning hashes of the binaries at specific version on
the specific backend.
Also somewhat cleanup 'cipd' script to use "${VAR}", stderr and colored output
consistently.
R=iannucci@chromium.org, nodir@chromium.org
BUG=870166, 874586
Change-Id: Iac67fbb6b5d07dcd81d44536737b03b146f1ad14
Reviewed-on: https://chromium-review.googlesource.com/1176727
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
This reverts commit eebc3d8232.
Reason for revert: crbug.com/874586
Original change's description:
> [cipd] Check CIPD client hash against pinned SHA256 during updates.
>
> Linux and OSX only for now. This also rolls CIPD client to a version that
> supports pinned hashes (v2.2.5).
>
> CIPD_CLIENT_VER and CIPD_CLIENT_SRV are no longer supported as env vars, since
> it makes no sense when pinning hashes of the binaries at specific version on
> the specific backend.
>
> Also somewhat cleanup 'cipd' script to use "${VAR}", stderr and colored output
> consistently.
>
> R=iannucci@chromium.org, nodir@chromium.org
> BUG=870166
>
> Change-Id: I9e61f9f8fbdcf10985c52828b2bfbec64b4234f0
> Reviewed-on: https://chromium-review.googlesource.com/1171957
> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
TBR=iannucci@chromium.org,vadimsh@chromium.org,nodir@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 870166
Change-Id: I9aa8e7a7f07520aa69d366c76e4dbccae345bc00
Reviewed-on: https://chromium-review.googlesource.com/1175294
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Linux and OSX only for now. This also rolls CIPD client to a version that
supports pinned hashes (v2.2.5).
CIPD_CLIENT_VER and CIPD_CLIENT_SRV are no longer supported as env vars, since
it makes no sense when pinning hashes of the binaries at specific version on
the specific backend.
Also somewhat cleanup 'cipd' script to use "${VAR}", stderr and colored output
consistently.
R=iannucci@chromium.org, nodir@chromium.org
BUG=870166
Change-Id: I9e61f9f8fbdcf10985c52828b2bfbec64b4234f0
Reviewed-on: https://chromium-review.googlesource.com/1171957
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Patrick Meiring
Junji Watanabe
Chris Lewis
Camilo Jacomet
Robert Iannucci
Vadim Shtayura
Stephanie Kim
Matt Kotsenas
Andrii Shyshkalov