Commit Graph

12 Commits (main)

Author SHA1 Message Date
Chenlin Fan e5d7ea3c01 add peep-software-deploy team to luci owners
Change-Id: Ib6a2b54d04a97eecef35972b415a1c827ad59c36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4844835
Auto-Submit: Chenlin Fan <fancl@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
2 years ago
Chenlin Fan fc36eba70b Revert "New vpython to depot_tools"
This reverts commit 43083529de.

Reason for revert: crbug.com/1470122

Original change's description:
> New vpython to depot_tools
>
> This is a reland of https://crrev.com/c/4653897
> Fixed the issue for cipd wrapper. Now all environment variables should
> be perserved when invoking cipd: https://crrev.com/c/4669637
>
> 1. virtualenv field in the spec is ignored.
> 2. --vpython-tool removed support for delete and help subcommands.
> 3. --vpython-tool installed removed support for naming venv.
> 4. removed support for -vpython-interpreter.
> 5. removed support for searching interpreters in host PATH.
> 6. python 2.7 is available only if the binary is invoked as `vpython`.
> 7. fixed a bug that passes invalid vpython arguments to the script,
>    which may be silently ignored.
> 8. python_version in the vpython_spec must specify a minor version
>    (python_version: "3" is not valid anymore).
> 9. vpython now requires the cipd binary to be present in PATH, which is
>    true already when using Swarming or depot_tools.
>
> Also updates the LUCI_OWNERS to add peep-software-deploy team.
>
> Bug:1415212
> Change-Id: Ie541a2a60bef829a976a13db9a6732b406c4d878
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4719827
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
> Auto-Submit: Chenlin Fan <fancl@chromium.org>
> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

Bug: 1415212
Change-Id: I6ca32066acd977a293f8b8f42697c383cc2a93fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4751179
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
2 years ago
Chenlin Fan 43083529de New vpython to depot_tools
This is a reland of https://crrev.com/c/4653897
Fixed the issue for cipd wrapper. Now all environment variables should
be perserved when invoking cipd: https://crrev.com/c/4669637

1. virtualenv field in the spec is ignored.
2. --vpython-tool removed support for delete and help subcommands.
3. --vpython-tool installed removed support for naming venv.
4. removed support for -vpython-interpreter.
5. removed support for searching interpreters in host PATH.
6. python 2.7 is available only if the binary is invoked as `vpython`.
7. fixed a bug that passes invalid vpython arguments to the script,
   which may be silently ignored.
8. python_version in the vpython_spec must specify a minor version
   (python_version: "3" is not valid anymore).
9. vpython now requires the cipd binary to be present in PATH, which is
   true already when using Swarming or depot_tools.

Also updates the LUCI_OWNERS to add peep-software-deploy team.

Bug:1415212
Change-Id: Ie541a2a60bef829a976a13db9a6732b406c4d878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4719827
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Chenlin Fan <fancl@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
2 years ago
Vadim Shtayura 631522ca84 Revert "New vpython to depot_tools"
This reverts commit ae21f6a5ec.

Reason for revert: crbug.com/1462502#c11

Original change's description:
> New vpython to depot_tools
>
> 1. virtualenv field in the spec is ignored.
> 2. --vpython-tool removed support for delete and help subcommands.
> 3. --vpython-tool installed removed support for naming venv.
> 4. removed support for -vpython-interpreter.
> 5. removed support for searching interpreters in host PATH.
> 6. python 2.7 is available only if the binary is invoked as `vpython`.
> 7. fixed a bug that passes invalid vpython arguments to the script,
>    which may be silently ignored.
> 8. python_version in the vpython_spec must specify a minor version
>    (python_version: "3" is not valid anymore).
> 9. vpython now requires the cipd binary to be present in PATH, which is
>    true already when using Swarming or depot_tools.
>
> Also updates the LUCI_OWNERS to add peep-software-deploy team.
>
> Bug:1415212
> Change-Id: I295c1aad1516a0c36eefa2ae04e85cabb518bda8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4653897
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Chenlin Fan <fancl@chromium.org>

Bug: 1415212
Change-Id: I3d00edf7d2a0d61d30b263362d35704d9f63a44d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4668482
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2 years ago
Chenlin Fan ae21f6a5ec New vpython to depot_tools
1. virtualenv field in the spec is ignored.
2. --vpython-tool removed support for delete and help subcommands.
3. --vpython-tool installed removed support for naming venv.
4. removed support for -vpython-interpreter.
5. removed support for searching interpreters in host PATH.
6. python 2.7 is available only if the binary is invoked as `vpython`.
7. fixed a bug that passes invalid vpython arguments to the script,
   which may be silently ignored.
8. python_version in the vpython_spec must specify a minor version
   (python_version: "3" is not valid anymore).
9. vpython now requires the cipd binary to be present in PATH, which is
   true already when using Swarming or depot_tools.

Also updates the LUCI_OWNERS to add peep-software-deploy team.

Bug:1415212
Change-Id: I295c1aad1516a0c36eefa2ae04e85cabb518bda8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4653897
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
2 years ago
randymaldonado 9ceb914b2f Updating LUCI_OWNERS
Change-Id: I0305b90a5f7fd6539472edea162106935afcc41d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4411906
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Randy Maldonado <randymaldonado@google.com>
Commit-Queue: Randy Maldonado <randymaldonado@google.com>
2 years ago
Scott Lee 376ce660a5 Remove tandrii@ from OWNERS under depot_tools
Missing changes from https://chromium-review.googlesource.com/q/owner:tandrii%2540google.com+%2522remove+tandrii%2540%2522
(and nodir@)

Change-Id: I9ae573f2b01bcc5e65e17202b90bc724210cd971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3252670
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
3 years ago
Andrii Shyshkalov 7b7bdcd075 tandrii: switch OWNERS to @google.com account.
R=tikuta
TBR=tandrii@chromium.org

Change-Id: I8ce4eb78e8ec2cf4c6d816b8a5ca63dbb0de66c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2411985
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
5 years ago
Chan Li 8e500174f4 [depot_tools] Roll led to latest
This is to include the change of https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2343646

Bug: 1099018
Change-Id: Iade31e972e45d59542e7b4ee24dfd1136056eb5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2412992
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
5 years ago
Scott Lee 5664586374 [resultdb] add ddoman@ to depot_tools/LUCI_OWNERS
ddoman@ frequently moves the cipd pin of infra/tools/rdb package.

R=iannucci@chromium.org
CC=chanli@chromium.org,nodir@chromium.org,robertocn@chromium.org,tandrii@google.com,vadimsh@chromium.org

Change-Id: I26b3eae79a9b917af6197c5c42db5303a99a2c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2358897
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
5 years ago
Andrii Shyshkalov e521cd14da Make vadimsh@ an owner of cipd*.
R=ehmaldonado, vadimsh

Change-Id: I8376663dfd6227175b3ccc46ea31038fbfa723b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2142734
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
Robert Iannucci a4f9aa0375 Refactor OWNERS for LUCI-related tools.
R=ehmaldonado@chromium.org, maruel@chromium.org, nodir@chromium.org, tandrii@chromium.org

Change-Id: I72e842bb07cf0a19d7afc417027ee7a70dddfd51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2077460
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
5 years ago