From ff5d25bb10e4b1201b9f8f50bcf528ab45a6025f Mon Sep 17 00:00:00 2001
From: Gavin Mak <gavinmak@google.com>
Date: Mon, 24 Oct 2022 21:44:13 +0000
Subject: [PATCH] Add canned presubmit checks for corp links

Only googlesource links should be used publicly.

Bug:b/253074243
Change-Id: Id972821acbfde635717e21bba879880e5312f92c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3955706
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
---
 presubmit_canned_checks.py  | 32 ++++++++++++++++++++++++++++++++
 tests/presubmit_unittest.py | 12 ++++++++++++
 2 files changed, 44 insertions(+)

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 1800e324f..d587d4a34 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -63,6 +63,8 @@ OFF_UNLESS_MANUALLY_ENABLED_LINT_FILTERS = [
     '-whitespace/tab',
 ]
 
+_CORP_LINK_KEYWORD = '.corp.google'
+
 ### Description checks
 
 def CheckChangeHasBugField(input_api, output_api):
@@ -108,6 +110,17 @@ def CheckDoNotSubmitInDescription(input_api, output_api):
   return []
 
 
+def CheckCorpLinksInDescription(input_api, output_api):
+  """Checks that the description doesn't contain corp links."""
+  if _CORP_LINK_KEYWORD in input_api.change.DescriptionText():
+    return [
+        output_api.PresubmitPromptWarning(
+            'Corp link is present in the changelist description.')
+    ]
+
+  return []
+
+
 def CheckChangeHasDescription(input_api, output_api):
   """Checks the CL description is not empty."""
   text = input_api.change.DescriptionText()
@@ -214,6 +227,17 @@ def CheckDoNotSubmitInFiles(input_api, output_api):
   return []
 
 
+def CheckCorpLinksInFiles(input_api, output_api, source_file_filter=None):
+  """Checks that files do not contain a corp link."""
+  errors = _FindNewViolationsOfRule(
+      lambda _, line: _CORP_LINK_KEYWORD not in line, input_api,
+      source_file_filter)
+  text = '\n'.join('Found corp link in %s' % loc for loc in errors)
+  if text:
+    return [output_api.PresubmitPromptWarning(text)]
+  return []
+
+
 def GetCppLintFilters(lint_filters=None):
   filters = OFF_UNLESS_MANUALLY_ENABLED_LINT_FILTERS[:]
   if lint_filters is None:
@@ -1463,6 +1487,11 @@ def PanProjectChecks(input_api, output_api,
   results.extend(input_api.canned_checks.CheckLicense(
       input_api, output_api, license_header, project_name,
       source_file_filter=sources))
+  snapshot("checking corp links in files")
+  results.extend(
+      input_api.canned_checks.CheckCorpLinksInFiles(input_api,
+                                                    output_api,
+                                                    source_file_filter=sources))
 
   if input_api.is_committing:
     if global_checks:
@@ -1478,6 +1507,9 @@ def PanProjectChecks(input_api, output_api,
           input_api, output_api))
       results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription(
           input_api, output_api))
+      results.extend(
+          input_api.canned_checks.CheckCorpLinksInDescription(
+              input_api, output_api))
       if input_api.change.scm == 'git':
         snapshot("checking for commit objects in tree")
         results.extend(input_api.canned_checks.CheckForCommitObjects(
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index 814cbf630..9da1a2bfb 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -1953,6 +1953,18 @@ class CannedChecksUnittest(PresubmitTestsBase):
         'DO NOTSUBMIT', None, 'DO NOT ' + 'SUBMIT', None,
         presubmit.OutputApi.PresubmitError)
 
+  def testCannedCheckCorpLinksInDescription(self):
+    self.DescriptionTest(presubmit_canned_checks.CheckCorpLinksInDescription,
+                         'chromium.googlesource.com',
+                         'chromium.git.corp.google.com',
+                         presubmit.OutputApi.PresubmitPromptWarning, False)
+
+  def testCannedCheckCorpLinksInFiles(self):
+    self.ContentTest(presubmit_canned_checks.CheckCorpLinksInFiles,
+                     'chromium.googlesource.com', None,
+                     'chromium.git.corp.google.com', None,
+                     presubmit.OutputApi.PresubmitPromptWarning)
+
   def testCheckChangeHasNoStrayWhitespace(self):
     self.ContentTest(
         lambda x,y,z: