From fe5a0b128992f5475334f48d51cdfa67e7abe2ca Mon Sep 17 00:00:00 2001 From: Josip Sokcevic Date: Mon, 30 Jan 2023 18:16:07 +0000 Subject: [PATCH] Use default number of cores for gclient jobs Instead of always setting jobs to 1 for ARM (which includes Mac), use number of cores. Some old boards have not worked well with parallel sync, but I don't have historical context was going on. My assumption is that those boards were single-core. See: https://codereview.chromium.org/10116033 R=aravindvasudev@google.com Bug: 1410757 Change-Id: I0b7e3363375ba719c73d4d7141e6cab34bf7d32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4198732 Reviewed-by: Dirk Pranke Reviewed-by: Aravind Vasudevan Commit-Queue: Josip Sokcevic --- gclient.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gclient.py b/gclient.py index 8ec13f015..36a6f119e 100755 --- a/gclient.py +++ b/gclient.py @@ -3355,9 +3355,9 @@ class OptionParser(optparse.OptionParser): optparse.OptionParser.__init__( self, version='%prog ' + __version__, **kwargs) - # Some arm boards have issues with parallel sync. + # Some old arm boards have issues with parallel sync, so use default cores. if platform.machine().startswith('arm'): - jobs = 1 + jobs = gclient_utils.NumLocalCpus() else: jobs = max(8, gclient_utils.NumLocalCpus())