From fbee165093b0a64447e56d18943fcda7faaee42c Mon Sep 17 00:00:00 2001 From: Andrii Shyshkalov Date: Mon, 10 Apr 2017 14:00:51 +0200 Subject: [PATCH] git cl: remove temporary workaround of invisible unicode char in emails. PolyGerrit used to surround emails with invisible unicode char, which resulted in reviewers not being found by Gerrit. It has since been fixed (handled in Google internal bug b/34702620). R=sergiyb@chromium.org Change-Id: I43ade0ef23d88611081744eff57129a69b5176c8 Reviewed-on: https://chromium-review.googlesource.com/472808 Reviewed-by: Sergiy Byelozyorov Commit-Queue: Andrii Shyshkalov --- git_cl.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/git_cl.py b/git_cl.py index a3b8b860d7..b4dad7a4a4 100755 --- a/git_cl.py +++ b/git_cl.py @@ -2958,12 +2958,7 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase): reviewers = change_desc.get_reviewers() if reviewers: - # TODO(tandrii): remove this horrible hack once (Poly)Gerrit fixes their - # side for real (b/34702620). - def clean_invisible_chars(email): - return email.decode('unicode_escape').encode('ascii', 'ignore') - refspec_opts.extend('r=' + clean_invisible_chars(email).strip() - for email in reviewers) + refspec_opts.extend('r=' + email.strip() for email in reviewers) if options.private: refspec_opts.append('draft')