From f46c20fcee6e6a0a7d75788847632cd4ac18e2e9 Mon Sep 17 00:00:00 2001 From: tandrii Date: Wed, 14 Sep 2016 06:17:05 -0700 Subject: [PATCH] codereview.settings: add GIT_NUMBER_FOOTER setting. This will be used in repositories that use Cr-Commit-Position footers to generate them at the time of git cl land instead of gnumbd. R=iannucci@chromium.org BUG=642493 Review-Url: https://codereview.chromium.org/2324583002 --- git_cl.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/git_cl.py b/git_cl.py index 2d9ced968..6ff4a8fbe 100755 --- a/git_cl.py +++ b/git_cl.py @@ -646,6 +646,7 @@ class Settings(object): self.project = None self.force_https_commit_url = None self.pending_ref_prefix = None + self.git_number_footer = None def LazyUpdateIfNeeded(self): """Updates the settings from a codereview.settings file, if available.""" @@ -881,6 +882,14 @@ class Settings(object): 'pending-ref-prefix', error_ok=True) return self.pending_ref_prefix + def GetHasGitNumberFooter(self): + # TODO(tandrii): this has to be removed after Rietveld is read-only. + # see also bugs http://crbug.com/642493 and http://crbug.com/600469. + if not self.git_number_footer: + self.git_number_footer = self._GetRietveldConfig( + 'git-number-footer', error_ok=True) + return self.git_number_footer + def _GetRietveldConfig(self, param, **kwargs): return self._GetConfig('rietveld.' + param, **kwargs) @@ -2967,6 +2976,7 @@ def LoadCodereviewSettingsFromFile(fileobj): SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True) SetProperty('project', 'PROJECT', unset_error_ok=True) SetProperty('pending-ref-prefix', 'PENDING_REF_PREFIX', unset_error_ok=True) + SetProperty('git-number-footer', 'GIT_NUMBER_FOOTER', unset_error_ok=True) SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK', unset_error_ok=True)