From eea4dfbe3211f1ea6bf5a151e18231842b119d64 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Thu, 25 Mar 2010 01:56:37 +0000 Subject: [PATCH] When the tree is closed, it's closed. Convert the warning to error. Review URL: http://codereview.chromium.org/1232007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@42572 0039d316-1c4b-4281-b951-d872f2087c98 --- presubmit_canned_checks.py | 4 ++-- tests/presubmit_unittest.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index 52081912b..901a755ad 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -352,8 +352,8 @@ def CheckTreeIsOpen(input_api, output_api, url, closed): connection.close() if input_api.re.match(closed, status): long_text = status + '\n' + url - return [output_api.PresubmitPromptWarning('The tree is closed.', - long_text=long_text)] + return [output_api.PresubmitError('The tree is closed dude!', + long_text=long_text)] except IOError: pass return [] diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py index 084d96d2d..a1b145de9 100755 --- a/tests/presubmit_unittest.py +++ b/tests/presubmit_unittest.py @@ -1430,7 +1430,7 @@ class CannedChecksUnittest(PresubmitTestsBase): input_api, presubmit.OutputApi, url='url_to_closed', closed='0') self.assertEquals(len(results), 1) self.assertEquals(results[0].__class__, - presubmit.OutputApi.PresubmitPromptWarning) + presubmit.OutputApi.PresubmitError) def testRunPythonUnitTestsNoTest(self): input_api = self.MockInputApi(None, False)