From ed89aaf597c572bb7d8aa0d8ae686feea35fb8c3 Mon Sep 17 00:00:00 2001 From: Josip Sokcevic Date: Wed, 9 Oct 2024 16:47:50 +0000 Subject: [PATCH] Update freeze dates for 2024, internal conference Change-Id: If5d90a728ce765a7c6ad451a58698c59ec563b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5913187 Commit-Queue: Josip Sokcevic Reviewed-by: Erik Staab --- PRESUBMIT.py | 4 ++++ presubmit_canned_checks.py | 14 +++++++++----- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 685da9449..2824e50a1 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -191,3 +191,7 @@ def CheckPatchFormatted(input_api, output_api): return input_api.canned_checks.CheckPatchFormatted(input_api, output_api, check_clang_format=False) + + +def CheckFreeze(input_api, output_api): + return input_api.canned_checks.CheckInfraFreeze(input_api, output_api) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index 466f551f3..a9eb0309c 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -907,8 +907,9 @@ def CheckChromiumDependencyMetadata(input_api, output_api, file_filter=None): _IGNORE_FREEZE_FOOTER = 'Ignore-Freeze' _FREEZE_TZ = datetime.timezone(-datetime.timedelta(hours=8), 'PST') -_FREEZE_START = datetime.datetime(2023, 12, 15, 0, 0, tzinfo=_FREEZE_TZ) -_FREEZE_END = datetime.datetime(2024, 1, 2, 0, 0, tzinfo=_FREEZE_TZ) +_FREEZE_START = datetime.datetime(2024, 10, 12, 0, 0, tzinfo=_FREEZE_TZ) +_FREEZE_END = datetime.datetime(2024, 10, 19, 0, 0, tzinfo=_FREEZE_TZ) +_FREEZE_DETAILS = 'Internal infra conference' def CheckInfraFreeze(input_api, output_api, @@ -969,9 +970,12 @@ def CheckInfraFreeze(input_api, else: report_type = output_api.PresubmitError return [ - report_type('There is a prod infra freeze in effect from {} until {},' - 'the following files cannot be modified:\n {}'.format( - _FREEZE_START, _FREEZE_END, '\n '.join(files))) + report_type('There is a prod infra freeze in effect from {} until {}:\n' + '\t{}\n\n' + 'The following files cannot be modified:\n {}.\n\n' + 'Set git-footer "{}" to override.'.format( + _FREEZE_START, _FREEZE_END, _FREEZE_DETAILS, + '\n '.join(files), _IGNORE_FREEZE_FOOTER)) ]