From e75b940aeabcca1ea7e38881231e73a32a352753 Mon Sep 17 00:00:00 2001 From: Gavin Mak Date: Tue, 30 Apr 2024 22:32:26 +0000 Subject: [PATCH] Skip CheckForCommitObjects if not git change The check relies on `git ls-tree` which is unavailable for non-git workspaces. Bug: 333744051 Change-Id: Ib9151a283c3bf543390f2cf06e0ce213051fb509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5503095 Reviewed-by: Josip Sokcevic Commit-Queue: Gavin Mak --- presubmit_canned_checks.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index 4dbbcc4bd..e09d9428a 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -1957,6 +1957,12 @@ def CheckForCommitObjects(input_api, output_api): Returns: A presubmit error if a commit object is not expected. """ + if input_api.change.scm != 'git': + return [ + output_api.PresubmitNotifyResult( + 'Non-git workspace detected, skipping CheckForCommitObjects.') + ] + # Get DEPS file. deps_file = input_api.os_path.join(input_api.PresubmitLocalPath(), 'DEPS') if not input_api.os_path.isfile(deps_file):