From e3a3fd45aa7f6c247d9e9ab0900164004294fc8d Mon Sep 17 00:00:00 2001 From: "dcheng@chromium.org" Date: Sat, 4 Oct 2014 06:47:08 +0000 Subject: [PATCH] Suppress readability/inheritance check for cpplint.py for now. This check never triggered before, since cpplint.py was looking for override not OVERRIDE. Since Chromium prefers override now, the linter is now (correctly) warning. However, the old Chromium convention (and the one implemented by the clang plugin) is to explicitly annotate all overrides with both virtual and override. The clang plugin code has been updated, but new binaries have not yet been built. Until clang rolls, suppress the warning. BUG=417463 TBR=stip@chromium.org Review URL: https://codereview.chromium.org/627163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292319 0039d316-1c4b-4281-b951-d872f2087c98 --- presubmit_canned_checks.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index a90c5ca5f..4f0472be1 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -109,9 +109,11 @@ def CheckChangeLintsClean(input_api, output_api, source_file_filter=None): # - runtime/int : Can be fixed long term; volume of errors too high # - runtime/virtual : Broken now, but can be fixed in the future? # - whitespace/braces : We have a lot of explicit scoping in chrome code. + # - readability/inheritance : Temporary, while the OVERRIDE and FINAL fixup + # is in progress. cpplint._SetFilters('-build/include,-build/include_order,-build/namespace,' '-readability/casting,-runtime/int,-runtime/virtual,' - '-whitespace/braces') + '-whitespace/braces,-readability/inheritance') # We currently are more strict with normal code than unit tests; 4 and 5 are # the verbosity level that would normally be passed to cpplint.py through