From d3af69947ef036f4db7f78a7e7cb8e5295daf6bd Mon Sep 17 00:00:00 2001 From: Debrian Figueroa Date: Fri, 12 Jul 2019 23:54:23 +0000 Subject: [PATCH] Add failure status on timeouts Change-Id: I6f7b0791172f9f4e7af278f8acb3f1ca986789d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1700390 Commit-Queue: Debrian Figueroa Reviewed-by: Stephen Martinis Reviewed-by: Robbie Iannucci --- recipes/recipe_modules/presubmit/api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recipes/recipe_modules/presubmit/api.py b/recipes/recipe_modules/presubmit/api.py index f1ae030a5..989576a9d 100644 --- a/recipes/recipe_modules/presubmit/api.py +++ b/recipes/recipe_modules/presubmit/api.py @@ -129,7 +129,7 @@ class PresubmitApi(recipe_api.RecipeApi): self.m.step.active_result.presentation.status = 'FAILURE' if self.m.step.active_result.exc_result.had_timeout: - # TODO(iannucci): Shouldn't we also mark failure on timeouts? + raw_result.status = common_pb2.FAILURE raw_result.summary_markdown += ( '\n\nTimeout occurred during presubmit step.') elif retcode == 1: