From d3acdc8c5765c59deb8efcb65e63218f829d0909 Mon Sep 17 00:00:00 2001 From: Rob Mohr Date: Fri, 27 Oct 2023 18:31:13 +0000 Subject: [PATCH] recipes: Remove unnecessary use of defer_results Bug: chromium:1495428 Change-Id: I266cb0d8cb101dc5ce8fb25622bb0d5d800ca27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4979598 Reviewed-by: Robbie Iannucci Commit-Queue: Robbie Iannucci Auto-Submit: Rob Mohr --- .../gerrit/examples/full.expected/basic.json | 2 +- recipes/recipe_modules/gerrit/examples/full.py | 11 +++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/recipes/recipe_modules/gerrit/examples/full.expected/basic.json b/recipes/recipe_modules/gerrit/examples/full.expected/basic.json index f99ca6c37..21ec778cd 100644 --- a/recipes/recipe_modules/gerrit/examples/full.expected/basic.json +++ b/recipes/recipe_modules/gerrit/examples/full.expected/basic.json @@ -727,7 +727,7 @@ }, { "failure": { - "humanReason": "1 out of 1 aggregated steps failed: Error querying for CL description: host:'https://chromium-review.googlesource.com' change:122; patchset:3" + "humanReason": "Error querying for CL description: host:'https://chromium-review.googlesource.com' change:122; patchset:3" }, "name": "$result" } diff --git a/recipes/recipe_modules/gerrit/examples/full.py b/recipes/recipe_modules/gerrit/examples/full.py index 0178771c1..93ba13205 100644 --- a/recipes/recipe_modules/gerrit/examples/full.py +++ b/recipes/recipe_modules/gerrit/examples/full.py @@ -89,12 +89,11 @@ def RunSteps(api): api.gerrit.abandon_change(host, 123, 'bad roll') - with api.step.defer_results(): - api.gerrit.get_change_description( - host, - change=122, - patchset=3, - step_test_data=api.gerrit.test_api.get_empty_changes_response_data) + api.gerrit.get_change_description( + host, + change=122, + patchset=3, + step_test_data=api.gerrit.test_api.get_empty_changes_response_data) def GenTests(api):