From d36fce44086cd531a01ee91114ff2955c502a603 Mon Sep 17 00:00:00 2001 From: Daniel Cheng Date: Tue, 21 Nov 2017 21:52:52 -0800 Subject: [PATCH] Fix silly bug in presubmit_support implementation of AppendCC. The executor needs to accumnulate more_cc, not overwrite them. Bug: 786386 Change-Id: Iadfe836ae9623f1b66d2db8209d347b5e61ccae8 Reviewed-on: https://chromium-review.googlesource.com/784553 Reviewed-by: Dirk Pranke Commit-Queue: Daniel Cheng --- presubmit_support.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/presubmit_support.py b/presubmit_support.py index f71a9b180..18ee1f422 100755 --- a/presubmit_support.py +++ b/presubmit_support.py @@ -1318,7 +1318,7 @@ class PresubmitExecuter(object): logging.debug('Running %s in %s', function_name, presubmit_path) result = eval(function_name + '(*__args)', context) logging.debug('Running %s done.', function_name) - self.more_cc = output_api.more_cc + self.more_cc.extend(output_api.more_cc) finally: map(os.remove, input_api._named_temporary_files) if not (isinstance(result, types.TupleType) or