From d32e1cb5717853a1837347884abc85149813c398 Mon Sep 17 00:00:00 2001 From: Takuto Ikuta Date: Mon, 20 May 2024 02:56:27 +0000 Subject: [PATCH] remove references to goma We don't use goma anymore. Bug: 41489832 Change-Id: Ia816ed49f55740090665f308da82781f60f64d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5545484 Auto-Submit: Takuto Ikuta Reviewed-by: Junji Watanabe Commit-Queue: Takuto Ikuta --- ninjalog.README.md | 11 +++++------ ninjalog_uploader.py | 3 --- tests/ninjalog_uploader_test.py | 4 ++-- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/ninjalog.README.md b/ninjalog.README.md index c24256452d..f4fc18182e 100644 --- a/ninjalog.README.md +++ b/ninjalog.README.md @@ -46,7 +46,6 @@ analysis: * host\_os, host\_cpu * target\_os, target\_cpu * symbol\_level - * use\_goma * is\_debug * is\_component\_build @@ -55,8 +54,8 @@ analysis: ## Why ninja log is collected? / How the collected logs are used? -We (goma team) collect build logs to find slow build tasks that harm developer's -productivity. Based on collected stats, we find the place/build tasks where we -need to focus on. Also we use collected stats to track chrome build performance -on developer's machine. We'll use this stats to measure how much we can/can't -improve build performance on developer's machine. +We (Chrome Browser Build team) collect build logs to find slow build tasks that +harm developer's productivity. Based on collected stats, we find the +place/build tasks where we need to focus on. Also we use collected stats to +track chrome build performance on developer's machine. We'll use this stats to +measure how much we can/can't improve build performance on developer's machine. diff --git a/ninjalog_uploader.py b/ninjalog_uploader.py index 0c649f54b5..0a3e7a314e 100755 --- a/ninjalog_uploader.py +++ b/ninjalog_uploader.py @@ -46,7 +46,6 @@ ALLOWLISTED_CONFIGS = ( "target_os", "treat_warnings_as_errors", "use_errorprone_java_compiler", - "use_goma", "use_remoteexec", "use_siso", ) @@ -145,8 +144,6 @@ def GetMetadata(cmdline, ninjalog): Returned metadata has schema defined in https://cs.chromium.org?q="type+Metadata+struct+%7B"+file:%5Einfra/go/src/infra/appengine/chromium_build_stats/ninjalog/ - - TODO(tikuta): Collect GOMA_* env var. """ build_dir = os.path.dirname(ninjalog) diff --git a/tests/ninjalog_uploader_test.py b/tests/ninjalog_uploader_test.py index 020fbacc68..0439c79581 100755 --- a/tests/ninjalog_uploader_test.py +++ b/tests/ninjalog_uploader_test.py @@ -82,11 +82,11 @@ class NinjalogUploaderTest(unittest.TestCase): 'default': { 'value': 'false' }, - 'name': 'use_goma' + 'name': 'use_remoteexec' }, ])), { 'is_component_build': 'true', - 'use_goma': 'false' + 'use_remoteexec': 'false' }) def test_get_ninjalog(self):