From d221731edef7744e938b339e6bc46c9c0ca5f2cb Mon Sep 17 00:00:00 2001 From: "nodir@chromium.org" Date: Mon, 21 Sep 2015 15:51:21 +0000 Subject: [PATCH] git-cl-try: fix "revision" property The revision property must be a part of `changes`, per https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/master/buildbucket/README.md R=tandrii@chromium.org BUG=534315 Review URL: https://codereview.chromium.org/1349343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296790 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/git_cl.py b/git_cl.py index de80a9f367..aef7c4ff93 100755 --- a/git_cl.py +++ b/git_cl.py @@ -267,9 +267,10 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category): print_text.append(' %s: %s' % (builder, tests)) parameters = { 'builder_name': builder, - 'changes': [ - {'author': {'email': issue_props['owner_email']}}, - ], + 'changes': [{ + 'author': {'email': issue_props['owner_email']}, + 'revision': options.revision, + }], 'properties': { 'category': category, 'issue': issue, @@ -278,7 +279,6 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category): 'patch_storage': 'rietveld', 'patchset': patchset, 'reason': options.name, - 'revision': options.revision, 'rietveld': rietveld_url, 'testfilter': tests, },