From d03bc634dccfd44069433f63fbebd7902067afe8 Mon Sep 17 00:00:00 2001 From: "tandrii@chromium.org" Date: Tue, 12 Apr 2016 14:17:26 +0000 Subject: [PATCH] Small refactor git cl py. R=sergiyb@chromium.org BUG= Review URL: https://codereview.chromium.org/1876923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299857 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/git_cl.py b/git_cl.py index 22d1d93f1..63d01adad 100755 --- a/git_cl.py +++ b/git_cl.py @@ -1451,10 +1451,10 @@ class _ChangelistCodereviewBase(object): @classmethod def IssueSetting(cls, branch): - return 'branch.%s.%s' % (branch, cls.IssueSettingPrefix()) + return 'branch.%s.%s' % (branch, cls.IssueSettingSuffix()) @classmethod - def IssueSettingPrefix(cls): + def IssueSettingSuffix(cls): """Returns name of git config setting which stores issue number for a given branch.""" raise NotImplementedError() @@ -1675,7 +1675,7 @@ class _RietveldChangelistImpl(_ChangelistCodereviewBase): return self._rpc_server @classmethod - def IssueSettingPrefix(cls): + def IssueSettingSuffix(cls): return 'rietveldissue' def PatchsetSetting(self): @@ -1968,7 +1968,7 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase): return self._gerrit_server @classmethod - def IssueSettingPrefix(cls): + def IssueSettingSuffix(cls): return 'gerritissue' def EnsureAuthenticated(self): @@ -4576,7 +4576,7 @@ def CMDcheckout(parser, args): branches = [] for cls in _CODEREVIEW_IMPLEMENTATIONS.values(): - branches.extend(find_issues(cls.IssueSettingPrefix())) + branches.extend(find_issues(cls.IssueSettingSuffix())) if len(branches) == 0: print 'No branch found for issue %s.' % target_issue return 1