From cd3fa0389e81aadcf5c41b7f90a56bed7bc6f1a0 Mon Sep 17 00:00:00 2001 From: Josip Sokcevic Date: Thu, 7 Dec 2023 22:33:16 +0000 Subject: [PATCH] [download_from_google_storage] Add envvar for num_threads R=engeg@google.com Change-Id: Iedfa8b1fb18a8687c134867d8db6ca9f738bb4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5100054 Reviewed-by: George Engelbrecht Commit-Queue: Josip Sokcevic --- download_from_google_storage.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/download_from_google_storage.py b/download_from_google_storage.py index 0af4fd7f6..1952815bd 100755 --- a/download_from_google_storage.py +++ b/download_from_google_storage.py @@ -537,7 +537,7 @@ def main(args): 'Must be used with -d/--directory') parser.add_option('-t', '--num_threads', - default=1, + default=0, type='int', help='Number of downloader threads to run.') parser.add_option('-d', @@ -661,6 +661,10 @@ def main(args): '--sha1_file or --directory') input_filename = args[0] + num_threads = options.num_threads + if not num_threads: + num_threads = max( + int(os.environ.get('DOWNLOAD_FROM_GOOGLE_STORAGE_THREADS', 1)), 1) # Set output filename if not specified. if not options.output and not options.directory: @@ -684,8 +688,8 @@ def main(args): try: return download_from_google_storage( - input_filename, base_url, gsutil, options.num_threads, - options.directory, options.recursive, options.force, options.output, + input_filename, base_url, gsutil, num_threads, options.directory, + options.recursive, options.force, options.output, options.ignore_errors, options.sha1_file, options.verbose, options.auto_platform, options.extract) except FileNotFoundError as e: