From cb5a8a3315beda3ae1afff2d84093b2eb92d8268 Mon Sep 17 00:00:00 2001 From: Allen Li Date: Tue, 25 Jun 2024 20:59:30 +0000 Subject: [PATCH] [git_cl] Fix ShouldUseSSO call (This did not error since this code path is unreachable, to be fixed in future CL) Bug: b/348024314 Change-Id: I115b36a828d5e525c54cebdbec5480514e395da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5651989 Reviewed-by: Yiwei Zhang Commit-Queue: Allen Li --- git_cl.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/git_cl.py b/git_cl.py index 9c6f91203..79f6903e6 100755 --- a/git_cl.py +++ b/git_cl.py @@ -3613,10 +3613,11 @@ def DownloadGerritHook(force): def ConfigureGitRepoAuth() -> None: """Configure the current Git repo authentication.""" + logging.debug('Configuring current Git repo authentication...') cl = Changelist() cwd = os.getcwd() gerrit_host = cl.GetGerritHost() - if gerrit_util.ShouldUseSSO(email): + if gerrit_util.ShouldUseSSO(): scm.GIT.SetConfig(cwd, f'credential.{gerrit_host}.helper', None,