From c42090858075c6827462bc2aaab6cca813279db2 Mon Sep 17 00:00:00 2001 From: "janx@chromium.org" Date: Thu, 18 Apr 2013 18:33:52 +0000 Subject: [PATCH] Control the order of gclient spec keys in fetch Follow the explicit iteration order of the spec keys array instead of relying on the arbitrary iteration order of the hashtable. BUG= Review URL: https://chromiumcodereview.appspot.com/13878009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@194973 0039d316-1c4b-4281-b951-d872f2087c98 --- fetch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fetch.py b/fetch.py index aca0f88d6..c78dfe722 100755 --- a/fetch.py +++ b/fetch.py @@ -102,7 +102,7 @@ class GclientGitCheckout(GclientCheckout, GitCheckout): assert 'solutions' in self.spec keys = ['solutions', 'target_os', 'target_os_only'] gclient_spec = '\n'.join('%s = %s' % (key, self.spec[key]) - for key in self.spec if key in keys) + for key in keys if key in self.spec) self.spec['gclient_spec'] = gclient_spec def exists(self):