From c39431ae2cd95ed79df8180095f1f1c9374fc35b Mon Sep 17 00:00:00 2001 From: "tandrii@chromium.org" Date: Thu, 28 Apr 2016 05:40:43 +0000 Subject: [PATCH] git cl try: don't skip presubmit builders, but set dry_run property. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 Review-Url: https://codereview.chromium.org/1926663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300265 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/git_cl.py b/git_cl.py index 0acb9cd59..7bd7c8ec1 100755 --- a/git_cl.py +++ b/git_cl.py @@ -337,6 +337,8 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category): 'rietveld': rietveld_url, }, } + if 'presubmit' not in builder.lower(): + parameters['properties']['dry_run'] = 'true' if tests: parameters['properties']['testfilter'] = tests if properties: @@ -4316,8 +4318,7 @@ def CMDtry(parser, args): for master, builders in cq_masters.iteritems(): for builder in builders: # Skip presubmit builders, because these will fail without LGTM. - if 'presubmit' not in builder.lower(): - masters.setdefault(master, {})[builder] = ['defaulttests'] + masters.setdefault(master, {})[builder] = ['defaulttests'] if masters: return masters