From c1a82cb1a9e7234c0b9a633f684225dee1185ab1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Hajdan=2C=20Jr?= Date: Tue, 22 Aug 2017 12:39:39 +0200 Subject: [PATCH] fetch_end_to_end_test: set env CHROME_HEADLESS=1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This should fix some config hangs such as "fetch android", which otherwise prompt to accept a Play Services license. Bug: none Change-Id: I4e3f59f9541a8e80f04b5b0a48d86e48a19e19bc Reviewed-on: https://chromium-review.googlesource.com/625876 Reviewed-by: Andrii Shyshkalov Commit-Queue: Paweł Hajdan Jr. --- recipes/recipes/fetch_end_to_end_test.expected/basic.json | 4 ++++ recipes/recipes/fetch_end_to_end_test.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/recipes/recipes/fetch_end_to_end_test.expected/basic.json b/recipes/recipes/fetch_end_to_end_test.expected/basic.json index e45b29fa8..9c85be709 100644 --- a/recipes/recipes/fetch_end_to_end_test.expected/basic.json +++ b/recipes/recipes/fetch_end_to_end_test.expected/basic.json @@ -81,6 +81,7 @@ ], "cwd": "[TMP_BASE]/fetch_end_to_end_test_depot_tools_tmp_1", "env": { + "CHROME_HEADLESS": "1", "DEPOT_TOOLS_UPDATE": "0" }, "env_prefixes": { @@ -101,6 +102,7 @@ "[TMP_BASE]/fetch_end_to_end_test_depot_tools_tmp_1" ], "env": { + "CHROME_HEADLESS": "1", "DEPOT_TOOLS_UPDATE": "0" }, "env_prefixes": { @@ -120,6 +122,7 @@ ], "cwd": "[TMP_BASE]/fetch_end_to_end_test_infra_tmp_2", "env": { + "CHROME_HEADLESS": "1", "DEPOT_TOOLS_UPDATE": "0" }, "env_prefixes": { @@ -140,6 +143,7 @@ "[TMP_BASE]/fetch_end_to_end_test_infra_tmp_2" ], "env": { + "CHROME_HEADLESS": "1", "DEPOT_TOOLS_UPDATE": "0" }, "env_prefixes": { diff --git a/recipes/recipes/fetch_end_to_end_test.py b/recipes/recipes/fetch_end_to_end_test.py index 7128ba350..07fad7096 100644 --- a/recipes/recipes/fetch_end_to_end_test.py +++ b/recipes/recipes/fetch_end_to_end_test.py @@ -27,7 +27,7 @@ def RunSteps(api): # Try to run "fetch" for each of the configs. It's important to use # the checkout under test. with api.context( - env={'DEPOT_TOOLS_UPDATE': '0'}, + env={'DEPOT_TOOLS_UPDATE': '0', 'CHROME_HEADLESS': '1'}, env_prefixes={'PATH': [api.path['checkout']]}): with api.step.defer_results(): for config_name in fetch_configs: