From bda81551fe6f1b9dbc13d828f1c878672c6c6f4c Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Wed, 23 Jul 2014 23:05:07 +0000 Subject: [PATCH] Remove confirmation from git cl land. It serves no purpose, and it's annoying when the presubmit checks take more than 2-3 seconds because I always switch off to another window, so I come back minutes later seeing this prompt waiting for me. R=stip@chromium.org BUG= Review URL: https://codereview.chromium.org/407413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285071 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 1 - tests/git_cl_test.py | 1 - 2 files changed, 2 deletions(-) diff --git a/git_cl.py b/git_cl.py index 72770a145..a2bc0ffbe 100755 --- a/git_cl.py +++ b/git_cl.py @@ -1944,7 +1944,6 @@ def SendUpstream(parser, args, cmd): branches = [base_branch, cl.GetBranchRef()] if not options.force: print_stats(options.similarity, options.find_copies, branches) - ask_for_data('About to commit; enter to confirm.') # We want to squash all this branch's commits into one commit with the proper # description. We do this by doing a "reset --soft" to the base branch (which diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py index f7f57b4cf..cc5325821 100755 --- a/tests/git_cl_test.py +++ b/tests/git_cl_test.py @@ -336,7 +336,6 @@ class TestGitCl(TestCase): 'refs/heads/working'],), (' PRESUBMIT.py | 2 +-\n' ' 1 files changed, 1 insertions(+), 1 deletions(-)\n')), - (('About to commit; enter to confirm.',), None), ((['git', 'show-ref', '--quiet', '--verify', 'refs/heads/git-cl-commit'],), (('', None), 0)),