From bbfc80f6b06ba774241033a3a87e5b9ce673a40c Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Tue, 22 Jun 2010 17:55:15 +0000 Subject: [PATCH] Add a warning when git-cl-upload-hook is modified to update git-cl accordingly. Review URL: http://codereview.chromium.org/2806020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@50481 0039d316-1c4b-4281-b951-d872f2087c98 --- PRESUBMIT.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 59b25bd45a..f3a1b8c77e 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -23,6 +23,7 @@ def CheckChangeOnUpload(input_api, output_api): output.extend(input_api.canned_checks.RunPythonUnitTests(input_api, output_api, UNIT_TESTS)) + output.extend(WasGitClUploadHookModified(input_api, output_api)) return output @@ -33,4 +34,14 @@ def CheckChangeOnCommit(input_api, output_api): UNIT_TESTS)) output.extend(input_api.canned_checks.CheckDoNotSubmit(input_api, output_api)) + output.extend(WasGitClUploadHookModified(input_api, output_api)) return output + +def WasGitClUploadHookModified(input_api, output_api): + for affected_file in input_api.AffectedSourceFiles(None): + if (input_api.os_path.basename(affected_file.LocalPath()) == + 'git-cl-upload-hook'): + return [output_api.PresubmitPromptWarning( + 'Don\'t forget to fix git-cl to download the newest version of ' + 'git-cl-upload-hook')] + return []