From ba2ef1b6a66f0c27ef6bdf6427f493ec91b31b8e Mon Sep 17 00:00:00 2001 From: Takuto Ikuta Date: Fri, 8 Mar 2024 05:01:22 +0000 Subject: [PATCH] autoninja.bat: fix comment about vpython We use vpython3 in autoninja.bat now. Current difference of python3 and vpython3 for autoninja.py invocation is like belows and I think several hundred milliseconds is acceptable increase for the build. gLinux: * vpython3: 240.0ms * python3: 99.1ms https://pastebin.com/LK8kUAHn gWindows: * vpython3: 912.7ms * python3: 611.8ms https://pastebin.com/Xqs77ipv MacBook Pro: * vpython3: 386.2ms * python3: 280.1ms https://pastebin.com/eyXEpM7Q Bug: 327625559 Change-Id: Iff52be12cb755b3ecdab6663a0038905cf178d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5348020 Commit-Queue: Takuto Ikuta Auto-Submit: Takuto Ikuta Reviewed-by: Bruce Dawson --- autoninja.bat | 1 - 1 file changed, 1 deletion(-) diff --git a/autoninja.bat b/autoninja.bat index dcfff54dcc..577262f8fc 100755 --- a/autoninja.bat +++ b/autoninja.bat @@ -25,7 +25,6 @@ if not defined AUTONINJA_BUILD_ID ( if "%NINJA_SUMMARIZE_BUILD%" == "1" set "NINJA_STATUS=[%%r processes, %%f/%%t @ %%o/s : %%es ] " :: Execute autoninja.py and pass all arguments to it. -:: Don't use vpython - it is too slow to start. :: Don't use python3 because it doesn't work in git bash on Windows and we :: should be consistent between autoninja.bat and the autoninja script used by :: git bash.