Use codereview.settings style for GENERATE_GIT_NUMBER_FOOTERS.

R=sergiyb@chromium.org
BUG=642493

Change-Id: Ic4acf4076fdf27c1ed5e75f0ed1dda4b16d675fc
Reviewed-on: https://chromium-review.googlesource.com/414469
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

git_cl.py

@@ -1016,7 +1016,7 @@ def ShouldGenerateGitNumberFooters():
     return False
   keyvals = gclient_utils.ParseCodereviewSettingsContent(
       cr_settings_file.read())
-  return keyvals.get('generate-git-number-footers', '').lower() == 'true'
+  return keyvals.get('GENERATE_GIT_NUMBER_FOOTERS', '').lower() == 'true'
 
 
 def ShortBranchName(branch):

tests/git_cl_test.py

@@ -930,22 +930,22 @@ class TestGitCl(TestCase):
 
   def test_ShouldGenerateGitNumberFooters(self):
     self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: StringIO.StringIO(
-      'generate-git-number-footers: true\n'
+      'GENERATE_GIT_NUMBER_FOOTERS: true\n'
     ))
     self.assertTrue(git_cl.ShouldGenerateGitNumberFooters())
 
     self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: StringIO.StringIO(
-      'generate-git-number-footers: false\n'
+      'GENERATE_GIT_NUMBER_FOOTERS: false\n'
     ))
     self.assertFalse(git_cl.ShouldGenerateGitNumberFooters())
 
     self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: StringIO.StringIO(
-      'generate-git-number-footers: anything but true is false\n'
+      'GENERATE_GIT_NUMBER_FOOTERS: anything but true is false\n'
     ))
     self.assertFalse(git_cl.ShouldGenerateGitNumberFooters())
 
     self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: StringIO.StringIO(
-      "whatever: ignored"
+      'whatever: ignored'
     ))
     self.assertFalse(git_cl.ShouldGenerateGitNumberFooters())